From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v1,14/14] usb:cdns3: Feature for changing role From: Roger Quadros Message-Id: <5BE446C0.6080706@ti.com> Date: Thu, 8 Nov 2018 16:22:56 +0200 To: Pawel Laszczak , "gregkh@linuxfoundation.org" Cc: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alan Douglas , "jbergsagel@ti.com" , "peter.chen@nxp.com" , Pawel Jez , Rahul Kumar List-ID: T24gMDgvMTEvMTggMTM6NTEsIFBhd2VsIExhc3pjemFrIHdyb3RlOgo+PiBPbiAwMy8xMS8xOCAx OTo1MSwgUGF3ZWwgTGFzemN6YWsgd3JvdGU6Cj4+PiBQYXRjaCBhZGRzIGZlYXR1cmUgdGhhdCBh bGxvdyB0byBjaGFuZ2Ugcm9sZSBmcm9tIHVzZXIgc3BhY2UuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1i eTogUGF3ZWwgTGFzemN6YWsgPHBhd2VsbEBjYWRlbmNlLmNvbT4KPj4+IC0tLQo+Pj4gIGRyaXZl cnMvdXNiL2NkbnMzL01ha2VmaWxlICB8ICAyICstCj4+PiAgZHJpdmVycy91c2IvY2RuczMvY29y ZS5jICAgIHwgIDIgKwo+Pj4gIGRyaXZlcnMvdXNiL2NkbnMzL2RlYnVnZnMuYyB8IDk0ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4+ICBkcml2ZXJzL3VzYi9jZG5zMy9k cmQuaCAgICAgfCAgMyArKwo+Pj4gIDQgZmlsZXMgY2hhbmdlZCwgMTAwIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKPj4+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy91c2IvY2RuczMv ZGVidWdmcy5jCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2NkbnMzL01ha2VmaWxl IGIvZHJpdmVycy91c2IvY2RuczMvTWFrZWZpbGUKPj4+IGluZGV4IDM0ZTYwZDAzYzRlYy4uMDhl NmNkYmViZDQ2IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy91c2IvY2RuczMvTWFrZWZpbGUKPj4+ ICsrKyBiL2RyaXZlcnMvdXNiL2NkbnMzL01ha2VmaWxlCj4+PiBAQCAtMSw3ICsxLDcgQEAKPj4+ ICBvYmotJChDT05GSUdfVVNCX0NETlMzKQkJCSs9IGNkbnMzLm8KPj4+ICBvYmotJChDT05GSUdf VVNCX0NETlMzX1BDSV9XUkFQKQkrPSBjZG5zMy1wY2kubwo+Pj4KPj4+IC1jZG5zMy15CQkJCQk6 PSBjb3JlLm8gZHJkLm8KPj4+ICtjZG5zMy15CQkJCQk6PSBjb3JlLm8gZHJkLm8gZGVidWdmcy5v Cj4+PiAgY2RuczMtJChDT05GSUdfVVNCX0NETlMzX0dBREdFVCkJKz0gZ2FkZ2V0Lm8gZXAwLm8g ZGVidWcubwo+Pj4gIGNkbnMzLSQoQ09ORklHX1VTQl9DRE5TM19IT1NUKQkJKz0gaG9zdC5vCj4+ PiAgY2RuczMtcGNpLXkJCSAJCTo9IGNkbnMzLXBjaS13cmFwLm8KPj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL3VzYi9jZG5zMy9jb3JlLmMgYi9kcml2ZXJzL3VzYi9jZG5zMy9jb3JlLmMKPj4+IGlu ZGV4IDIwYWU5ZTc2OTQwZS4uNDAxMmYxMDA3ZGE5IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy91 c2IvY2RuczMvY29yZS5jCj4+PiArKysgYi9kcml2ZXJzL3VzYi9jZG5zMy9jb3JlLmMKPj4+IEBA IC0zMDksNiArMzA5LDcgQEAgc3RhdGljIGludCBjZG5zM19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+Pj4gIAlpZiAocmV0KQo+Pj4gIAkJZ290byBlcnI0Owo+Pj4KPj4+ICsJ Y2RuczNfZGVidWdmc19pbml0KGNkbnMpOwo+Pj4gIAlkZXZpY2Vfc2V0X3dha2V1cF9jYXBhYmxl KGRldiwgdHJ1ZSk7Cj4+PiAgCXBtX3J1bnRpbWVfc2V0X2FjdGl2ZShkZXYpOwo+Pj4gIAlwbV9y dW50aW1lX2VuYWJsZShkZXYpOwo+Pj4gQEAgLTM0Niw2ICszNDcsNyBAQCBzdGF0aWMgaW50IGNk bnMzX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+Pj4gIAlwbV9ydW50aW1l X2dldF9zeW5jKCZwZGV2LT5kZXYpOwo+Pj4gIAlwbV9ydW50aW1lX2Rpc2FibGUoJnBkZXYtPmRl dik7Cj4+PiAgCXBtX3J1bnRpbWVfcHV0X25vaWRsZSgmcGRldi0+ZGV2KTsKPj4+ICsJY2RuczNf ZGVidWdmc19leGl0KGNkbnMpOwo+Pj4gIAljZG5zM19yZW1vdmVfcm9sZXMoY2Rucyk7Cj4+PiAg CXVzYl9waHlfc2h1dGRvd24oY2Rucy0+dXNicGh5KTsKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy91c2IvY2RuczMvZGVidWdmcy5jIGIvZHJpdmVycy91c2IvY2RuczMvZGVidWdmcy5jCj4+ PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+Pj4gaW5kZXggMDAwMDAwMDAwMDAwLi5kNDg3MWJjMWE2 OWQKPj4+IC0tLSAvZGV2L251bGwKPj4+ICsrKyBiL2RyaXZlcnMvdXNiL2NkbnMzL2RlYnVnZnMu Ywo+Pj4gQEAgLTAsMCArMSw5NCBAQAo+Pj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBH UEwtMi4wCj4+PiArLyoKPj4+ICsgKiBDYWRlbmNlIFVTQlNTIERSRCBDb250cm9sbGVyIERlYnVn RlMgZmlsZXIuCj4+PiArICoKPj4+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMTggQ2FkZW5jZS4KPj4+ ICsgKgo+Pj4gKyAqIEF1dGhvcjogUGF3ZWwgTGFzemN6YWsgPHBhd2VsbEBjYWRlbmNlLmNvbT4K Pj4+ICsgKi8KPj4+ICsKPj4+ICsjaW5jbHVkZSA8bGludXgvdHlwZXMuaD4KPj4+ICsjaW5jbHVk ZSA8bGludXgvZGVidWdmcy5oPgo+Pj4gKyNpbmNsdWRlIDxsaW51eC9zZXFfZmlsZS5oPgo+Pj4g KyNpbmNsdWRlIDxsaW51eC91YWNjZXNzLmg+Cj4+PiArCj4+PiArI2luY2x1ZGUgImNvcmUuaCIK Pj4+ICsjaW5jbHVkZSAiZ2FkZ2V0LmgiCj4+PiArCj4+PiArc3RhdGljIGludCBjZG5zM19tb2Rl X3Nob3coc3RydWN0IHNlcV9maWxlICpzLCB2b2lkICp1bnVzZWQpCj4+PiArewo+Pj4gKwlzdHJ1 Y3QgY2RuczMJCSpjZG5zID0gcy0+cHJpdmF0ZTsKPj4+ICsKPj4+ICsJc3dpdGNoIChjZG5zLT5y b2xlKSB7Cj4+PiArCWNhc2UgQ0ROUzNfUk9MRV9IT1NUOgo+Pj4gKwkJc2VxX3B1dHMocywgImhv c3RcbiIpOwo+Pj4gKwkJYnJlYWs7Cj4+PiArCWNhc2UgQ0ROUzNfUk9MRV9HQURHRVQ6Cj4+PiAr CQlzZXFfcHV0cyhzLCAiZGV2aWNlXG4iKTsKPj4+ICsJCWJyZWFrOwo+Pj4gKwljYXNlIENETlMz X1JPTEVfT1RHOgo+Pj4gKwljYXNlIENETlMzX1JPTEVfRU5EOgo+Pj4gKwkJc2VxX3B1dHMocywg Im90Z1xuIik7Cj4+PiArCQlicmVhazsKPj4+ICsJZGVmYXVsdDoKPj4+ICsJCXNlcV9wdXRzKHMs ICJVTktOT1dOIG1vZGVcbiIpOwo+Pj4gKwl9Cj4+PiArCj4+PiArCXJldHVybiAwOwo+Pj4gK30K Pj4+ICsKPj4+ICtzdGF0aWMgaW50IGNkbnMzX21vZGVfb3BlbihzdHJ1Y3QgaW5vZGUgKmlub2Rl LCBzdHJ1Y3QgZmlsZSAqZmlsZSkKPj4+ICt7Cj4+PiArCXJldHVybiBzaW5nbGVfb3BlbihmaWxl LCBjZG5zM19tb2RlX3Nob3csIGlub2RlLT5pX3ByaXZhdGUpOwo+Pj4gK30KPj4+ICsKPj4+ICtz dGF0aWMgc3NpemVfdCBjZG5zM19tb2RlX3dyaXRlKHN0cnVjdCBmaWxlICpmaWxlLAo+Pj4gKwkJ CQljb25zdCBjaGFyIF9fdXNlciAqdWJ1ZiwKPj4+ICsJCQkJc2l6ZV90IGNvdW50LCBsb2ZmX3Qg KnBwb3MpCj4+PiArewo+Pj4gKwlzdHJ1Y3Qgc2VxX2ZpbGUJCSpzID0gZmlsZS0+cHJpdmF0ZV9k YXRhOwo+Pj4gKwlzdHJ1Y3QgY2RuczMJCSpjZG5zID0gcy0+cHJpdmF0ZTsKPj4+ICsJdTMyCQkJ bW9kZSA9IDA7Cj4+PiArCWNoYXIJCQlidWZbMzJdOwo+Pj4gKwo+Pj4gKwlpZiAoY29weV9mcm9t X3VzZXIoJmJ1ZiwgdWJ1ZiwgbWluX3Qoc2l6ZV90LCBzaXplb2YoYnVmKSAtIDEsIGNvdW50KSkp Cj4+PiArCQlyZXR1cm4gLUVGQVVMVDsKPj4+ICsKPj4+ICsJaWYgKCFzdHJuY21wKGJ1ZiwgImhv c3QiLCA0KSkKPj4+ICsJCW1vZGUgPSBVU0JfRFJfTU9ERV9IT1NUOwo+Pj4gKwo+Pj4gKwlpZiAo IXN0cm5jbXAoYnVmLCAiZGV2aWNlIiwgNikpCj4+PiArCQltb2RlID0gVVNCX0RSX01PREVfUEVS SVBIRVJBTDsKPj4+ICsKPj4+ICsJaWYgKCFzdHJuY21wKGJ1ZiwgIm90ZyIsIDMpKQo+Pj4gKwkJ bW9kZSA9IFVTQl9EUl9NT0RFX09URzsKPj4+ICsKPj4+ICsJY2Rucy0+ZGVzaXJlZF9yb2xlID0g bW9kZTsKPj4+ICsJcXVldWVfd29yayhzeXN0ZW1fZnJlZXphYmxlX3dxLCAmY2Rucy0+cm9sZV9z d2l0Y2hfd3EpOwo+Pgo+PiBJZiB3ZSBzdGFydCB3aXRoIE9URyBtb2RlIGFuZCB1c2VyIHNheXMg Y2hhbmdlIG1vZGUgdG8gZGV2aWNlIHdpbGwgd2Ugc3RpbGwKPj4gc3dpdGNoIHRvIGhvc3QgYmFz ZWQgb24gSUQgcGluIGNoYW5nZT8KPj4KPj4gSWYgaXQgZG9lcyB0aGVuIHRoaXMgaXNuJ3Qgd29y a2luZyBjb3JyZWN0bHkuCj4+IFdlIG5lZWQgdG8gc3RvcCBwcm9jZXNzaW5nIElEIGludGVycnVw dHMgYW5kIGtlZXAgdGhlIHJvbGUgc3RhdGljIHRpbGwKPj4gdGhlIHVzZXIgc3dpdGNoZXMgaXQg YmFjayB0byBvdGcuCj4gCj4gU3dpdGNoaW5nIHJvbGUgZm9ybSB1c2VyIHNwYWNlIHdpbGwgbGlt aXRlZCBkcml2ZXIgb25seSB0byBzZWxlY3RlZCBtb2RlLiAKPiBPbmx5IGZvciBVU0JfRFJfTU9E RV9PVEcgZHJpdmVyIHNob3VsZCBiYXNlIG9uIElEIHBpbi4gCj4gVGhhdCdzIG15IGludGVuc2lv bi4KPiAKClVzZXIgc3BhY2Ugc2V0dGluZyBzaG91bGQgb3ZlcnJpZGUgSUQgaWYgaXQgd2FzIE9U RyBtb2RlLiBBdCBsZWFzdCB0aGlzIGlzIGhvdwppdCBpcyBmb3IgZHdjMy4gVGhhdCB3YXkgaXQg aXMgdXNlZnVsIGZvciB0ZXN0aW5nIHJvbGUgc3dhcC4KCmNoZWVycywKLXJvZ2VyCgo+Pj4gKwly ZXR1cm4gY291bnQ7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZmlsZV9v cGVyYXRpb25zIGNkbnMzX21vZGVfZm9wcyA9IHsKPj4+ICsJLm9wZW4JCQk9IGNkbnMzX21vZGVf b3BlbiwKPj4+ICsJLndyaXRlCQkJPSBjZG5zM19tb2RlX3dyaXRlLAo+Pj4gKwkucmVhZAkJCT0g c2VxX3JlYWQsCj4+PiArCS5sbHNlZWsJCQk9IHNlcV9sc2VlaywKPj4+ICsJLnJlbGVhc2UJCT0g c2luZ2xlX3JlbGVhc2UsCj4+PiArfTsKPj4+ICsKPj4+ICt2b2lkIGNkbnMzX2RlYnVnZnNfaW5p dChzdHJ1Y3QgY2RuczMgKmNkbnMpCj4+PiArewo+Pj4gKwlzdHJ1Y3QgZGVudHJ5ICpyb290Owo+ Pj4gKwo+Pj4gKwlyb290ID0gZGVidWdmc19jcmVhdGVfZGlyKGRldl9uYW1lKGNkbnMtPmRldiks IE5VTEwpOwo+Pj4gKwljZG5zLT5yb290ID0gcm9vdDsKPj4+ICsJaWYgKElTX0VOQUJMRUQoQ09O RklHX1VTQl9DRE5TM19HQURHRVQpICYmCj4+PiArCSAgICBJU19FTkFCTEVEKENPTkZJR19VU0Jf Q0ROUzNfSE9TVCkpCj4+PiArCQlkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJtb2RlIiwgMDY0NCwgcm9v dCwgY2RucywKPj4+ICsJCQkJICAgICZjZG5zM19tb2RlX2ZvcHMpOwo+Pj4gK30KPj4+ICsKPj4+ ICt2b2lkIGNkbnMzX2RlYnVnZnNfZXhpdChzdHJ1Y3QgY2RuczMgKmNkbnMpCj4+PiArewo+Pj4g KwlkZWJ1Z2ZzX3JlbW92ZV9yZWN1cnNpdmUoY2Rucy0+cm9vdCk7Cj4+PiArfQo+Pj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvdXNiL2NkbnMzL2RyZC5oIGIvZHJpdmVycy91c2IvY2RuczMvZHJkLmgK Pj4+IGluZGV4IDg1NzMxZjNiNjkzYy4uNTM0NDI5MGM3NmYyIDEwMDY0NAo+Pj4gLS0tIGEvZHJp dmVycy91c2IvY2RuczMvZHJkLmgKPj4+ICsrKyBiL2RyaXZlcnMvdXNiL2NkbnMzL2RyZC5oCj4+ PiBAQCAtMTE5LDQgKzExOSw3IEBAIGludCBjZG5zM19kcmRfcHJvYmUoc3RydWN0IGNkbnMzICpj ZG5zKTsKPj4+ICB2b2lkIGNkbnMzX3NldF9od19tb2RlKHN0cnVjdCBjZG5zMyAqY2RucywgdTMy IG1vZGUpOwo+Pj4gIGlycXJldHVybl90IGNkbnMzX2RyZF9pcnEoc3RydWN0IGNkbnMzICpjZG5z KTsKPj4+Cj4+PiArdm9pZCBjZG5zM19kZWJ1Z2ZzX2luaXQoc3RydWN0IGNkbnMzICpjZG5zKTsK Pj4+ICt2b2lkIGNkbnMzX2RlYnVnZnNfZXhpdChzdHJ1Y3QgY2RuczMgKmNkbnMpOwo+Pj4gKwo+ Pj4gICNlbmRpZiAvKiBfX0xJTlVYX0NETlMzX0RSRCAqLwo+Pj4KPj4KPj4gY2hlZXJzLAo+PiAt cm9nZXIKPj4gLS0KPj4gVGV4YXMgSW5zdHJ1bWVudHMgRmlubGFuZCBPeSwgUG9ya2thbGFua2F0 dSAyMiwgMDAxODAgSGVsc2lua2kuCj4+IFktdHVubnVzL0J1c2luZXNzIElEOiAwNjE1NTIxLTQu IEtvdGlwYWlra2EvRG9taWNpbGU6IEhlbHNpbmtpCj4gCj4gCj4gVGhhbmtzLAo+IENoZWVycywK PiBQYXdlbAo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C1E1ECDE4B for ; Thu, 8 Nov 2018 14:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20D162086C for ; Thu, 8 Nov 2018 14:23:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20D162086C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726927AbeKHX6t (ORCPT ); Thu, 8 Nov 2018 18:58:49 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:59270 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbeKHX6t (ORCPT ); Thu, 8 Nov 2018 18:58:49 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id wA8EN0sr086106; Thu, 8 Nov 2018 08:23:00 -0600 Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wA8EMx05081752 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Nov 2018 08:23:00 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 8 Nov 2018 08:22:59 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Thu, 8 Nov 2018 08:22:59 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wA8EMvRc003140; Thu, 8 Nov 2018 08:22:57 -0600 Subject: Re: [RFC PATCH v1 14/14] usb:cdns3: Feature for changing role To: Pawel Laszczak , "gregkh@linuxfoundation.org" References: <1541267487-3664-1-git-send-email-pawell@cadence.com> <1541267487-3664-15-git-send-email-pawell@cadence.com> <5BE1AA81.3030107@ti.com> CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alan Douglas , "jbergsagel@ti.com" , "peter.chen@nxp.com" , Pawel Jez , Rahul Kumar From: Roger Quadros Message-ID: <5BE446C0.6080706@ti.com> Date: Thu, 8 Nov 2018 16:22:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/18 13:51, Pawel Laszczak wrote: >> On 03/11/18 19:51, Pawel Laszczak wrote: >>> Patch adds feature that allow to change role from user space. >>> >>> Signed-off-by: Pawel Laszczak >>> --- >>> drivers/usb/cdns3/Makefile | 2 +- >>> drivers/usb/cdns3/core.c | 2 + >>> drivers/usb/cdns3/debugfs.c | 94 +++++++++++++++++++++++++++++++++++++ >>> drivers/usb/cdns3/drd.h | 3 ++ >>> 4 files changed, 100 insertions(+), 1 deletion(-) >>> create mode 100644 drivers/usb/cdns3/debugfs.c >>> >>> diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile >>> index 34e60d03c4ec..08e6cdbebd46 100644 >>> --- a/drivers/usb/cdns3/Makefile >>> +++ b/drivers/usb/cdns3/Makefile >>> @@ -1,7 +1,7 @@ >>> obj-$(CONFIG_USB_CDNS3) += cdns3.o >>> obj-$(CONFIG_USB_CDNS3_PCI_WRAP) += cdns3-pci.o >>> >>> -cdns3-y := core.o drd.o >>> +cdns3-y := core.o drd.o debugfs.o >>> cdns3-$(CONFIG_USB_CDNS3_GADGET) += gadget.o ep0.o debug.o >>> cdns3-$(CONFIG_USB_CDNS3_HOST) += host.o >>> cdns3-pci-y := cdns3-pci-wrap.o >>> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c >>> index 20ae9e76940e..4012f1007da9 100644 >>> --- a/drivers/usb/cdns3/core.c >>> +++ b/drivers/usb/cdns3/core.c >>> @@ -309,6 +309,7 @@ static int cdns3_probe(struct platform_device *pdev) >>> if (ret) >>> goto err4; >>> >>> + cdns3_debugfs_init(cdns); >>> device_set_wakeup_capable(dev, true); >>> pm_runtime_set_active(dev); >>> pm_runtime_enable(dev); >>> @@ -346,6 +347,7 @@ static int cdns3_remove(struct platform_device *pdev) >>> pm_runtime_get_sync(&pdev->dev); >>> pm_runtime_disable(&pdev->dev); >>> pm_runtime_put_noidle(&pdev->dev); >>> + cdns3_debugfs_exit(cdns); >>> cdns3_remove_roles(cdns); >>> usb_phy_shutdown(cdns->usbphy); >>> >>> diff --git a/drivers/usb/cdns3/debugfs.c b/drivers/usb/cdns3/debugfs.c >>> new file mode 100644 >>> index 000000000000..d4871bc1a69d >>> --- /dev/null >>> +++ b/drivers/usb/cdns3/debugfs.c >>> @@ -0,0 +1,94 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Cadence USBSS DRD Controller DebugFS filer. >>> + * >>> + * Copyright (C) 2018 Cadence. >>> + * >>> + * Author: Pawel Laszczak >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include "core.h" >>> +#include "gadget.h" >>> + >>> +static int cdns3_mode_show(struct seq_file *s, void *unused) >>> +{ >>> + struct cdns3 *cdns = s->private; >>> + >>> + switch (cdns->role) { >>> + case CDNS3_ROLE_HOST: >>> + seq_puts(s, "host\n"); >>> + break; >>> + case CDNS3_ROLE_GADGET: >>> + seq_puts(s, "device\n"); >>> + break; >>> + case CDNS3_ROLE_OTG: >>> + case CDNS3_ROLE_END: >>> + seq_puts(s, "otg\n"); >>> + break; >>> + default: >>> + seq_puts(s, "UNKNOWN mode\n"); >>> + } >>> + >>> + return 0; >>> +} >>> + >>> +static int cdns3_mode_open(struct inode *inode, struct file *file) >>> +{ >>> + return single_open(file, cdns3_mode_show, inode->i_private); >>> +} >>> + >>> +static ssize_t cdns3_mode_write(struct file *file, >>> + const char __user *ubuf, >>> + size_t count, loff_t *ppos) >>> +{ >>> + struct seq_file *s = file->private_data; >>> + struct cdns3 *cdns = s->private; >>> + u32 mode = 0; >>> + char buf[32]; >>> + >>> + if (copy_from_user(&buf, ubuf, min_t(size_t, sizeof(buf) - 1, count))) >>> + return -EFAULT; >>> + >>> + if (!strncmp(buf, "host", 4)) >>> + mode = USB_DR_MODE_HOST; >>> + >>> + if (!strncmp(buf, "device", 6)) >>> + mode = USB_DR_MODE_PERIPHERAL; >>> + >>> + if (!strncmp(buf, "otg", 3)) >>> + mode = USB_DR_MODE_OTG; >>> + >>> + cdns->desired_role = mode; >>> + queue_work(system_freezable_wq, &cdns->role_switch_wq); >> >> If we start with OTG mode and user says change mode to device will we still >> switch to host based on ID pin change? >> >> If it does then this isn't working correctly. >> We need to stop processing ID interrupts and keep the role static till >> the user switches it back to otg. > > Switching role form user space will limited driver only to selected mode. > Only for USB_DR_MODE_OTG driver should base on ID pin. > That's my intension. > User space setting should override ID if it was OTG mode. At least this is how it is for dwc3. That way it is useful for testing role swap. cheers, -roger >>> + return count; >>> +} >>> + >>> +static const struct file_operations cdns3_mode_fops = { >>> + .open = cdns3_mode_open, >>> + .write = cdns3_mode_write, >>> + .read = seq_read, >>> + .llseek = seq_lseek, >>> + .release = single_release, >>> +}; >>> + >>> +void cdns3_debugfs_init(struct cdns3 *cdns) >>> +{ >>> + struct dentry *root; >>> + >>> + root = debugfs_create_dir(dev_name(cdns->dev), NULL); >>> + cdns->root = root; >>> + if (IS_ENABLED(CONFIG_USB_CDNS3_GADGET) && >>> + IS_ENABLED(CONFIG_USB_CDNS3_HOST)) >>> + debugfs_create_file("mode", 0644, root, cdns, >>> + &cdns3_mode_fops); >>> +} >>> + >>> +void cdns3_debugfs_exit(struct cdns3 *cdns) >>> +{ >>> + debugfs_remove_recursive(cdns->root); >>> +} >>> diff --git a/drivers/usb/cdns3/drd.h b/drivers/usb/cdns3/drd.h >>> index 85731f3b693c..5344290c76f2 100644 >>> --- a/drivers/usb/cdns3/drd.h >>> +++ b/drivers/usb/cdns3/drd.h >>> @@ -119,4 +119,7 @@ int cdns3_drd_probe(struct cdns3 *cdns); >>> void cdns3_set_hw_mode(struct cdns3 *cdns, u32 mode); >>> irqreturn_t cdns3_drd_irq(struct cdns3 *cdns); >>> >>> +void cdns3_debugfs_init(struct cdns3 *cdns); >>> +void cdns3_debugfs_exit(struct cdns3 *cdns); >>> + >>> #endif /* __LINUX_CDNS3_DRD */ >>> >> >> cheers, >> -roger >> -- >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > > Thanks, > Cheers, > Pawel > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki