All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yu, Mingli" <mingli.yu@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/7] python3: add tk support
Date: Mon, 12 Nov 2018 10:28:11 +0800	[thread overview]
Message-ID: <5BE8E53B.2010405@windriver.com> (raw)
In-Reply-To: <CAJTo0LZcL0H=sEdc7n7BRw+u-R3fHNb=2ooJO1hkPsp404PLqg@mail.gmail.com>



On 2018年11月09日 21:02, Burton, Ross wrote:
> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com> wrote:
>>> Why is this here and not in the manifest?
>>
>> It's because we can optionally enable or disable tk via PACKAGECONFIG,
>> if add it to manifest then we need to always enable tk which is also the
>> implement in v1.
>
> Are you sure?  As I understand it there won't be any errors if the
> contents don't exist.  And to be honest if there are, then the
> manifest tooling should handle that neatly without special-casing.

Hi Ross,

Thanks for your feedback!

I didn't quite understand what you mean. As I know, if we add the the 
setting in manifest as below:
diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json 
b/meta/recipes-devtools/python/python3/python3-manifest.json
index f922561..09c9199 100644
--- a/meta/recipes-devtools/python/python3/python3-manifest.json
+++ b/meta/recipes-devtools/python/python3/python3-manifest.json
@@ -1056,10 +1056,12 @@
      "tkinter": {
          "summary": "Python Tcl/Tk bindings",
          "rdepends": [
-            "core"
+            "core",
+            "tk"
          ],
          "files": [
-            "${libdir}/python${PYTHON_MAJMIN}/tkinter"
+            "${libdir}/python${PYTHON_MAJMIN}/tkinter",
+            "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
          ],
          "cached": []
      },

There comes below error:
ERROR: Nothing RPROVIDES 'python3-tk' (but 
/mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb 
RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'python3-tk' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['python3-tk']
ERROR: Required build target 'python3' has no buildable providers.
Missing or unbuildable dependency chain was: ['python3', 'python3-tk']

That's to say, we still need to add some fix in 
meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be flexible 
and clear to directly to make the implement just as what I send in the RR.

Thanks,

>
> Ross
>


  reply	other threads:[~2018-11-12  2:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
2018-11-08  6:08 ` [PATCH v2 1/7] python: " mingli.yu
2018-11-14  9:38   ` [PATCH v3] " mingli.yu
2018-11-19  1:31     ` Yu, Mingli
2018-11-23  1:30     ` Yu, Mingli
2018-11-08  6:08 ` [PATCH 2/7] python3: " mingli.yu
2018-11-08 13:49   ` Burton, Ross
2018-11-09  1:38     ` Yu, Mingli
2018-11-09 13:02       ` Burton, Ross
2018-11-12  2:28         ` Yu, Mingli [this message]
2018-11-12 15:28           ` Alejandro Hernandez
2018-11-13  3:03             ` Yu, Mingli
2018-11-13  8:25               ` Alejandro Hernandez
2018-11-13  9:10                 ` Yu, Mingli
2018-11-13 21:26                   ` Alejandro Hernandez
2018-11-14  8:23                     ` Yu, Mingli
2018-11-14  9:36   ` [PATCH v2] " mingli.yu
2018-11-19  1:32     ` Yu, Mingli
2018-11-23  1:29     ` Yu, Mingli
2018-11-23 11:03       ` richard.purdie
2018-11-23 11:14         ` Richard Purdie
2018-11-08  6:08 ` [PATCH 3/7] libxt: extend to nativesdk mingli.yu
2018-11-08  6:08 ` [PATCH 4/7] libxft: " mingli.yu
2018-11-08  6:08 ` [PATCH 5/7] fontconfig: " mingli.yu
2018-11-08  6:08 ` [PATCH 6/7] libsm: " mingli.yu
2018-11-08  6:08 ` [PATCH 7/7] libice: " mingli.yu
2018-11-08  6:12 ` [PATCH v2 0/7] python/python3: add tk support mingli.yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BE8E53B.2010405@windriver.com \
    --to=mingli.yu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.