From: Roger Quadros <rogerq@ti.com>
To: Felipe Balbi <balbi@kernel.org>,
Thinh Nguyen <thinh.nguyen@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <john.youn@synopsys.com>
Subject: [3/3] usb: dwc3: Support option to disable USB2 LPM
Date: Mon, 12 Nov 2018 13:06:29 +0200 [thread overview]
Message-ID: <5BE95EB5.6030706@ti.com> (raw)
On 12/11/18 13:03, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rogerq@ti.com> writes:
>>>> Also can we have some consistency in usage of '-' vs '_'?
>>> Right.. I agree. I've been using '-' as it is the preferred syntax as
>>> most of the properties, but some old properties use '_'. Do you have any
>>> suggestion?
>>
>> I'd keep it consistent to "snps,usb3_lpm_capable" so we avoid mistakes
>> when writing the DT.
>> Felipe?
>
> _ are not really accepted in DT, except for legacy properties. What we
> can do is rename usb3_lpm_capable to usb3-lpm-capable and change code to
> try with _ if - fails. Then we can introduce the new property using -
>
I agree. This is a better approach.
cheers,
-roger
next reply other threads:[~2018-11-12 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 11:06 Roger Quadros [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-12 11:03 [3/3] usb: dwc3: Support option to disable USB2 LPM Felipe Balbi
2018-11-12 10:45 Roger Quadros
2018-11-12 5:29 Thinh Nguyen
2018-11-09 11:58 Roger Quadros
2018-11-08 12:22 Felipe Balbi
2018-11-08 10:58 Oliver Neukum
2018-11-08 10:48 Felipe Balbi
2018-11-08 10:47 Felipe Balbi
2018-11-08 8:25 Oliver Neukum
2018-11-08 2:10 Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE95EB5.6030706@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=john.youn@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=thinh.nguyen@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.