From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v2,05/15] usb:cdns3: Added DRD support From: Roger Quadros Message-Id: <5BF8140C.7000605@ti.com> Date: Fri, 23 Nov 2018 16:51:56 +0200 To: Pawel Laszczak , devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-ID: T24gMTgvMTEvMTggMTI6MDksIFBhd2VsIExhc3pjemFrIHdyb3RlOgo+IFBhdGNoIGFkZHMgc3Vw cG9ydHMgZm9yIGRldGVjdGluZyBIb3N0L0RldmljZSBtb2RlLgo+IENvbnRyb2xsZXIgaGFzIGFk ZGl0aW9uYWwgT1RHIHJlZ2lzdGVyIHRoYXQgYWxsb3cKPiBpbXBsZW1lbnQgZXZlbiB3aG9sZSBP VEcgZnVuY3Rpb25hbGl0eS4KPiBBdCB0aGlzIG1vbWVudCBwYXRjaCBhZGRzIHN1cHBvcnQgb25s eSBmb3IgZGV0ZWN0aW5nCj4gdGhlIGFwcHJvcHJpYXRlIG1vZGUgYmFzZWQgb24gc3RyYXAgcGlu cyBhbmQgSUQgcGluLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhd2VsIExhc3pjemFrIDxwYXdlbGxA Y2FkZW5jZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvdXNiL2NkbnMzL01ha2VmaWxlIHwgICAyICst Cj4gIGRyaXZlcnMvdXNiL2NkbnMzL2NvcmUuYyAgIHwgIDI3ICsrKy0tCj4gIGRyaXZlcnMvdXNi L2NkbnMzL2RyZC5jICAgIHwgMjI5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPiAgZHJpdmVycy91c2IvY2RuczMvZHJkLmggICAgfCAxMjIgKysrKysrKysrKysrKysrKysr KysKPiAgNCBmaWxlcyBjaGFuZ2VkLCAzNzIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkK PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvdXNiL2NkbnMzL2RyZC5jCj4gIGNyZWF0ZSBt b2RlIDEwMDY0NCBkcml2ZXJzL3VzYi9jZG5zMy9kcmQuaAo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL3VzYi9jZG5zMy9NYWtlZmlsZSBiL2RyaXZlcnMvdXNiL2NkbnMzL01ha2VmaWxlCj4gaW5k ZXggMDJkMjViMjNjNWQzLi5lNzc5YjJhMmY4ZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2Iv Y2RuczMvTWFrZWZpbGUKPiArKysgYi9kcml2ZXJzL3VzYi9jZG5zMy9NYWtlZmlsZQo+IEBAIC0x LDUgKzEsNSBAQAo+ICBvYmotJChDT05GSUdfVVNCX0NETlMzKQkJCSs9IGNkbnMzLm8KPiAgb2Jq LSQoQ09ORklHX1VTQl9DRE5TM19QQ0lfV1JBUCkJKz0gY2RuczMtcGNpLm8KPiAgCj4gLWNkbnMz LXkJCQkJCTo9IGNvcmUubwo+ICtjZG5zMy15CQkJCQk6PSBjb3JlLm8gZHJkLm8KPiAgY2RuczMt cGNpLXkJCSAJCTo9IGNkbnMzLXBjaS13cmFwLm8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Iv Y2RuczMvY29yZS5jIGIvZHJpdmVycy91c2IvY2RuczMvY29yZS5jCj4gaW5kZXggZjkwNTVkNGRh NjdmLi5kYmVlNDMyNWRhN2YgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvY2RuczMvY29yZS5j Cj4gKysrIGIvZHJpdmVycy91c2IvY2RuczMvY29yZS5jCj4gQEAgLTE3LDYgKzE3LDcgQEAKPiAg Cj4gICNpbmNsdWRlICJnYWRnZXQuaCIKPiAgI2luY2x1ZGUgImNvcmUuaCIKPiArI2luY2x1ZGUg ImRyZC5oIgo+ICAKPiAgc3RhdGljIGlubGluZSBzdHJ1Y3QgY2RuczNfcm9sZV9kcml2ZXIgKmNk bnMzX2dldF9jdXJyZW50X3JvbGVfZHJpdmVyKHN0cnVjdCBjZG5zMyAqY2RucykKPiAgewo+IEBA IC01Nyw4ICs1OCwxMCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgY2RuczNfcm9sZV9zdG9wKHN0cnVj dCBjZG5zMyAqY2RucykKPiAgc3RhdGljIGVudW0gY2RuczNfcm9sZXMgY2RuczNfZ2V0X3JvbGUo c3RydWN0IGNkbnMzICpjZG5zKQo+ICB7Cj4gIAlpZiAoY2Rucy0+cm9sZXNbQ0ROUzNfUk9MRV9I T1NUXSAmJiBjZG5zLT5yb2xlc1tDRE5TM19ST0xFX0dBREdFVF0pIHsKPiAtCQkvL1RPRE86IGlt cGxlbWVudHMgc2VsZWN0aW5nIGRldmljZS9ob3N0IG1vZGUKPiAtCQlyZXR1cm4gQ0ROUzNfUk9M RV9IT1NUOwo+ICsJCWlmIChjZG5zM19pc19ob3N0KGNkbnMpKQo+ICsJCQlyZXR1cm4gQ0ROUzNf Uk9MRV9IT1NUOwo+ICsJCWlmIChjZG5zM19pc19kZXZpY2UoY2RucykpCj4gKwkJCXJldHVybiBD RE5TM19ST0xFX0dBREdFVDsKPiAgCX0KPiAgCXJldHVybiBjZG5zLT5yb2xlc1tDRE5TM19ST0xF X0hPU1RdCj4gIAkJPyBDRE5TM19ST0xFX0hPU1QKPiBAQCAtMTI0LDYgKzEyNywxMiBAQCBzdGF0 aWMgaXJxcmV0dXJuX3QgY2RuczNfaXJxKGludCBpcnEsIHZvaWQgKmRhdGEpCj4gIAlzdHJ1Y3Qg Y2RuczMgKmNkbnMgPSBkYXRhOwo+ICAJaXJxcmV0dXJuX3QgcmV0ID0gSVJRX05PTkU7Cj4gIAo+ ICsJaWYgKGNkbnMtPmRyX21vZGUgPT0gVVNCX0RSX01PREVfT1RHKSB7Cj4gKwkJcmV0ID0gY2Ru czNfZHJkX2lycShjZG5zKTsKPiArCQlpZiAocmV0ID09IElSUV9IQU5ETEVEKQo+ICsJCQlyZXR1 cm4gcmV0Owo+ICsJfQoKVGhlIGtlcm5lbCdzIHNoYXJlZCBJUlEgbW9kZWwgdGFrZXMgY2FyZSBv ZiBzaGFyaW5nIHRoZSBzYW1lIGludGVycnVwdApiZXR3ZWVuIGRpZmZlcmVudCBkZXZpY2VzIGFu ZCB0aGVpciBkcml2ZXJzLiBZb3UgZG9uJ3QgbmVlZCB0byBtYW51YWxseQpoYW5kbGUgaXQgaGVy ZS4gSnVzdCBsZXQgYWxsIDMgZHJpdmVycyBkbyBhIHJlcXVlc3RfaXJxKCkgYW5kIGhhdmUKaGFu ZGxlcnMgY2hlY2sgaWYgdGhlIElSUSB3YXMgdGhlaXJzIG9yIG5vdCBhbmQgcmV0dXJuIElSUV9I QU5ETEVEIG9yCklSUV9OT05FIGFjY29yZGluZ2x5LgoKTG9va3MgbGlrZSB5b3UgY2FuIGRvIGF3 YXkgd2l0aCBpcnEgbWVtYmVyIG9mIHRoZSByb2xlIGRyaXZlciBzdHJ1Y3QuCgo+ICsKPiAgCS8q IEhhbmRsZSBkZXZpY2UvaG9zdCBpbnRlcnJ1cHQgKi8KPiAgCWlmIChjZG5zLT5yb2xlICE9IENE TlMzX1JPTEVfRU5EKQo+ICAJCXJldCA9IGNkbnMzX2dldF9jdXJyZW50X3JvbGVfZHJpdmVyKGNk bnMpLT5pcnEoY2Rucyk7Cj4gQEAgLTE3NiwxMSArMTg1LDggQEAgc3RhdGljIHZvaWQgY2RuczNf cm9sZV9zd2l0Y2goc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAKPiAgCWNkbnMgPSBjb250 YWluZXJfb2Yod29yaywgc3RydWN0IGNkbnMzLCByb2xlX3N3aXRjaF93cSk7Cj4gIAo+IC0JLy9U T0RPOiBpbXBsZW1lbnRzIHRoaXMgZnVuY3Rpb25zLgo+IC0JLy9ob3N0ID0gY2RuczNfaXNfaG9z dChjZG5zKTsKPiAtCS8vZGV2aWNlID0gY2RuczNfaXNfZGV2aWNlKGNkbnMpOwo+IC0JaG9zdCA9 IDE7Cj4gLQlkZXZpY2UgPSAwOwo+ICsJaG9zdCA9IGNkbnMzX2lzX2hvc3QoY2Rucyk7Cj4gKwlk ZXZpY2UgPSBjZG5zM19pc19kZXZpY2UoY2Rucyk7CgpXaGF0IGlmIHRoZXJlIGlzIGEgSUQgdHJh bnNpdGlvbiBiZXR3ZWVuIHRoZSAyIGZ1bmN0aW9ucyBzbyB0aGF0CmFuZCBib3RoIGhvc3QgYW5k IGRldmljZSBiZWNvbWUgdHJ1ZT8KU2luY2UgeW91IGFyZSBjaGVja2luZyB0aGUgSUQgbGV2ZWwg c2VwYXJhdGVseSBpbiBib3RoIHRoZSBmdW5jdGlvbnMuCgpIb3cgYWJvdXQgaW5zdGVhZCBoYXZp bmcgY2RuczNfZ2V0X2lkKCkgYW5kIHVzaW5nCml0IHRvIHN0YXJ0L3N0b3AgcmVsZXZhbnQgcm9s ZXMgaWYgd2UgYXJlIGluIE9URyBtb2RlLgoKSXMgdGhpcyBnb2luZyB0byBiZSB1c2VkIGZvciBh IHJvbGUgc3dpdGNoIGV2ZW4gaWYgd2UncmUgbm90IGluIE9URyBtb2RlPwpJZiBub3QgdGhlbiBp dCBpcyBhIEJVRyBpZiB3ZSBnZXQgaGVyZS4KCj4gIAo+ICAJaWYgKGhvc3QpCj4gIAkJcm9sZSA9 IENETlMzX1JPTEVfSE9TVDsKPiBAQCAtMTk0LDYgKzIwMCwxMiBAQCBzdGF0aWMgdm9pZCBjZG5z M19yb2xlX3N3aXRjaChzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAlwbV9ydW50aW1lX2dl dF9zeW5jKGNkbnMtPmRldik7Cj4gIAljZG5zM19yb2xlX3N0b3AoY2Rucyk7Cj4gIAo+ICsJaWYg KGNkbnMtPmRlc2lyZWRfZHJfbW9kZSAhPSBjZG5zLT5jdXJyZW50X2RyX21vZGUpIHsKClRoaXMg aXMgYWJvdXQgcm9sZXMsIHdoeSBhcmUgd2UgY2hlY2tpbmcgZHJfbW9kZSBoZXJlPwoKPiArCQlj ZG5zM19kcmRfdXBkYXRlX21vZGUoY2Rucyk7Cj4gKwkJaG9zdCA9IGNkbnMzX2lzX2hvc3QoY2Ru cyk7Cj4gKwkJZGV2aWNlID0gY2RuczNfaXNfZGV2aWNlKGNkbnMpOwo+ICsJfQo+ICsKPiAgCWlm IChob3N0KSB7Cj4gIAkJaWYgKGNkbnMtPnJvbGVzW0NETlMzX1JPTEVfSE9TVF0pCj4gIAkJCWNk bnMzX2RvX3JvbGVfc3dpdGNoKGNkbnMsIENETlMzX1JPTEVfSE9TVCk7Cj4gQEAgLTI4Nyw2ICsy OTksNyBAQCBzdGF0aWMgaW50IGNkbnMzX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gZXJyMjsKPiAgCj4gKwlyZXQgPSBjZG5zM19kcmRf aW5pdChjZG5zKTsKPiAgCWlmIChyZXQpCj4gIAkJZ290byBlcnIyOwo+ICAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy91c2IvY2RuczMvZHJkLmMgYi9kcml2ZXJzL3VzYi9jZG5zMy9kcmQuYwo+IG5l dyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi5hYzc0MWM4MGU3NzYKPiAt LS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy91c2IvY2RuczMvZHJkLmMKPiBAQCAtMCwwICsx LDIyOSBAQAo+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ICsvKgo+ICsg KiBDYWRlbmNlIFVTQlNTIERSRCBEcml2ZXIuCj4gKyAqCj4gKyAqIENvcHlyaWdodCAoQykgMjAx OCBDYWRlbmNlLgo+ICsgKgo+ICsgKiBBdXRob3I6IFBhd2VsIExhc3pjemFrIDxwYXdlbGxAY2Fk ZW5jZS5jb20KPiArICoKPiArICovCj4gKyNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4KPiArI2lu Y2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+ICsjaW5jbHVkZSA8bGludXgvZGVsYXkuaD4KPiAr I2luY2x1ZGUgPGxpbnV4L3VzYi9vdGcuaD4KPiArCj4gKyNpbmNsdWRlICJnYWRnZXQuaCIKPiAr I2luY2x1ZGUgImRyZC5oIgo+ICsKPiArLyoqCj4gKyAqIGNkbnMzX3NldF9tb2RlIC0gY2hhbmdl IG1vZGUgb2YgT1RHIENvcmUKPiArICogQGNkbnM6IHBvaW50ZXIgdG8gY29udGV4dCBzdHJ1Y3R1 cmUKPiArICogQG1vZGU6IHNlbGVjdGVkIG1vZGUgZnJvbSBjZG5zX3JvbGUKPiArICovCj4gK3Zv aWQgY2RuczNfc2V0X21vZGUoc3RydWN0IGNkbnMzICpjZG5zLCBlbnVtIHVzYl9kcl9tb2RlIG1v ZGUpCj4gK3sKPiArCXUzMiByZWc7Cj4gKwo+ICsJY2Rucy0+Y3VycmVudF9kcl9tb2RlID0gbW9k ZTsKPiArCXN3aXRjaCAobW9kZSkgewo+ICsJY2FzZSBVU0JfRFJfTU9ERV9QRVJJUEhFUkFMOgo+ ICsJCWRldl9pbmZvKGNkbnMtPmRldiwgIlNldCBjb250cm9sbGVyIHRvIEdhZGdldCBtb2RlXG4i KTsKPiArCQl3cml0ZWwoT1RHQ01EX0RFVl9CVVNfUkVRIHwgT1RHQ01EX09UR19ESVMsCj4gKwkJ ICAgICAgICZjZG5zLT5vdGdfcmVncy0+Y21kKTsKPiArCQlicmVhazsKPiArCWNhc2UgVVNCX0RS X01PREVfSE9TVDoKPiArCQlkZXZfaW5mbyhjZG5zLT5kZXYsICJTZXQgY29udHJvbGxlciB0byBI b3N0IG1vZGVcbiIpOwo+ICsJCXdyaXRlbChPVEdDTURfSE9TVF9CVVNfUkVRIHwgT1RHQ01EX09U R19ESVMsCj4gKwkJICAgICAgICZjZG5zLT5vdGdfcmVncy0+Y21kKTsKPiArCQlicmVhazsKPiAr CWNhc2UgVVNCX0RSX01PREVfT1RHOgo+ICsJCWRldl9pbmZvKGNkbnMtPmRldiwgIlNldCBjb250 cm9sbGVyIHRvIE9URyBtb2RlXG4iKTsKPiArCQlyZWcgPSByZWFkbCgmY2Rucy0+b3RnX3JlZ3Mt PmN0cmwxKTsKPiArCQlyZWcgfD0gT1RHQ1RSTDFfSURQVUxMVVA7Cj4gKwkJd3JpdGVsKHJlZywg JmNkbnMtPm90Z19yZWdzLT5jdHJsMSk7Cj4gKwo+ICsJCS8qIHdhaXQgdW50aWwgdmFsaWQgSUQg KElEX1ZBTFVFKSBjYW4gYmUgc2FtcGxlZCAoNTBtcykuICovCj4gKwkJbWRlbGF5KDUwKTsKPiAr CQlicmVhazsKPiArCWRlZmF1bHQ6Cj4gKwkJY2Rucy0+Y3VycmVudF9kcl9tb2RlID0gVVNCX0RS X01PREVfVU5LTk9XTjsKPiArCQlkZXZfZXJyKGNkbnMtPmRldiwgIlVuc3VwcG9ydGVkIG1vZGUg b2Ygb3BlcmF0aW9uICVkXG4iLCBtb2RlKTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gK30KPiArCj4g K3N0YXRpYyBpbnQgY2RuczNfb3RnX2dldF9pZChzdHJ1Y3QgY2RuczMgKmNkbnMpCj4gK3sKPiAr CWludCBpZDsKPiArCj4gKwlpZCA9IHJlYWRsKCZjZG5zLT5vdGdfcmVncy0+c3RzKSAmIE9UR1NU U19JRF9WQUxVRTsKPiArCWRldl9kYmcoY2Rucy0+ZGV2LCAiT1RHIElEOiAlZCIsIGlkKTsKPiAr CXJldHVybiBpZDsKPiArfQo+ICsKPiAraW50IGNkbnMzX2lzX2hvc3Qoc3RydWN0IGNkbnMzICpj ZG5zKQo+ICt7Cj4gKwlpZiAoY2Rucy0+Y3VycmVudF9kcl9tb2RlID09IFVTQl9EUl9NT0RFX0hP U1QpCj4gKwkJcmV0dXJuIDE7CgpXaHkgZG8geW91IG5lZWQgdGhpcz8KCj4gKwllbHNlIGlmIChj ZG5zLT5jdXJyZW50X2RyX21vZGUgPT0gVVNCX0RSX01PREVfT1RHKQo+ICsJCWlmICghY2RuczNf b3RnX2dldF9pZChjZG5zKSkKPiArCQkJcmV0dXJuIDE7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30K PiArCj4gK2ludCBjZG5zM19pc19kZXZpY2Uoc3RydWN0IGNkbnMzICpjZG5zKQo+ICt7Cj4gKwlp ZiAoY2Rucy0+Y3VycmVudF9kcl9tb2RlID09IFVTQl9EUl9NT0RFX1BFUklQSEVSQUwpCj4gKwkJ cmV0dXJuIDE7Cj4gKwllbHNlIGlmIChjZG5zLT5jdXJyZW50X2RyX21vZGUgPT0gVVNCX0RSX01P REVfT1RHKQo+ICsJCWlmIChjZG5zM19vdGdfZ2V0X2lkKGNkbnMpKQo+ICsJCQlyZXR1cm4gMTsK PiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArLyoqCj4gKyAqIGNkbnMzX290Z19kaXNhYmxl X2lycSAtIERpc2FibGUgYWxsIE9URyBpbnRlcnJ1cHRzCj4gKyAqIEBjZG5zOiBQb2ludGVyIHRv IGNvbnRyb2xsZXIgY29udGV4dCBzdHJ1Y3R1cmUKPiArICovCj4gK3N0YXRpYyB2b2lkIGNkbnMz X290Z19kaXNhYmxlX2lycShzdHJ1Y3QgY2RuczMgKmNkbnMpCj4gK3sKPiArCXdyaXRlbCgwLCAm Y2Rucy0+b3RnX3JlZ3MtPmllbik7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBjZG5zM19vdGdfZW5h YmxlX2lycSAtIGVuYWJsZSBpZCBhbmQgc2Vzc192YWxpZCBpbnRlcnJ1cHRzCj4gKyAqIEBjZG5z OiBQb2ludGVyIHRvIGNvbnRyb2xsZXIgY29udGV4dCBzdHJ1Y3R1cmUKPiArICovCj4gK3N0YXRp YyB2b2lkIGNkbnMzX290Z19lbmFibGVfaXJxKHN0cnVjdCBjZG5zMyAqY2RucykKPiArewo+ICsJ d3JpdGVsKE9UR0lFTl9JRF9DSEFOR0VfSU5UIHwgT1RHSUVOX1ZCVVNWQUxJRF9SSVNFX0lOVCB8 Cj4gKwkgICAgICAgT1RHSUVOX1ZCVVNWQUxJRF9GQUxMX0lOVCwgJmNkbnMtPm90Z19yZWdzLT5p ZW4pOwo+ICt9Cj4gKwo+ICsvKioKPiArICogY2RuczNfaW5pdF9vdGdfbW9kZSAtIGluaXRpYWxp emUgZHJkIGNvbnRyb2xsZXIKPiArICogQGNkbnM6IFBvaW50ZXIgdG8gY29udHJvbGxlciBjb250 ZXh0IHN0cnVjdHVyZQo+ICsgKgo+ICsgKiBSZXR1cm5zIDAgb24gc3VjY2VzcyBvdGhlcndpc2Ug bmVnYXRpdmUgZXJybm8KPiArICovCj4gK3N0YXRpYyB2b2lkIGNkbnMzX2luaXRfb3RnX21vZGUo c3RydWN0IGNkbnMzICpjZG5zKQo+ICt7Cj4gKwljZG5zM19vdGdfZGlzYWJsZV9pcnEoY2Rucyk7 Cj4gKwkvKiBjbGVhciBhbGwgaW50ZXJydXB0cyAqLwo+ICsJd3JpdGVsKH4wLCAmY2Rucy0+b3Rn X3JlZ3MtPml2ZWN0KTsKPiArCj4gKwljZG5zM19zZXRfbW9kZShjZG5zLCBVU0JfRFJfTU9ERV9P VEcpOwo+ICsKPiArCWNkbnMzX290Z19lbmFibGVfaXJxKGNkbnMpOwo+ICt9Cj4gKwo+ICsvKioK PiArICogY2RuczNfZHJkX3VwZGF0ZV9tb2RlIC0gaW5pdGlhbGl6ZSBtb2RlIG9mIG9wZXJhdGlv bgoKTG9va3MgbGlrZSB0aGlzIHdpbGwgYmUgY2FsbGVkIG9ubHkgb25jZS4gSG93IGFib3V0IGNh bGxpbmcgaXQKCmNkbnMzX2RyZF9pbml0X21vZGUoKT8KCj4gKyAqIEBjZG5zOiBQb2ludGVyIHRv IGNvbnRyb2xsZXIgY29udGV4dCBzdHJ1Y3R1cmUKPiArICoKPiArICogUmV0dXJucyAwIG9uIHN1 Y2Nlc3Mgb3RoZXJ3aXNlIG5lZ2F0aXZlIGVycm5vCj4gKyAqLwo+ICtpbnQgY2RuczNfZHJkX3Vw ZGF0ZV9tb2RlKHN0cnVjdCBjZG5zMyAqY2RucykKPiArewo+ICsJaW50IHJldCA9IDA7Cj4gKwo+ ICsJc3dpdGNoIChjZG5zLT5kZXNpcmVkX2RyX21vZGUpIHsKCkkgdGhpbmsgd2UgY2FuIGdldCBy aWQgb2YgZGVzaXJlZF9kcl9tb2RlIG1lbWJlciBpbiBzdHJ1Y3QgY2Rucy4KSnVzdCBwYXNzIHRo ZSBtb2RlIGFzIGFuIGFyZ3VtZW50IHRvIGNkbnMzX2RyZF9pbml0X21vZGUoKQoKQW5kIHdlIGFs cmVhZHkgaGF2ZSBjZG5zLT5kcl9tb2RlLgoKPiArCWNhc2UgVVNCX0RSX01PREVfUEVSSVBIRVJB TDoKPiArCQljZG5zM19zZXRfbW9kZShjZG5zLCBVU0JfRFJfTU9ERV9QRVJJUEhFUkFMKTsKPiAr CQlicmVhazsKPiArCWNhc2UgVVNCX0RSX01PREVfSE9TVDoKPiArCQljZG5zM19zZXRfbW9kZShj ZG5zLCBVU0JfRFJfTU9ERV9IT1NUKTsKPiArCQlicmVhazsKPiArCWNhc2UgVVNCX0RSX01PREVf T1RHOgo+ICsJCWNkbnMzX2luaXRfb3RnX21vZGUoY2Rucyk7Cj4gKwkJYnJlYWs7Cj4gKwlkZWZh dWx0Ogo+ICsJCWRldl9lcnIoY2Rucy0+ZGV2LCAiVW5zdXBwb3J0ZWQgbW9kZSBvZiBvcGVyYXRp b24gJWRcbiIsCj4gKwkJCWNkbnMtPmRyX21vZGUpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJ fQo+ICsKPiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gK2lycXJldHVybl90IGNkbnMzX2RyZF9p cnEoc3RydWN0IGNkbnMzICpjZG5zKQo+ICt7Cj4gKwlpcnFyZXR1cm5fdCByZXQgPSBJUlFfTk9O RTsKPiArCXUzMiByZWc7Cj4gKwo+ICsJaWYgKGNkbnMtPmRyX21vZGUgIT0gVVNCX0RSX01PREVf T1RHKQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJcmVnID0gcmVhZGwoJmNkbnMtPm90Z19yZWdz LT5pdmVjdCk7Cj4gKwlpZiAoIXJlZykKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCWlmIChyZWcg JiBPVEdJRU5fSURfQ0hBTkdFX0lOVCkgewo+ICsJCWludCBpZCA9IGNkbnMzX290Z19nZXRfaWQo Y2Rucyk7Cj4gKwo+ICsJCWRldl9kYmcoY2Rucy0+ZGV2LCAiT1RHIElSUTogbmV3IElEOiAlZFxu IiwKPiArCQkJY2RuczNfb3RnX2dldF9pZChjZG5zKSk7Cj4gKwo+ICsJCWlmIChpZCkKPiArCQkJ Y2Rucy0+cm9sZSA9IENETlMzX1JPTEVfR0FER0VUOwo+ICsJCWVsc2UKPiArCQkJY2Rucy0+cm9s ZSA9IENETlMzX1JPTEVfSE9TVDsKCldoeSBjaGVjayBJRCBhbmQgc2V0IHJvbGUgaGVyZT8gSXQg bWlnaHQgY2hhbmdlIGJ5IHRoZSB0aW1lCnRoZSByb2xlX3N3aXRjaF93cSBzdGFydHMgdXAuIFdo eSBub3QgY2hlY2sgdGhlIElEIHN0YXR1cyB0aGVyZT8KCkFsc28gZGlyZWN0bHkgY2hhbmdpbmcg cm9sZSBoZXJlIGRvZXNuJ3QgbWFrZSBzZW5zZSBhcwp0aGVyZSB3aWxsIGJlIGEgbWlzbWF0Y2gg YmV0d2VlbiBjdXJyZW50bHkgYWN0aXZlIHJvbGUgYW5kIGNkbnMtPnJvbGUuCgo+ICsKPiArCQlx dWV1ZV93b3JrKHN5c3RlbV9mcmVlemFibGVfd3EsICZjZG5zLT5yb2xlX3N3aXRjaF93cSk7Cj4g Kwo+ICsJCXJldCA9IElSUV9IQU5ETEVEOwo+ICsJfQo+ICsKPiArCXdyaXRlbCh+MCwgJmNkbnMt Pm90Z19yZWdzLT5pdmVjdCk7Cj4gKwlyZXR1cm4gSVJRX0hBTkRMRUQ7CgpyZXR1cm4gcmV0OwoK PiArfQo+ICsKPiAraW50IGNkbnMzX2RyZF9pbml0KHN0cnVjdCBjZG5zMyAqY2RucykKPiArewo+ ICsJZW51bSB1c2JfZHJfbW9kZSBkcl9tb2RlOwo+ICsJaW50IHJldCA9IDA7Cj4gKwl1MzIgc3Rh dGU7Cj4gKwo+ICsJc3RhdGUgPSBPVEdTVFNfU1RSQVAocmVhZGwoJmNkbnMtPm90Z19yZWdzLT5z dHMpKTsKPiArCj4gKwlkcl9tb2RlID0gY2Rucy0+ZHJfbW9kZTsKPiArCWlmIChzdGF0ZSA9PSBP VEdTVFNfU1RSQVBfSE9TVCkgewo+ICsJCWRldl9pbmZvKGNkbnMtPmRldiwgIkNvbnRyb2xsZXIg c3RyYXBwZWQgdG8gSE9TVFxuIik7Cj4gKwkJZHJfbW9kZSA9IFVTQl9EUl9NT0RFX0hPU1Q7Cj4g KwkJaWYgKGNkbnMtPmRyX21vZGUgIT0gVVNCX0RSX01PREVfSE9TVCAmJgo+ICsJCSAgICBjZG5z LT5kcl9tb2RlICE9IFVTQl9EUl9NT0RFX09URykKPiArCQkJcmV0ID0gLUVJTlZBTDsKPiArCX0g ZWxzZSBpZiAoc3RhdGUgPT0gT1RHU1RTX1NUUkFQX0dBREdFVCkgewo+ICsJCWRldl9pbmZvKGNk bnMtPmRldiwgIkNvbnRyb2xsZXIgc3RyYXBwZWQgdG8gUEVSSVBIRVJBTFxuIik7Cj4gKwkJZHJf bW9kZSA9IFVTQl9EUl9NT0RFX1BFUklQSEVSQUw7Cj4gKwkJaWYgKGNkbnMtPmRyX21vZGUgIT0g VVNCX0RSX01PREVfUEVSSVBIRVJBTCAmJgo+ICsJCSAgICBjZG5zLT5kcl9tb2RlICE9IFVTQl9E Ul9NT0RFX09URykKPiArCQkJcmV0ID0gLUVJTlZBTDsKPiArCX0KPiArCj4gKwlpZiAocmV0KSB7 Cj4gKwkJZGV2X2VycihjZG5zLT5kZXYsICJJbmNvcnJlY3QgRFJEIGNvbmZpZ3VyYXRpb25cbiIp Owo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJLy9VcGRhdGluZyBEUiBtb2RlIGFjY29y ZGluZyB0byBzdHJhcC4KPiArCWNkbnMtPmRyX21vZGUgPSBkcl9tb2RlOwo+ICsJY2Rucy0+ZGVz aXJlZF9kcl9tb2RlID0gZHJfbW9kZTsKPiArCWNkbnMtPmN1cnJlbnRfZHJfbW9kZSA9IFVTQl9E Ul9NT0RFX1VOS05PV047Cj4gKwo+ICsJZGV2X2luZm8oY2Rucy0+ZGV2LCAiQ29udHJvbGxlciBE ZXZpY2UgSUQ6ICUwOGx4LCBSZXZpc2lvbiBJRDogJTA4bHhcbiIsCj4gKwkJIENETlNfUklEKHJl YWRsKCZjZG5zLT5vdGdfcmVncy0+cmlkKSksCj4gKwkJIENETlNfRElEKHJlYWRsKCZjZG5zLT5v dGdfcmVncy0+ZGlkKSkpOwoKZGV2X2luZm8gc2hvdWxkIGJlIG1vdmVkIGF0IHRoZSBlbmQgaWYg Y2RuczNfZHJkX3VwZGF0ZV9tb2RlKCkgaWYgaXQgc3VjY2VlZGVkLgoKPiArCj4gKwlzdGF0ZSA9 IHJlYWRsKCZjZG5zLT5vdGdfcmVncy0+c3RzKTsKPiArCWlmIChPVEdTVFNfT1RHX05SRFkoc3Rh dGUpICE9IDApIHsKPiArCQlkZXZfZXJyKGNkbnMtPmRldiwgIkNhZGVuY2UgVVNCMyBPVEcgZGV2 aWNlIG5vdCByZWFkeVxuIik7Cj4gKwkJcmV0dXJuIC1FTk9ERVY7Cj4gKwl9Cj4gKwo+ICsJcmV0 ID0gY2RuczNfZHJkX3VwZGF0ZV9tb2RlKGNkbnMpOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gK30K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY2RuczMvZHJkLmggYi9kcml2ZXJzL3VzYi9jZG5z My9kcmQuaAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi4wZmFh NzUyMGVjYWMKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy91c2IvY2RuczMvZHJkLmgK PiBAQCAtMCwwICsxLDEyMiBAQAo+ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIu MCAqLwo+ICsvKgo+ICsgKiBDYWRlbmNlIFVTQjMgRFJEIHBhcnQgb2YgVVNCU1MgZHJpdmVyCj4g KyAqCj4gKyAqIENvcHlyaWdodCAoQykgMjAxOCBDYWRlbmNlLgo+ICsgKgo+ICsgKiBBdXRob3I6 IFBhd2VsIExhc3pjemFrIDxwYXdlbGxAY2FkZW5jZS5jb20+Cj4gKyAqLwo+ICsjaWZuZGVmIF9f TElOVVhfQ0ROUzNfRFJECj4gKyNkZWZpbmUgX19MSU5VWF9DRE5TM19EUkQKPiArCj4gKyNpbmNs dWRlIDxsaW51eC91c2Ivb3RnLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9waHkvcGh5Lmg+Cj4gKyNp bmNsdWRlICJjb3JlLmgiCj4gKwo+ICsvKiAgRFJEIHJlZ2lzdGVyIGludGVyZmFjZS4gKi8KPiAr c3RydWN0IGNkbnMzX290Z19yZWdzIHsKPiArCV9fbGUzMiBkaWQ7Cj4gKwlfX2xlMzIgcmlkOwo+ ICsJX19sZTMyIGNhcGFiaWxpdGllczsKPiArCV9fbGUzMiByZXNlcnZlZDE7Cj4gKwlfX2xlMzIg Y21kOwo+ICsJX19sZTMyIHN0czsKPiArCV9fbGUzMiBzdGF0ZTsKPiArCV9fbGUzMiByZXNlcnZl ZDI7Cj4gKwlfX2xlMzIgaWVuOwo+ICsJX19sZTMyIGl2ZWN0Owo+ICsJX19sZTMyIHJlZmNsazsK PiArCV9fbGUzMiB0bXI7Cj4gKwlfX2xlMzIgcmVzZXJ2ZWQzWzRdOwo+ICsJX19sZTMyIHNpbXVs YXRlOwo+ICsJX19sZTMyIG92ZXJyaWRlOwo+ICsJX19sZTMyIHN1c3BfY3RybDsKPiArCV9fbGUz MiByZXNlcnZlZDQ7Cj4gKwlfX2xlMzIgYW5hc3RzOwo+ICsJX19sZTMyIGFkcF9yYW1wX3RpbWU7 Cj4gKwlfX2xlMzIgY3RybDE7Cj4gKwlfX2xlMzIgY3RybDI7Cj4gK307Cj4gKwo+ICsvKiBDRE5T X1JJRCAtIGJpdG1hc2tzICovCj4gKyNkZWZpbmUgQ0ROU19SSUQocCkJCQkoKHApICYgR0VOTUFT SygxNSwgMCkpCj4gKwo+ICsvKiBDRE5TX1ZJRCAtIGJpdG1hc2tzICovCj4gKyNkZWZpbmUgQ0RO U19ESUQocCkJCQkoKHApICYgR0VOTUFTSygzMSwgMCkpCj4gKwo+ICsvKiBPVEdDTUQgLSBiaXRt YXNrcyAqLwo+ICsvKiAiUmVxdWVzdCB0aGUgYnVzIGZvciBEZXZpY2UgbW9kZS4gKi8KPiArI2Rl ZmluZSBPVEdDTURfREVWX0JVU19SRVEJQklUKDApCj4gKy8qIFJlcXVlc3QgdGhlIGJ1cyBmb3Ig SG9zdCBtb2RlICovCj4gKyNkZWZpbmUgT1RHQ01EX0hPU1RfQlVTX1JFUQkJQklUKDEpCj4gKy8q IEVuYWJsZSBPVEcgbW9kZS4gKi8KPiArI2RlZmluZSBPVEdDTURfT1RHX0VOCQkJQklUKDIpCj4g Ky8qIERpc2FibGUgT1RHIG1vZGUgKi8KPiArI2RlZmluZSBPVEdDTURfT1RHX0RJUwkJCUJJVCgz KQo+ICsvKiJDb25maWd1cmUgT1RHIGFzIEEtRGV2aWNlLiAqLwo+ICsjZGVmaW5lIE9UR0NNRF9B X0RFVl9FTgkJCUJJVCg0KQo+ICsvKiJDb25maWd1cmUgT1RHIGFzIEEtRGV2aWNlLiAqLwo+ICsj ZGVmaW5lIE9UR0NNRF9BX0RFVl9ESVMJCUJJVCg1KQo+ICsvKiBEcm9wIHRoZSBidXMgZm9yIERl dmljZSBtb2QJZS4gKi8KPiArI2RlZmluZSBPVEdDTURfREVWX0JVU19EUk9QCQlCSVQoOCkKPiAr LyogRHJvcCB0aGUgYnVzIGZvciBIb3N0IG1vZGUqLwo+ICsjZGVmaW5lIE9UR0NNRF9IT1NUX0JV U19EUk9QCQlCSVQoOSkKPiArLyogUG93ZXIgRG93biBVU0JTUy1ERVYuICovCj4gKyNkZWZpbmUg T1RHQ01EX0RFVl9QT1dFUl9PRkYJCUJJVCgxMSkKPiArLyogUG93ZXIgRG93biBDRE5TWEhDSS4g Ki8KPiArI2RlZmluZSBPVEdDTURfSE9TVF9QT1dFUl9PRkYJCUJJVCgxMikKPiArCj4gKy8qIE9U R0lFTiAtIGJpdG1hc2tzICovCj4gKy8qIElEIGNoYW5nZSBpbnRlcnJ1cHQgZW5hYmxlICovCj4g KyNkZWZpbmUgT1RHSUVOX0lEX0NIQU5HRV9JTlQJCUJJVCgwKQo+ICsvKiBWYnVzdmFsaWQgZmFs bCBkZXRlY3RlZCBpbnRlcnJ1cHQgZW5hYmxlLiovCj4gKyNkZWZpbmUgT1RHSUVOX1ZCVVNWQUxJ RF9SSVNFX0lOVAlCSVQoNCkKPiArLyogVmJ1c3ZhbGlkIGZhbGwgZGV0ZWN0ZWQgaW50ZXJydXB0 IGVuYWJsZSAqLwo+ICsjZGVmaW5lIE9UR0lFTl9WQlVTVkFMSURfRkFMTF9JTlQJQklUKDUpCj4g Kwo+ICsvKiBPVEdTVFMgLSBiaXRtYXNrcyAqLwo+ICsvKgo+ICsgKiBDdXJyZW50IHZhbHVlIG9m IHRoZSBJRCBwaW4uIEl0IGlzIG9ubHkgdmFsaWQgd2hlbiBpZHB1bGx1cCBpbgo+ICsgKiAgT1RH Q1RSTDFfVFlQRSByZWdpc3RlciBpcyBzZXQgdG8gJzEnLgo+ICsgKi8KPiArI2RlZmluZSBPVEdT VFNfSURfVkFMVUUJCQlCSVQoMCkKPiArLyogQ3VycmVudCB2YWx1ZSBvZiB0aGUgdmJ1c192YWxp ZCAqLwo+ICsjZGVmaW5lIE9UR1NUU19WQlVTX1ZBTElECQlCSVQoMSkKPiArLyogQ3VycmVudCB2 YWx1ZSBvZiB0aGUgYl9zZXNzX3ZsZCAqLwo+ICsjZGVmaW5lIE9UR1NUU19TRVNTSU9OX1ZBTElE CQlCSVQoMikKPiArLypEZXZpY2UgbW9kZSBpcyBhY3RpdmUqLwo+ICsjZGVmaW5lIE9UR1NUU19E RVZfQUNUSVZFCQlCSVQoMykKPiArLyogSG9zdCBtb2RlIGlzIGFjdGl2ZS4gKi8KPiArI2RlZmlu ZSBPVEdTVFNfSE9TVF9BQ1RJVkUJCUJJVCg0KQo+ICsvKiBPVEcgQ29udHJvbGxlciBub3QgcmVh ZHkuICovCj4gKyNkZWZpbmUgT1RHU1RTX09UR19OUkRZX01BU0sJCUJJVCgxMSkKPiArI2RlZmlu ZSBPVEdTVFNfT1RHX05SRFkocCkJCSgocCkgJiBPVEdTVFNfT1RHX05SRFlfTUFTSykKPiArLyoK PiArICogVmFsdWUgb2YgdGhlIHN0cmFwIHBpbnMuCj4gKyAqIDAwMCAtIG5vIGRlZmF1bHQgY29u ZmlndXJhdGlvbgo+ICsgKiAwMTAgLSBDb250cm9sbGVyIGluaXRpYWxsIGNvbmZpZ3VyZWQgYXMg SG9zdAo+ICsgKiAxMDAgLSBDb250cm9sbGVyIGluaXRpYWxseSBjb25maWd1cmVkIGFzIERldmlj ZQo+ICsgKi8KPiArI2RlZmluZSBPVEdTVFNfU1RSQVAocCkJCQkoKChwKSAmIEdFTk1BU0soMTQs IDEyKSkgPj4gMTIpCj4gKyNkZWZpbmUgT1RHU1RTX1NUUkFQX05PX0RFRkFVTFRfQ0ZHCTB4MDAK PiArI2RlZmluZSBPVEdTVFNfU1RSQVBfSE9TVF9PVEcJCTB4MDEKPiArI2RlZmluZSBPVEdTVFNf U1RSQVBfSE9TVAkJMHgwMgo+ICsjZGVmaW5lIE9UR1NUU19TVFJBUF9HQURHRVQJCTB4MDQKPiAr LyogSG9zdCBtb2RlIGlzIHR1cm5lZCBvbi4gKi8KPiArI2RlZmluZSBPVEdTVFNFX1hIQ0lfUkVB RFlGCQlCSVQoMjYpCj4gKy8qICJEZXZpY2UgbW9kZSBpcyB0dXJuZWQgb24gLiovCj4gKyNkZWZp bmUgT1RHU1RTX0RFVl9SRUFEWQkJQklUKDI3KQo+ICsKPiArLyogT1RHUkVGQ0xLIC0gYml0bWFz a3MgKi8KPiArI2RlZmluZSBPVEdSRUZDTEtfU1RCX0NMS19TV0lUQ0hfRU4JQklUKDMxKQo+ICsK PiArLyogT1RHQ1RSTDEgLSBiaXRtYXNrcyAqLwo+ICsjZGVmaW5lIE9UR0NUUkwxX0lEUFVMTFVQ CQlCSVQoMjQpCj4gKwo+ICtpbnQgY2RuczNfaXNfaG9zdChzdHJ1Y3QgY2RuczMgKmNkbnMpOwo+ ICtpbnQgY2RuczNfaXNfZGV2aWNlKHN0cnVjdCBjZG5zMyAqY2Rucyk7Cj4gK2ludCBjZG5zM19k cmRfaW5pdChzdHJ1Y3QgY2RuczMgKmNkbnMpOwo+ICtpbnQgY2RuczNfZHJkX3VwZGF0ZV9tb2Rl KHN0cnVjdCBjZG5zMyAqY2Rucyk7Cj4gK2lycXJldHVybl90IGNkbnMzX2RyZF9pcnEoc3RydWN0 IGNkbnMzICpjZG5zKTsKPiArCj4gKyNlbmRpZiAvKiBfX0xJTlVYX0NETlMzX0RSRCAqLwo+IAoK Y2hlZXJzLAotcm9nZXIK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support Date: Fri, 23 Nov 2018 16:51:56 +0200 Message-ID: <5BF8140C.7000605@ti.com> References: <1542535751-16079-1-git-send-email-pawell@cadence.com> <1542535751-16079-6-git-send-email-pawell@cadence.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1542535751-16079-6-git-send-email-pawell@cadence.com> Sender: linux-kernel-owner@vger.kernel.org To: Pawel Laszczak , devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-Id: devicetree@vger.kernel.org On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds supports for detecting Host/Device mode. > Controller has additional OTG register that allow > implement even whole OTG functionality. > At this moment patch adds support only for detecting > the appropriate mode based on strap pins and ID pin. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Makefile | 2 +- > drivers/usb/cdns3/core.c | 27 +++-- > drivers/usb/cdns3/drd.c | 229 +++++++++++++++++++++++++++++++++++++ > drivers/usb/cdns3/drd.h | 122 ++++++++++++++++++++ > 4 files changed, 372 insertions(+), 8 deletions(-) > create mode 100644 drivers/usb/cdns3/drd.c > create mode 100644 drivers/usb/cdns3/drd.h > > diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile > index 02d25b23c5d3..e779b2a2f8eb 100644 > --- a/drivers/usb/cdns3/Makefile > +++ b/drivers/usb/cdns3/Makefile > @@ -1,5 +1,5 @@ > obj-$(CONFIG_USB_CDNS3) += cdns3.o > obj-$(CONFIG_USB_CDNS3_PCI_WRAP) += cdns3-pci.o > > -cdns3-y := core.o > +cdns3-y := core.o drd.o > cdns3-pci-y := cdns3-pci-wrap.o > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c > index f9055d4da67f..dbee4325da7f 100644 > --- a/drivers/usb/cdns3/core.c > +++ b/drivers/usb/cdns3/core.c > @@ -17,6 +17,7 @@ > > #include "gadget.h" > #include "core.h" > +#include "drd.h" > > static inline struct cdns3_role_driver *cdns3_get_current_role_driver(struct cdns3 *cdns) > { > @@ -57,8 +58,10 @@ static inline void cdns3_role_stop(struct cdns3 *cdns) > static enum cdns3_roles cdns3_get_role(struct cdns3 *cdns) > { > if (cdns->roles[CDNS3_ROLE_HOST] && cdns->roles[CDNS3_ROLE_GADGET]) { > - //TODO: implements selecting device/host mode > - return CDNS3_ROLE_HOST; > + if (cdns3_is_host(cdns)) > + return CDNS3_ROLE_HOST; > + if (cdns3_is_device(cdns)) > + return CDNS3_ROLE_GADGET; > } > return cdns->roles[CDNS3_ROLE_HOST] > ? CDNS3_ROLE_HOST > @@ -124,6 +127,12 @@ static irqreturn_t cdns3_irq(int irq, void *data) > struct cdns3 *cdns = data; > irqreturn_t ret = IRQ_NONE; > > + if (cdns->dr_mode == USB_DR_MODE_OTG) { > + ret = cdns3_drd_irq(cdns); > + if (ret == IRQ_HANDLED) > + return ret; > + } The kernel's shared IRQ model takes care of sharing the same interrupt between different devices and their drivers. You don't need to manually handle it here. Just let all 3 drivers do a request_irq() and have handlers check if the IRQ was theirs or not and return IRQ_HANDLED or IRQ_NONE accordingly. Looks like you can do away with irq member of the role driver struct. > + > /* Handle device/host interrupt */ > if (cdns->role != CDNS3_ROLE_END) > ret = cdns3_get_current_role_driver(cdns)->irq(cdns); > @@ -176,11 +185,8 @@ static void cdns3_role_switch(struct work_struct *work) > > cdns = container_of(work, struct cdns3, role_switch_wq); > > - //TODO: implements this functions. > - //host = cdns3_is_host(cdns); > - //device = cdns3_is_device(cdns); > - host = 1; > - device = 0; > + host = cdns3_is_host(cdns); > + device = cdns3_is_device(cdns); What if there is a ID transition between the 2 functions so that and both host and device become true? Since you are checking the ID level separately in both the functions. How about instead having cdns3_get_id() and using it to start/stop relevant roles if we are in OTG mode. Is this going to be used for a role switch even if we're not in OTG mode? If not then it is a BUG if we get here. > > if (host) > role = CDNS3_ROLE_HOST; > @@ -194,6 +200,12 @@ static void cdns3_role_switch(struct work_struct *work) > pm_runtime_get_sync(cdns->dev); > cdns3_role_stop(cdns); > > + if (cdns->desired_dr_mode != cdns->current_dr_mode) { This is about roles, why are we checking dr_mode here? > + cdns3_drd_update_mode(cdns); > + host = cdns3_is_host(cdns); > + device = cdns3_is_device(cdns); > + } > + > if (host) { > if (cdns->roles[CDNS3_ROLE_HOST]) > cdns3_do_role_switch(cdns, CDNS3_ROLE_HOST); > @@ -287,6 +299,7 @@ static int cdns3_probe(struct platform_device *pdev) > if (ret) > goto err2; > > + ret = cdns3_drd_init(cdns); > if (ret) > goto err2; > > diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c > new file mode 100644 > index 000000000000..ac741c80e776 > --- /dev/null > +++ b/drivers/usb/cdns3/drd.c > @@ -0,0 +1,229 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Cadence USBSS DRD Driver. > + * > + * Copyright (C) 2018 Cadence. > + * > + * Author: Pawel Laszczak + * > + */ > +#include > +#include > +#include > +#include > + > +#include "gadget.h" > +#include "drd.h" > + > +/** > + * cdns3_set_mode - change mode of OTG Core > + * @cdns: pointer to context structure > + * @mode: selected mode from cdns_role > + */ > +void cdns3_set_mode(struct cdns3 *cdns, enum usb_dr_mode mode) > +{ > + u32 reg; > + > + cdns->current_dr_mode = mode; > + switch (mode) { > + case USB_DR_MODE_PERIPHERAL: > + dev_info(cdns->dev, "Set controller to Gadget mode\n"); > + writel(OTGCMD_DEV_BUS_REQ | OTGCMD_OTG_DIS, > + &cdns->otg_regs->cmd); > + break; > + case USB_DR_MODE_HOST: > + dev_info(cdns->dev, "Set controller to Host mode\n"); > + writel(OTGCMD_HOST_BUS_REQ | OTGCMD_OTG_DIS, > + &cdns->otg_regs->cmd); > + break; > + case USB_DR_MODE_OTG: > + dev_info(cdns->dev, "Set controller to OTG mode\n"); > + reg = readl(&cdns->otg_regs->ctrl1); > + reg |= OTGCTRL1_IDPULLUP; > + writel(reg, &cdns->otg_regs->ctrl1); > + > + /* wait until valid ID (ID_VALUE) can be sampled (50ms). */ > + mdelay(50); > + break; > + default: > + cdns->current_dr_mode = USB_DR_MODE_UNKNOWN; > + dev_err(cdns->dev, "Unsupported mode of operation %d\n", mode); > + return; > + } > +} > + > +static int cdns3_otg_get_id(struct cdns3 *cdns) > +{ > + int id; > + > + id = readl(&cdns->otg_regs->sts) & OTGSTS_ID_VALUE; > + dev_dbg(cdns->dev, "OTG ID: %d", id); > + return id; > +} > + > +int cdns3_is_host(struct cdns3 *cdns) > +{ > + if (cdns->current_dr_mode == USB_DR_MODE_HOST) > + return 1; Why do you need this? > + else if (cdns->current_dr_mode == USB_DR_MODE_OTG) > + if (!cdns3_otg_get_id(cdns)) > + return 1; > + > + return 0; > +} > + > +int cdns3_is_device(struct cdns3 *cdns) > +{ > + if (cdns->current_dr_mode == USB_DR_MODE_PERIPHERAL) > + return 1; > + else if (cdns->current_dr_mode == USB_DR_MODE_OTG) > + if (cdns3_otg_get_id(cdns)) > + return 1; > + > + return 0; > +} > + > +/** > + * cdns3_otg_disable_irq - Disable all OTG interrupts > + * @cdns: Pointer to controller context structure > + */ > +static void cdns3_otg_disable_irq(struct cdns3 *cdns) > +{ > + writel(0, &cdns->otg_regs->ien); > +} > + > +/** > + * cdns3_otg_enable_irq - enable id and sess_valid interrupts > + * @cdns: Pointer to controller context structure > + */ > +static void cdns3_otg_enable_irq(struct cdns3 *cdns) > +{ > + writel(OTGIEN_ID_CHANGE_INT | OTGIEN_VBUSVALID_RISE_INT | > + OTGIEN_VBUSVALID_FALL_INT, &cdns->otg_regs->ien); > +} > + > +/** > + * cdns3_init_otg_mode - initialize drd controller > + * @cdns: Pointer to controller context structure > + * > + * Returns 0 on success otherwise negative errno > + */ > +static void cdns3_init_otg_mode(struct cdns3 *cdns) > +{ > + cdns3_otg_disable_irq(cdns); > + /* clear all interrupts */ > + writel(~0, &cdns->otg_regs->ivect); > + > + cdns3_set_mode(cdns, USB_DR_MODE_OTG); > + > + cdns3_otg_enable_irq(cdns); > +} > + > +/** > + * cdns3_drd_update_mode - initialize mode of operation Looks like this will be called only once. How about calling it cdns3_drd_init_mode()? > + * @cdns: Pointer to controller context structure > + * > + * Returns 0 on success otherwise negative errno > + */ > +int cdns3_drd_update_mode(struct cdns3 *cdns) > +{ > + int ret = 0; > + > + switch (cdns->desired_dr_mode) { I think we can get rid of desired_dr_mode member in struct cdns. Just pass the mode as an argument to cdns3_drd_init_mode() And we already have cdns->dr_mode. > + case USB_DR_MODE_PERIPHERAL: > + cdns3_set_mode(cdns, USB_DR_MODE_PERIPHERAL); > + break; > + case USB_DR_MODE_HOST: > + cdns3_set_mode(cdns, USB_DR_MODE_HOST); > + break; > + case USB_DR_MODE_OTG: > + cdns3_init_otg_mode(cdns); > + break; > + default: > + dev_err(cdns->dev, "Unsupported mode of operation %d\n", > + cdns->dr_mode); > + return -EINVAL; > + } > + > + return ret; > +} > + > +irqreturn_t cdns3_drd_irq(struct cdns3 *cdns) > +{ > + irqreturn_t ret = IRQ_NONE; > + u32 reg; > + > + if (cdns->dr_mode != USB_DR_MODE_OTG) > + return ret; > + > + reg = readl(&cdns->otg_regs->ivect); > + if (!reg) > + return ret; > + > + if (reg & OTGIEN_ID_CHANGE_INT) { > + int id = cdns3_otg_get_id(cdns); > + > + dev_dbg(cdns->dev, "OTG IRQ: new ID: %d\n", > + cdns3_otg_get_id(cdns)); > + > + if (id) > + cdns->role = CDNS3_ROLE_GADGET; > + else > + cdns->role = CDNS3_ROLE_HOST; Why check ID and set role here? It might change by the time the role_switch_wq starts up. Why not check the ID status there? Also directly changing role here doesn't make sense as there will be a mismatch between currently active role and cdns->role. > + > + queue_work(system_freezable_wq, &cdns->role_switch_wq); > + > + ret = IRQ_HANDLED; > + } > + > + writel(~0, &cdns->otg_regs->ivect); > + return IRQ_HANDLED; return ret; > +} > + > +int cdns3_drd_init(struct cdns3 *cdns) > +{ > + enum usb_dr_mode dr_mode; > + int ret = 0; > + u32 state; > + > + state = OTGSTS_STRAP(readl(&cdns->otg_regs->sts)); > + > + dr_mode = cdns->dr_mode; > + if (state == OTGSTS_STRAP_HOST) { > + dev_info(cdns->dev, "Controller strapped to HOST\n"); > + dr_mode = USB_DR_MODE_HOST; > + if (cdns->dr_mode != USB_DR_MODE_HOST && > + cdns->dr_mode != USB_DR_MODE_OTG) > + ret = -EINVAL; > + } else if (state == OTGSTS_STRAP_GADGET) { > + dev_info(cdns->dev, "Controller strapped to PERIPHERAL\n"); > + dr_mode = USB_DR_MODE_PERIPHERAL; > + if (cdns->dr_mode != USB_DR_MODE_PERIPHERAL && > + cdns->dr_mode != USB_DR_MODE_OTG) > + ret = -EINVAL; > + } > + > + if (ret) { > + dev_err(cdns->dev, "Incorrect DRD configuration\n"); > + return ret; > + } > + > + //Updating DR mode according to strap. > + cdns->dr_mode = dr_mode; > + cdns->desired_dr_mode = dr_mode; > + cdns->current_dr_mode = USB_DR_MODE_UNKNOWN; > + > + dev_info(cdns->dev, "Controller Device ID: %08lx, Revision ID: %08lx\n", > + CDNS_RID(readl(&cdns->otg_regs->rid)), > + CDNS_DID(readl(&cdns->otg_regs->did))); dev_info should be moved at the end if cdns3_drd_update_mode() if it succeeded. > + > + state = readl(&cdns->otg_regs->sts); > + if (OTGSTS_OTG_NRDY(state) != 0) { > + dev_err(cdns->dev, "Cadence USB3 OTG device not ready\n"); > + return -ENODEV; > + } > + > + ret = cdns3_drd_update_mode(cdns); > + > + return ret; > +} > diff --git a/drivers/usb/cdns3/drd.h b/drivers/usb/cdns3/drd.h > new file mode 100644 > index 000000000000..0faa7520ecac > --- /dev/null > +++ b/drivers/usb/cdns3/drd.h > @@ -0,0 +1,122 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Cadence USB3 DRD part of USBSS driver > + * > + * Copyright (C) 2018 Cadence. > + * > + * Author: Pawel Laszczak > + */ > +#ifndef __LINUX_CDNS3_DRD > +#define __LINUX_CDNS3_DRD > + > +#include > +#include > +#include "core.h" > + > +/* DRD register interface. */ > +struct cdns3_otg_regs { > + __le32 did; > + __le32 rid; > + __le32 capabilities; > + __le32 reserved1; > + __le32 cmd; > + __le32 sts; > + __le32 state; > + __le32 reserved2; > + __le32 ien; > + __le32 ivect; > + __le32 refclk; > + __le32 tmr; > + __le32 reserved3[4]; > + __le32 simulate; > + __le32 override; > + __le32 susp_ctrl; > + __le32 reserved4; > + __le32 anasts; > + __le32 adp_ramp_time; > + __le32 ctrl1; > + __le32 ctrl2; > +}; > + > +/* CDNS_RID - bitmasks */ > +#define CDNS_RID(p) ((p) & GENMASK(15, 0)) > + > +/* CDNS_VID - bitmasks */ > +#define CDNS_DID(p) ((p) & GENMASK(31, 0)) > + > +/* OTGCMD - bitmasks */ > +/* "Request the bus for Device mode. */ > +#define OTGCMD_DEV_BUS_REQ BIT(0) > +/* Request the bus for Host mode */ > +#define OTGCMD_HOST_BUS_REQ BIT(1) > +/* Enable OTG mode. */ > +#define OTGCMD_OTG_EN BIT(2) > +/* Disable OTG mode */ > +#define OTGCMD_OTG_DIS BIT(3) > +/*"Configure OTG as A-Device. */ > +#define OTGCMD_A_DEV_EN BIT(4) > +/*"Configure OTG as A-Device. */ > +#define OTGCMD_A_DEV_DIS BIT(5) > +/* Drop the bus for Device mod e. */ > +#define OTGCMD_DEV_BUS_DROP BIT(8) > +/* Drop the bus for Host mode*/ > +#define OTGCMD_HOST_BUS_DROP BIT(9) > +/* Power Down USBSS-DEV. */ > +#define OTGCMD_DEV_POWER_OFF BIT(11) > +/* Power Down CDNSXHCI. */ > +#define OTGCMD_HOST_POWER_OFF BIT(12) > + > +/* OTGIEN - bitmasks */ > +/* ID change interrupt enable */ > +#define OTGIEN_ID_CHANGE_INT BIT(0) > +/* Vbusvalid fall detected interrupt enable.*/ > +#define OTGIEN_VBUSVALID_RISE_INT BIT(4) > +/* Vbusvalid fall detected interrupt enable */ > +#define OTGIEN_VBUSVALID_FALL_INT BIT(5) > + > +/* OTGSTS - bitmasks */ > +/* > + * Current value of the ID pin. It is only valid when idpullup in > + * OTGCTRL1_TYPE register is set to '1'. > + */ > +#define OTGSTS_ID_VALUE BIT(0) > +/* Current value of the vbus_valid */ > +#define OTGSTS_VBUS_VALID BIT(1) > +/* Current value of the b_sess_vld */ > +#define OTGSTS_SESSION_VALID BIT(2) > +/*Device mode is active*/ > +#define OTGSTS_DEV_ACTIVE BIT(3) > +/* Host mode is active. */ > +#define OTGSTS_HOST_ACTIVE BIT(4) > +/* OTG Controller not ready. */ > +#define OTGSTS_OTG_NRDY_MASK BIT(11) > +#define OTGSTS_OTG_NRDY(p) ((p) & OTGSTS_OTG_NRDY_MASK) > +/* > + * Value of the strap pins. > + * 000 - no default configuration > + * 010 - Controller initiall configured as Host > + * 100 - Controller initially configured as Device > + */ > +#define OTGSTS_STRAP(p) (((p) & GENMASK(14, 12)) >> 12) > +#define OTGSTS_STRAP_NO_DEFAULT_CFG 0x00 > +#define OTGSTS_STRAP_HOST_OTG 0x01 > +#define OTGSTS_STRAP_HOST 0x02 > +#define OTGSTS_STRAP_GADGET 0x04 > +/* Host mode is turned on. */ > +#define OTGSTSE_XHCI_READYF BIT(26) > +/* "Device mode is turned on .*/ > +#define OTGSTS_DEV_READY BIT(27) > + > +/* OTGREFCLK - bitmasks */ > +#define OTGREFCLK_STB_CLK_SWITCH_EN BIT(31) > + > +/* OTGCTRL1 - bitmasks */ > +#define OTGCTRL1_IDPULLUP BIT(24) > + > +int cdns3_is_host(struct cdns3 *cdns); > +int cdns3_is_device(struct cdns3 *cdns); > +int cdns3_drd_init(struct cdns3 *cdns); > +int cdns3_drd_update_mode(struct cdns3 *cdns); > +irqreturn_t cdns3_drd_irq(struct cdns3 *cdns); > + > +#endif /* __LINUX_CDNS3_DRD */ > cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3086BC43441 for ; Fri, 23 Nov 2018 14:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5E2E20685 for ; Fri, 23 Nov 2018 14:52:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QrmaXqo4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5E2E20685 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504695AbeKXBgg (ORCPT ); Fri, 23 Nov 2018 20:36:36 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:57478 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440170AbeKXBgg (ORCPT ); Fri, 23 Nov 2018 20:36:36 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id wANEq0HH081902; Fri, 23 Nov 2018 08:52:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1542984720; bh=lq4BiMeIfu+85n1LLlugCBNNofrGa0cDY4qz1vjxOo8=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=QrmaXqo44sCTEJ8ZRfhXuNkk4nhsJDiV/fJVx54QKBQnjavG21iFS/POcTaQocFih j4IM7a/pNEDbiVzVAr+C2VBu8oaimFIommY+YFcWx4obUQpHOCv5xSFDphBt0oKnOl zZewJOsUB/a87fztowZQBnNQ9o3aSLRX5nvBghFs= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wANEq0Ub116744 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 23 Nov 2018 08:52:00 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 23 Nov 2018 08:52:00 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Fri, 23 Nov 2018 08:51:59 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wANEpuWK017181; Fri, 23 Nov 2018 08:51:57 -0600 Subject: Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support To: Pawel Laszczak , References: <1542535751-16079-1-git-send-email-pawell@cadence.com> <1542535751-16079-6-git-send-email-pawell@cadence.com> CC: , , , , , , , , , , From: Roger Quadros Message-ID: <5BF8140C.7000605@ti.com> Date: Fri, 23 Nov 2018 16:51:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1542535751-16079-6-git-send-email-pawell@cadence.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/18 12:09, Pawel Laszczak wrote: > Patch adds supports for detecting Host/Device mode. > Controller has additional OTG register that allow > implement even whole OTG functionality. > At this moment patch adds support only for detecting > the appropriate mode based on strap pins and ID pin. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Makefile | 2 +- > drivers/usb/cdns3/core.c | 27 +++-- > drivers/usb/cdns3/drd.c | 229 +++++++++++++++++++++++++++++++++++++ > drivers/usb/cdns3/drd.h | 122 ++++++++++++++++++++ > 4 files changed, 372 insertions(+), 8 deletions(-) > create mode 100644 drivers/usb/cdns3/drd.c > create mode 100644 drivers/usb/cdns3/drd.h > > diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile > index 02d25b23c5d3..e779b2a2f8eb 100644 > --- a/drivers/usb/cdns3/Makefile > +++ b/drivers/usb/cdns3/Makefile > @@ -1,5 +1,5 @@ > obj-$(CONFIG_USB_CDNS3) += cdns3.o > obj-$(CONFIG_USB_CDNS3_PCI_WRAP) += cdns3-pci.o > > -cdns3-y := core.o > +cdns3-y := core.o drd.o > cdns3-pci-y := cdns3-pci-wrap.o > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c > index f9055d4da67f..dbee4325da7f 100644 > --- a/drivers/usb/cdns3/core.c > +++ b/drivers/usb/cdns3/core.c > @@ -17,6 +17,7 @@ > > #include "gadget.h" > #include "core.h" > +#include "drd.h" > > static inline struct cdns3_role_driver *cdns3_get_current_role_driver(struct cdns3 *cdns) > { > @@ -57,8 +58,10 @@ static inline void cdns3_role_stop(struct cdns3 *cdns) > static enum cdns3_roles cdns3_get_role(struct cdns3 *cdns) > { > if (cdns->roles[CDNS3_ROLE_HOST] && cdns->roles[CDNS3_ROLE_GADGET]) { > - //TODO: implements selecting device/host mode > - return CDNS3_ROLE_HOST; > + if (cdns3_is_host(cdns)) > + return CDNS3_ROLE_HOST; > + if (cdns3_is_device(cdns)) > + return CDNS3_ROLE_GADGET; > } > return cdns->roles[CDNS3_ROLE_HOST] > ? CDNS3_ROLE_HOST > @@ -124,6 +127,12 @@ static irqreturn_t cdns3_irq(int irq, void *data) > struct cdns3 *cdns = data; > irqreturn_t ret = IRQ_NONE; > > + if (cdns->dr_mode == USB_DR_MODE_OTG) { > + ret = cdns3_drd_irq(cdns); > + if (ret == IRQ_HANDLED) > + return ret; > + } The kernel's shared IRQ model takes care of sharing the same interrupt between different devices and their drivers. You don't need to manually handle it here. Just let all 3 drivers do a request_irq() and have handlers check if the IRQ was theirs or not and return IRQ_HANDLED or IRQ_NONE accordingly. Looks like you can do away with irq member of the role driver struct. > + > /* Handle device/host interrupt */ > if (cdns->role != CDNS3_ROLE_END) > ret = cdns3_get_current_role_driver(cdns)->irq(cdns); > @@ -176,11 +185,8 @@ static void cdns3_role_switch(struct work_struct *work) > > cdns = container_of(work, struct cdns3, role_switch_wq); > > - //TODO: implements this functions. > - //host = cdns3_is_host(cdns); > - //device = cdns3_is_device(cdns); > - host = 1; > - device = 0; > + host = cdns3_is_host(cdns); > + device = cdns3_is_device(cdns); What if there is a ID transition between the 2 functions so that and both host and device become true? Since you are checking the ID level separately in both the functions. How about instead having cdns3_get_id() and using it to start/stop relevant roles if we are in OTG mode. Is this going to be used for a role switch even if we're not in OTG mode? If not then it is a BUG if we get here. > > if (host) > role = CDNS3_ROLE_HOST; > @@ -194,6 +200,12 @@ static void cdns3_role_switch(struct work_struct *work) > pm_runtime_get_sync(cdns->dev); > cdns3_role_stop(cdns); > > + if (cdns->desired_dr_mode != cdns->current_dr_mode) { This is about roles, why are we checking dr_mode here? > + cdns3_drd_update_mode(cdns); > + host = cdns3_is_host(cdns); > + device = cdns3_is_device(cdns); > + } > + > if (host) { > if (cdns->roles[CDNS3_ROLE_HOST]) > cdns3_do_role_switch(cdns, CDNS3_ROLE_HOST); > @@ -287,6 +299,7 @@ static int cdns3_probe(struct platform_device *pdev) > if (ret) > goto err2; > > + ret = cdns3_drd_init(cdns); > if (ret) > goto err2; > > diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c > new file mode 100644 > index 000000000000..ac741c80e776 > --- /dev/null > +++ b/drivers/usb/cdns3/drd.c > @@ -0,0 +1,229 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Cadence USBSS DRD Driver. > + * > + * Copyright (C) 2018 Cadence. > + * > + * Author: Pawel Laszczak + * > + */ > +#include > +#include > +#include > +#include > + > +#include "gadget.h" > +#include "drd.h" > + > +/** > + * cdns3_set_mode - change mode of OTG Core > + * @cdns: pointer to context structure > + * @mode: selected mode from cdns_role > + */ > +void cdns3_set_mode(struct cdns3 *cdns, enum usb_dr_mode mode) > +{ > + u32 reg; > + > + cdns->current_dr_mode = mode; > + switch (mode) { > + case USB_DR_MODE_PERIPHERAL: > + dev_info(cdns->dev, "Set controller to Gadget mode\n"); > + writel(OTGCMD_DEV_BUS_REQ | OTGCMD_OTG_DIS, > + &cdns->otg_regs->cmd); > + break; > + case USB_DR_MODE_HOST: > + dev_info(cdns->dev, "Set controller to Host mode\n"); > + writel(OTGCMD_HOST_BUS_REQ | OTGCMD_OTG_DIS, > + &cdns->otg_regs->cmd); > + break; > + case USB_DR_MODE_OTG: > + dev_info(cdns->dev, "Set controller to OTG mode\n"); > + reg = readl(&cdns->otg_regs->ctrl1); > + reg |= OTGCTRL1_IDPULLUP; > + writel(reg, &cdns->otg_regs->ctrl1); > + > + /* wait until valid ID (ID_VALUE) can be sampled (50ms). */ > + mdelay(50); > + break; > + default: > + cdns->current_dr_mode = USB_DR_MODE_UNKNOWN; > + dev_err(cdns->dev, "Unsupported mode of operation %d\n", mode); > + return; > + } > +} > + > +static int cdns3_otg_get_id(struct cdns3 *cdns) > +{ > + int id; > + > + id = readl(&cdns->otg_regs->sts) & OTGSTS_ID_VALUE; > + dev_dbg(cdns->dev, "OTG ID: %d", id); > + return id; > +} > + > +int cdns3_is_host(struct cdns3 *cdns) > +{ > + if (cdns->current_dr_mode == USB_DR_MODE_HOST) > + return 1; Why do you need this? > + else if (cdns->current_dr_mode == USB_DR_MODE_OTG) > + if (!cdns3_otg_get_id(cdns)) > + return 1; > + > + return 0; > +} > + > +int cdns3_is_device(struct cdns3 *cdns) > +{ > + if (cdns->current_dr_mode == USB_DR_MODE_PERIPHERAL) > + return 1; > + else if (cdns->current_dr_mode == USB_DR_MODE_OTG) > + if (cdns3_otg_get_id(cdns)) > + return 1; > + > + return 0; > +} > + > +/** > + * cdns3_otg_disable_irq - Disable all OTG interrupts > + * @cdns: Pointer to controller context structure > + */ > +static void cdns3_otg_disable_irq(struct cdns3 *cdns) > +{ > + writel(0, &cdns->otg_regs->ien); > +} > + > +/** > + * cdns3_otg_enable_irq - enable id and sess_valid interrupts > + * @cdns: Pointer to controller context structure > + */ > +static void cdns3_otg_enable_irq(struct cdns3 *cdns) > +{ > + writel(OTGIEN_ID_CHANGE_INT | OTGIEN_VBUSVALID_RISE_INT | > + OTGIEN_VBUSVALID_FALL_INT, &cdns->otg_regs->ien); > +} > + > +/** > + * cdns3_init_otg_mode - initialize drd controller > + * @cdns: Pointer to controller context structure > + * > + * Returns 0 on success otherwise negative errno > + */ > +static void cdns3_init_otg_mode(struct cdns3 *cdns) > +{ > + cdns3_otg_disable_irq(cdns); > + /* clear all interrupts */ > + writel(~0, &cdns->otg_regs->ivect); > + > + cdns3_set_mode(cdns, USB_DR_MODE_OTG); > + > + cdns3_otg_enable_irq(cdns); > +} > + > +/** > + * cdns3_drd_update_mode - initialize mode of operation Looks like this will be called only once. How about calling it cdns3_drd_init_mode()? > + * @cdns: Pointer to controller context structure > + * > + * Returns 0 on success otherwise negative errno > + */ > +int cdns3_drd_update_mode(struct cdns3 *cdns) > +{ > + int ret = 0; > + > + switch (cdns->desired_dr_mode) { I think we can get rid of desired_dr_mode member in struct cdns. Just pass the mode as an argument to cdns3_drd_init_mode() And we already have cdns->dr_mode. > + case USB_DR_MODE_PERIPHERAL: > + cdns3_set_mode(cdns, USB_DR_MODE_PERIPHERAL); > + break; > + case USB_DR_MODE_HOST: > + cdns3_set_mode(cdns, USB_DR_MODE_HOST); > + break; > + case USB_DR_MODE_OTG: > + cdns3_init_otg_mode(cdns); > + break; > + default: > + dev_err(cdns->dev, "Unsupported mode of operation %d\n", > + cdns->dr_mode); > + return -EINVAL; > + } > + > + return ret; > +} > + > +irqreturn_t cdns3_drd_irq(struct cdns3 *cdns) > +{ > + irqreturn_t ret = IRQ_NONE; > + u32 reg; > + > + if (cdns->dr_mode != USB_DR_MODE_OTG) > + return ret; > + > + reg = readl(&cdns->otg_regs->ivect); > + if (!reg) > + return ret; > + > + if (reg & OTGIEN_ID_CHANGE_INT) { > + int id = cdns3_otg_get_id(cdns); > + > + dev_dbg(cdns->dev, "OTG IRQ: new ID: %d\n", > + cdns3_otg_get_id(cdns)); > + > + if (id) > + cdns->role = CDNS3_ROLE_GADGET; > + else > + cdns->role = CDNS3_ROLE_HOST; Why check ID and set role here? It might change by the time the role_switch_wq starts up. Why not check the ID status there? Also directly changing role here doesn't make sense as there will be a mismatch between currently active role and cdns->role. > + > + queue_work(system_freezable_wq, &cdns->role_switch_wq); > + > + ret = IRQ_HANDLED; > + } > + > + writel(~0, &cdns->otg_regs->ivect); > + return IRQ_HANDLED; return ret; > +} > + > +int cdns3_drd_init(struct cdns3 *cdns) > +{ > + enum usb_dr_mode dr_mode; > + int ret = 0; > + u32 state; > + > + state = OTGSTS_STRAP(readl(&cdns->otg_regs->sts)); > + > + dr_mode = cdns->dr_mode; > + if (state == OTGSTS_STRAP_HOST) { > + dev_info(cdns->dev, "Controller strapped to HOST\n"); > + dr_mode = USB_DR_MODE_HOST; > + if (cdns->dr_mode != USB_DR_MODE_HOST && > + cdns->dr_mode != USB_DR_MODE_OTG) > + ret = -EINVAL; > + } else if (state == OTGSTS_STRAP_GADGET) { > + dev_info(cdns->dev, "Controller strapped to PERIPHERAL\n"); > + dr_mode = USB_DR_MODE_PERIPHERAL; > + if (cdns->dr_mode != USB_DR_MODE_PERIPHERAL && > + cdns->dr_mode != USB_DR_MODE_OTG) > + ret = -EINVAL; > + } > + > + if (ret) { > + dev_err(cdns->dev, "Incorrect DRD configuration\n"); > + return ret; > + } > + > + //Updating DR mode according to strap. > + cdns->dr_mode = dr_mode; > + cdns->desired_dr_mode = dr_mode; > + cdns->current_dr_mode = USB_DR_MODE_UNKNOWN; > + > + dev_info(cdns->dev, "Controller Device ID: %08lx, Revision ID: %08lx\n", > + CDNS_RID(readl(&cdns->otg_regs->rid)), > + CDNS_DID(readl(&cdns->otg_regs->did))); dev_info should be moved at the end if cdns3_drd_update_mode() if it succeeded. > + > + state = readl(&cdns->otg_regs->sts); > + if (OTGSTS_OTG_NRDY(state) != 0) { > + dev_err(cdns->dev, "Cadence USB3 OTG device not ready\n"); > + return -ENODEV; > + } > + > + ret = cdns3_drd_update_mode(cdns); > + > + return ret; > +} > diff --git a/drivers/usb/cdns3/drd.h b/drivers/usb/cdns3/drd.h > new file mode 100644 > index 000000000000..0faa7520ecac > --- /dev/null > +++ b/drivers/usb/cdns3/drd.h > @@ -0,0 +1,122 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Cadence USB3 DRD part of USBSS driver > + * > + * Copyright (C) 2018 Cadence. > + * > + * Author: Pawel Laszczak > + */ > +#ifndef __LINUX_CDNS3_DRD > +#define __LINUX_CDNS3_DRD > + > +#include > +#include > +#include "core.h" > + > +/* DRD register interface. */ > +struct cdns3_otg_regs { > + __le32 did; > + __le32 rid; > + __le32 capabilities; > + __le32 reserved1; > + __le32 cmd; > + __le32 sts; > + __le32 state; > + __le32 reserved2; > + __le32 ien; > + __le32 ivect; > + __le32 refclk; > + __le32 tmr; > + __le32 reserved3[4]; > + __le32 simulate; > + __le32 override; > + __le32 susp_ctrl; > + __le32 reserved4; > + __le32 anasts; > + __le32 adp_ramp_time; > + __le32 ctrl1; > + __le32 ctrl2; > +}; > + > +/* CDNS_RID - bitmasks */ > +#define CDNS_RID(p) ((p) & GENMASK(15, 0)) > + > +/* CDNS_VID - bitmasks */ > +#define CDNS_DID(p) ((p) & GENMASK(31, 0)) > + > +/* OTGCMD - bitmasks */ > +/* "Request the bus for Device mode. */ > +#define OTGCMD_DEV_BUS_REQ BIT(0) > +/* Request the bus for Host mode */ > +#define OTGCMD_HOST_BUS_REQ BIT(1) > +/* Enable OTG mode. */ > +#define OTGCMD_OTG_EN BIT(2) > +/* Disable OTG mode */ > +#define OTGCMD_OTG_DIS BIT(3) > +/*"Configure OTG as A-Device. */ > +#define OTGCMD_A_DEV_EN BIT(4) > +/*"Configure OTG as A-Device. */ > +#define OTGCMD_A_DEV_DIS BIT(5) > +/* Drop the bus for Device mod e. */ > +#define OTGCMD_DEV_BUS_DROP BIT(8) > +/* Drop the bus for Host mode*/ > +#define OTGCMD_HOST_BUS_DROP BIT(9) > +/* Power Down USBSS-DEV. */ > +#define OTGCMD_DEV_POWER_OFF BIT(11) > +/* Power Down CDNSXHCI. */ > +#define OTGCMD_HOST_POWER_OFF BIT(12) > + > +/* OTGIEN - bitmasks */ > +/* ID change interrupt enable */ > +#define OTGIEN_ID_CHANGE_INT BIT(0) > +/* Vbusvalid fall detected interrupt enable.*/ > +#define OTGIEN_VBUSVALID_RISE_INT BIT(4) > +/* Vbusvalid fall detected interrupt enable */ > +#define OTGIEN_VBUSVALID_FALL_INT BIT(5) > + > +/* OTGSTS - bitmasks */ > +/* > + * Current value of the ID pin. It is only valid when idpullup in > + * OTGCTRL1_TYPE register is set to '1'. > + */ > +#define OTGSTS_ID_VALUE BIT(0) > +/* Current value of the vbus_valid */ > +#define OTGSTS_VBUS_VALID BIT(1) > +/* Current value of the b_sess_vld */ > +#define OTGSTS_SESSION_VALID BIT(2) > +/*Device mode is active*/ > +#define OTGSTS_DEV_ACTIVE BIT(3) > +/* Host mode is active. */ > +#define OTGSTS_HOST_ACTIVE BIT(4) > +/* OTG Controller not ready. */ > +#define OTGSTS_OTG_NRDY_MASK BIT(11) > +#define OTGSTS_OTG_NRDY(p) ((p) & OTGSTS_OTG_NRDY_MASK) > +/* > + * Value of the strap pins. > + * 000 - no default configuration > + * 010 - Controller initiall configured as Host > + * 100 - Controller initially configured as Device > + */ > +#define OTGSTS_STRAP(p) (((p) & GENMASK(14, 12)) >> 12) > +#define OTGSTS_STRAP_NO_DEFAULT_CFG 0x00 > +#define OTGSTS_STRAP_HOST_OTG 0x01 > +#define OTGSTS_STRAP_HOST 0x02 > +#define OTGSTS_STRAP_GADGET 0x04 > +/* Host mode is turned on. */ > +#define OTGSTSE_XHCI_READYF BIT(26) > +/* "Device mode is turned on .*/ > +#define OTGSTS_DEV_READY BIT(27) > + > +/* OTGREFCLK - bitmasks */ > +#define OTGREFCLK_STB_CLK_SWITCH_EN BIT(31) > + > +/* OTGCTRL1 - bitmasks */ > +#define OTGCTRL1_IDPULLUP BIT(24) > + > +int cdns3_is_host(struct cdns3 *cdns); > +int cdns3_is_device(struct cdns3 *cdns); > +int cdns3_drd_init(struct cdns3 *cdns); > +int cdns3_drd_update_mode(struct cdns3 *cdns); > +irqreturn_t cdns3_drd_irq(struct cdns3 *cdns); > + > +#endif /* __LINUX_CDNS3_DRD */ > cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki