From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] openposix/20-1-buildonly: Remove test for sigstack structure
Date: Mon, 21 Jan 2019 15:40:30 +0800 [thread overview]
Message-ID: <5C45776E.5080908@cn.fujitsu.com> (raw)
In-Reply-To: <594891AE-21EE-4C26-BF4B-B48BDD95D97F@gmail.com>
On 2019/01/21 15:22, Enji Cooper wrote:
> LGTM!
> -Enji
Hi Enji,
Pushed, thanks. :-)
Best Regards,
Xiao Yang
>> On Jan 20, 2019, at 11:18 PM, Xiao Yang<yangx.jy@cn.fujitsu.com> wrote:
>>
>> Since glibc 2.26, the __USE_XOPEN2K8 macro defined by default _POSIX_C_SOURCE = 200809L
>> && _XOPEN_SOURCE = 700 in CFLAGS triggered the following compiler errors, because both
>> sigstack structure and bsd_signal function are only declared if __USE_XOPEN_EXTENDED is
>> defined and __USE_XOPEN2K8 is not defined:
>> -------------------------------------------------------------------------------
>> 20-1-buildonly.c:13:8: error: invalid use of undefined type 'struct sigstack'
>> sp = t.ss_sp;
>> ...
>> signal_h/23-1.c:15:13: error: 'bsd_signal' undeclared (first use in this function); did you mean 'psignal'?
>> dummyvar = bsd_signal;
>> -------------------------------------------------------------------------------
>>
>> signal_h/23-1.c has been removed by commit d256a97, so just remove obsolete
>> signal_h/20-1-buildonly.c as well.
>>
>> References:
>> https://sourceware.org/git/?p=glibc.git;a=commit;h=666c0c5efa6db73632a6894bf028fef9f3b60d71
>> https://sourceware.org/git/?p=glibc.git;a=commit;h=4c3992fc459322a7c712700ba3244fcb125163d7
>>
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>> ---
>> .../conformance/definitions/signal_h/20-1-buildonly.c | 17 -----------------
>> 1 file changed, 17 deletions(-)
>> delete mode 100644 testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c
>>
>> diff --git a/testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c b/testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c
>> deleted file mode 100644
>> index 21d8cb4..0000000
>> --- a/testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c
>> +++ /dev/null
>> @@ -1,17 +0,0 @@
>> - /*
>> - Test the definition of sigstack.
>> - */
>> -
>> -#include<signal.h>
>> -
>> -struct sigstack this_type_should_exist, t;
>> -int onstack;
>> -void *sp;
>> -
>> -int dummyfcn(void)
>> -{
>> - sp = t.ss_sp;
>> - onstack = t.ss_onstack;
>> -
>> - return 0;
>> -}
>> --
>> 1.8.3.1
>>
>>
>>
prev parent reply other threads:[~2019-01-21 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 11:11 [LTP] [PATCH] openposix/20-1-buildonly, signal_h_23-1: Fix compiler errors on newer glibc Xiao Yang
2019-01-16 9:04 ` Xiao Yang
2019-01-21 7:18 ` [LTP] [PATCH v2] openposix/20-1-buildonly: Remove test for sigstack structure Xiao Yang
2019-01-21 7:22 ` Enji Cooper
2019-01-21 7:40 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C45776E.5080908@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.