From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E91AC43381 for ; Thu, 14 Mar 2019 20:07:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BA792082F for ; Thu, 14 Mar 2019 20:07:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ghGry16I"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="pKE9FWOa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BA792082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Subject:To: MIME-Version:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GYrRug1Mm760dNaAJnbtB0RZibuyV8/8zn5S5y6Nz3Y=; b=ghGry16If685F+ GMcWpVzF+BFEanMCsGxEwLLtJwvVdmnc6TaHQtMXeYI3yaaonPImKv8YKhJbBajQdV/ZlnHwPMn2w DSk5dtlz1Ccqk0L21VmU4tT2edC5N+OZbQDJ2U86FmupgiE8U6at84qU2fYTIJui/UEDvxL2UKcp5 dg5iYyqfqeXE6YksCxTdcD6KjlkGkTAkk3MBUIbijm69Rm1rnnYIBeRY6Y9gmvnL3Eh2lg58rYqRg IX5999HXtpmAKW753soBhd5phdWNfNiTFVAuLRV7DLwcUMiHt35jRRJQ5OWQhRASYyUDY1ECJiKLc PymsiEsPOQotwXvrgNBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Wdj-0000xF-WE; Thu, 14 Mar 2019 20:07:44 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Wdh-0000wf-Bn for linux-amlogic@lists.infradead.org; Thu, 14 Mar 2019 20:07:42 +0000 Received: by mail-wm1-x344.google.com with SMTP id a188so3942161wmf.3 for ; Thu, 14 Mar 2019 13:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=FjAcSKJqzDX3s5cCpFMPy9SjU+PstHwSU7dyfv72OTo=; b=pKE9FWOaxLiTqR81OfppvwXr0XcHRrvqMl4ymocIFvQvv98Zqh5I7j3SNjAo+VxxVb rmZsfJVIdOb021IVqryQ3z6N+kwvfQei5wu/JUWqgUAxxn4ogGoahCGXmdyHlMlGZwzC BFbFbwGCQhz/PhoIBCnVK127M3yCDvUkciFXWSlNfj3q6OyqLkvmSvo8Hgj9rsdRUIQI wh/XncfEwRd1WhpLjVvoHkAsRr+J4x9vh7xzwtpay+U8j4bnlJHO7nIjELdHuFFFCmo7 VmEouFkBKL7W3vuS2vIZf2RmBO7OPjCFUMEfOzFX/57sf6v4eungCzYXx26l8dD1tA9+ Sunw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-transfer-encoding; bh=FjAcSKJqzDX3s5cCpFMPy9SjU+PstHwSU7dyfv72OTo=; b=mW5GOBpOpy1AbSex3JG/dyCwa5/NRrrdohl3JKlyM7yTuGAPE1L4us8nOSfcvCqQ4P XYldFUEKXOtDKtnO1+qkLcyilRjkptMQoect3/VJ7iBd2xdC+L4n7Y9chBCXy2HndRzC wpPdc5efEAyGCtLjbKdDBLwSws54/XUI/eoIHEFy68716Yjt1f32Qjdso9K4PuRSNA9H EKL+zBNLm49gpbdluEKw6Nnt8RyBKvlAG+8gIntmY9Szvs7DodtsoEVQWqECDy469wI0 u+BdxtuTPqt3YU4cusT6yxn44YSApQB+El7o4SbM5tnHArvS5JS+ZueRENxfLvvylHxK lVPQ== X-Gm-Message-State: APjAAAUY1sFIdLcNyHwA/ZDDBINep6ZLleL0qza7DPf8X3OYc8LIXFKO 0BnwRRQuD3mdPSS2f5OvaPxJhrTkCCFEWePX X-Google-Smtp-Source: APXvYqy1j+jdwlg6ZoMYfS11o4d9hri4qOmL3S1gJva4iASfo96QffmedFVYpyzZ6v0N06nqlwK8ZQ== X-Received: by 2002:a1c:e90f:: with SMTP id q15mr169343wmc.112.1552594058763; Thu, 14 Mar 2019 13:07:38 -0700 (PDT) Received: from [192.168.1.77] (wal59-h01-176-150-251-154.dsl.sta.abo.bbox.fr. [176.150.251.154]) by smtp.gmail.com with ESMTPSA id f6sm16481116wrt.87.2019.03.14.13.07.37 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Mar 2019 13:07:38 -0700 (PDT) Message-ID: <5C8AB489.3000202@baylibre.com> Date: Thu, 14 Mar 2019 21:07:37 +0100 From: Neil Armstrong User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Rob Herring Subject: Re: [PATCH v2 1/8] drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support References: <1549022873-40549-1-git-send-email-narmstrong@baylibre.com> <1549022873-40549-2-git-send-email-narmstrong@baylibre.com> <36800d4e-0bb7-378c-e512-5ae02406865b@baylibre.com> <6e0f70a4-8e12-7000-bc5d-de5093d173c5@baylibre.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_130741_468247_1C401DF4 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "heiko@sntech.de" , Maxime Ripard , Sandy Huang , dri-devel , "linux-kernel@vger.kernel.org" , Andrzej Hajda , Nickey Yang , Laurent Pinchart , Philipp Zabel , linux-amlogic@lists.infradead.org, Huicong Xu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgUm9iLAoKTGUgMTQvMDMvMjAxOSAxOTo1NSwgUm9iIEhlcnJpbmcgYSDDqWNyaXQgOgo+IE9u IE1vbiwgTWFyIDExLCAyMDE5IGF0IDM6NTMgQU0gTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdA YmF5bGlicmUuY29tPiB3cm90ZToKPj4KPj4gT24gMDgvMDMvMjAxOSAxNTo1NCwgUm9iIEhlcnJp bmcgd3JvdGU6Cj4+PiBPbiBGcmksIE1hciA4LCAyMDE5IGF0IDI6MDUgQU0gTmVpbCBBcm1zdHJv bmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPiB3cm90ZToKPj4+Pgo+Pj4+IEhpIFJvYiwKPj4+ Pgo+Pj4+IE9uIDA4LzAzLzIwMTkgMDA6MTMsIFJvYiBIZXJyaW5nIHdyb3RlOgo+Pj4+PiBPbiBG cmksIEZlYiAxLCAyMDE5IGF0IDY6MDggQU0gTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5 bGlicmUuY29tPiB3cm90ZToKPj4+Pj4+Cj4+Pj4+PiBBZGQgc3VwcG9ydCBmb3IgU0NEQyBTZXR1 cCBmb3IgVE1EUyBDbG9jayA+IDMuNEdIeiBhbmQgZW5hYmxlIFRNRFMKPj4+Pj4+IFNjcmFtYmxp bmcgd2hlbiBzdXBwb3J0ZWQgb3IgbWFuZGF0b3J5Lgo+Pj4+Pj4KPj4+Pj4+IFRoaXMgcGF0Y2gg YWxzbyBhZGRzIGFuIGhlbHBlciB0byBzZXR1cCB0aGUgY29udHJvbCBiaXQgdG8gc3VwcG9ydAo+ Pj4+Pj4gdGhlIGhpZ2ggVE1EUyBCaXQgUGVyaW9kL1RNRFMgQ2xvY2stUGVyaW9kIFJhdGlvIGFz IHJlcXVpcmVkIHdpdGgKPj4+Pj4+IFRNRFMgQ2xvY2sgPiAzLjRHSHogZm9yIEhETUkyLjAgMzg0 MHgyMTYwQDYwLzUwIG1vZGVzLgo+Pj4+Pj4KPj4+Pj4+IFRoZXNlIGNoYW5nZXMgd2VyZSBiYXNl ZCBvbiB3b3JrIGRvbmUgYnkgSHVpY29uZyBYdSA8eGhjQHJvY2stY2hpcHMuY29tPgo+Pj4+Pj4g YW5kIE5pY2tleSBZYW5nIDxuaWNrZXkueWFuZ0Byb2NrLWNoaXBzLmNvbT4gdG8gc3VwcG9ydCBI RE1JMi4wIG1vZGVzCj4+Pj4+PiBvbiB0aGUgUm9ja2NoaXAgNC40IEJTUCBrZXJuZWwgYXQgWzFd Cj4+Pj4+Pgo+Pj4+Pj4gWzFdIGh0dHBzOi8vZ2l0aHViLmNvbS9yb2NrY2hpcC1saW51eC9rZXJu ZWwvdHJlZS9yZWxlYXNlLTQuNAo+Pj4+Pj4KPj4+Pj4+IENjOiBOaWNrZXkgWWFuZyA8bmlja2V5 LnlhbmdAcm9jay1jaGlwcy5jb20+Cj4+Pj4+PiBDYzogSHVpY29uZyBYdSA8eGhjQHJvY2stY2hp cHMuY29tPgo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdA YmF5bGlicmUuY29tPgo+Pj4+Pj4gVGVzdGVkLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250 ZWNoLmRlPgo+Pj4+Pj4gUmV2aWV3ZWQtYnk6IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ftc3Vu Zy5jb20+Cj4+Pj4+PiAtLS0KPj4+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lz L2R3LWhkbWkuYyB8IDg1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPj4+Pj4+ICBk cml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuaCB8ICAxICsKPj4+Pj4+ICBp bmNsdWRlL2RybS9icmlkZ2UvZHdfaGRtaS5oICAgICAgICAgICAgICB8ICAxICsKPj4+Pj4+ICAz IGZpbGVzIGNoYW5nZWQsIDg1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Pj4+Cj4+ Pj4+IFRoaXMgY29tbWl0IGluIGRybS1taXNjLW5leHQgaXMgYnJlYWtpbmcgYm9vdGluZyBvbiB0 aGUgUm9jazk2MC4gSQo+Pj4+PiBoYXZlIEZCIGFuZCBmYmNvbiBlbmFibGVkLiBUaGUgYm9vdCBo YW5ncyBhZnRlciB0aGlzIG1lc3NhZ2U6Cj4+Pj4+Cj4+Pj4+IFsgICAgMy4wMTIzMzRdIFtkcm06 cm9ja2NoaXBfZHJtX2ZiZGV2X2NyZWF0ZV0gRkIgWzE5MjB4MTA4MF0tMjQKPj4+Pj4ga3ZhZGRy PShfX19fcHRydmFsX19fXykgb2Zmc2V0PTAgc2l6ZT04Mjk0NDAwCj4+Pj4KPj4+PiBDb3VsZCB5 b3UgZ2l2ZSBtb3JlIGRldGFpbHMgb24gdGhlIHRyZWUgdXNlZCA/IGRpZCB5b3UgYmlzZWN0IHRv IGZpbmQgdGhpcyBjb21taXQgPwo+Pj4KPj4+IEFzIEkgc2FpZCBhYm92ZSwgZHJtLW1pc2MtbmV4 dCAoZnJvbSBkcm0tbWlzYyB0cmVlKSBpcyB0aGUgYnJhbmNoLiBJCj4+PiBiaXNlY3RlZCBiZXR3 ZWVuIGl0IGFuZCB2NS4wLiBSZXZlcnRpbmcgaXQgZml4ZXMgYm9vdGluZy4KPj4KPj4gVGhhbmtz LCBjb3VsZCB5b3UgZ2l2ZSBtb3JlIGRldGFpbHMgb24gdGhlIGVudmlyb25tZW50ID8gRGlkIHlv dSB0ZXN0IG92ZXIgdGhlIGxhdGVzdCBsaW51eC1uZXh0ID8KPiAKPiBIZXJlJ3MgYSBsb2cgb2Yg dGhlIGRybSBwYXJ0czogaHR0cHM6Ly9wYXN0ZWJpbi5jb20vdEZKOUdzNmgKPiAKPiBsaW51eC1u ZXh0IGFsc28gaGFuZ3MuCj4gCj4+IENhbiB5b3Ugc2hhcmUgdGhlIEVESUQgb2YgeW91ciBtb25p dG9yID8KPiAKPiBNYXliZSBub3QgbW9kZSByZWxhdGVkLiBJIHRyaWVkIGZvcmNpbmcgdG8gMTI4 MHg3MjAgYW5kIGl0IGhhbmdzIHRvby4KPiBJbiBhbnkgY2FzZSwgaGVyZSdzIHRoZSBwYXJzZWQg RURJRDoKPiAKPiAyNTYtYnl0ZSBFRElEIHN1Y2Nlc3NmdWxseSByZXRyaWV2ZWQgZnJvbSBpMmMg YnVzIDMKPiBMb29rcyBsaWtlIGkyYyB3YXMgc3VjY2Vzc2Z1bC4gSGF2ZSBhIGdvb2QgZGF5Lgo+ IENoZWNrc3VtIENvcnJlY3QKPiAKPiBTZWN0aW9uICJNb25pdG9yIgo+IElkZW50aWZpZXIgIkNZ Uy1SMTAxIgo+IE1vZGVsTmFtZSAiQ1lTLVIxMDEiCj4gVmVuZG9yTmFtZSAiQ1lYIgo+ICMgTW9u aXRvciBNYW51ZmFjdHVyZWQgd2VlayAyOCBvZiAyMDE4Cj4gIyBFRElEIHZlcnNpb24gMS4zCj4g IyBEaWdpdGFsIERpc3BsYXkKPiBEaXNwbGF5U2l6ZSAyMjAgMTMwCj4gR2FtbWEgMi4yMAo+IE9w dGlvbiAiRFBNUyIgInRydWUiCj4gSG9yaXpzeW5jIDMwLTEwMgo+IFZlcnRSZWZyZXNoIDQ4LTc1 Cj4gIyBNYXhpbXVtIHBpeGVsIGNsb2NrIGlzIDE5ME1Iego+ICNOb3QgZ2l2aW5nIHN0YW5kYXJk IG1vZGU6IDE5MjB4MTA4MCwgNjBIego+ICNOb3QgZ2l2aW5nIHN0YW5kYXJkIG1vZGU6IDE5MjB4 MTA4MCwgNjBIego+ICNOb3QgZ2l2aW5nIHN0YW5kYXJkIG1vZGU6IDE5MjB4MTA4MCwgNjBIego+ ICNOb3QgZ2l2aW5nIHN0YW5kYXJkIG1vZGU6IDE0NDB4OTAwLCA2MEh6Cj4gI05vdCBnaXZpbmcg c3RhbmRhcmQgbW9kZTogMTQwMHgxMDUwLCA2MEh6Cj4gI05vdCBnaXZpbmcgc3RhbmRhcmQgbW9k ZTogMTI4MHgxMDI0LCA2MEh6Cj4gI05vdCBnaXZpbmcgc3RhbmRhcmQgbW9kZTogMTI4MHg5NjAs IDYwSHoKPiAjTm90IGdpdmluZyBzdGFuZGFyZCBtb2RlOiAxMjgweDcyMCwgNjBIego+IAo+ICNF eHRlbnNpb24gYmxvY2sgZm91bmQuIFBhcnNpbmcuLi4KPiBNb2RlbGluZSAiTW9kZSA1IiA1NC4w MCAyNTYwIDI2MDggMjY0MCAyNzIwIDE0NDAgMTQ0MyAxNDQ4IDE0ODEgK2hzeW5jICt2c3luYwo+ IE1vZGVsaW5lICJNb2RlIDAiIDI2Ny44MSAyNTYwIDI2MDggMjY0MCAyNzIwIDE2MDAgMTYwMyAx NjA4IDE2NDEgK2hzeW5jICt2c3luYwo+IE1vZGVsaW5lICJNb2RlIDEiIDE0OC41MDAgMTkyMCAy MDA4IDIwNTIgMjIwMCAxMDgwIDEwODQgMTA4OSAxMTI1ICtoc3luYyArdnN5bmMKPiBNb2RlbGlu ZSAiTW9kZSAyIiA3NC4yNTAgMTkyMCAyMDA4IDIwNTIgMjIwMCAxMDgwIDEwODIgMTA4NyAxMTI1 Cj4gK2hzeW5jICt2c3luYyBpbnRlcmxhY2UKPiBNb2RlbGluZSAiTW9kZSAzIiA3NC4yNTAgMTI4 MCAxMzkwIDE0MjAgMTY1MCA3MjAgNzI1IDczMCA3NTAgK2hzeW5jICt2c3luYwo+IE1vZGVsaW5l ICJNb2RlIDQiIDE0OC41MDAgMTkyMCAyNDQ4IDI0OTIgMjY0MCAxMDgwIDEwODQgMTA4OSAxMTI1 ICtoc3luYyArdnN5bmMKPiBPcHRpb24gIlByZWZlcnJlZE1vZGUiICJNb2RlIDUiCj4gRW5kU2Vj dGlvbgo+IAo+PiBDYW4geW91IGNoZWNrIHRoaXMgcGF0Y2ggOgo+IAo+IFN0aWxsIGhhbmdzIHdp dGggaXQuCgoKVGhhbmtzIGZvciB0ZXN0aW5nLCB0aGUgb25seSBpbXBhY3Qgd291bGQgYmUgaWYg aGRtaV9pbmZvLT5zY2RjLnN1cHBvcnRlZAphbmQgaGRtaV9pbmZvLT5zY2RjLnNjcmFtYmxpbmcu bG93X3JhdGUgd2VyZSB0cnVlLgpIb25lc3RseSwgaGRtaV9pbmZvLT5zY2RjLnNjcmFtYmxpbmcu bG93X3JhdGUgd2Fzbid0IHJlYWxseSB0ZXN0ZWQuCgpDb3VsZCB5b3UgZHVtcCB0aGUgZWRpZCBp biBiaW5hcnkgZm9ybWF0ID8gb3IgcGFyc2UgaXQgd2l0aCBodHRwczovL2dpdGh1Yi5jb20vcnBh dmxpay9lZGlkLWRlY29kZQpzdXBwb3J0aW5nIG1vZGVybiBIRE1JIEVESURzLgoKClRoYW5rcywK TmVpbAo+IAo+Pgo+PiAtLS0tPjwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYyBiL2Ry aXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jCj4+IGluZGV4IGE2M2U1ZjBk YWU1Ni4uZjMzYzJhYzE1OGMxIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L3N5bm9wc3lzL2R3LWhkbWkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9w c3lzL2R3LWhkbWkuYwo+PiBAQCAtMTI2OCw4ICsxMjY4LDYgQEAgc3RhdGljIGludCBoZG1pX3Bo eV9jb25maWd1cmUoc3RydWN0IGR3X2hkbWkgKmhkbWkpCj4+Cj4+ICAgICAgICAgZHdfaGRtaV9w aHlfcG93ZXJfb2ZmKGhkbWkpOwo+Pgo+PiAtICAgICAgIGR3X2hkbWlfc2V0X2hpZ2hfdG1kc19j bG9ja19yYXRpbyhoZG1pKTsKPj4gLQo+PiAgICAgICAgIC8qIExlYXZlIGxvdyBwb3dlciBjb25z dW1wdGlvbiBtb2RlIGJ5IGFzc2VydGluZyBTVlNSRVQuICovCj4+ICAgICAgICAgaWYgKHBoeS0+ aGFzX3N2c3JldCkKPj4gICAgICAgICAgICAgICAgIGR3X2hkbWlfcGh5X2VuYWJsZV9zdnNyZXQo aGRtaSwgMSk7Cj4+Cj4+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [PATCH v2 1/8] drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support Date: Thu, 14 Mar 2019 21:07:37 +0100 Message-ID: <5C8AB489.3000202@baylibre.com> References: <1549022873-40549-1-git-send-email-narmstrong@baylibre.com> <1549022873-40549-2-git-send-email-narmstrong@baylibre.com> <36800d4e-0bb7-378c-e512-5ae02406865b@baylibre.com> <6e0f70a4-8e12-7000-bc5d-de5093d173c5@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Andrzej Hajda , Laurent Pinchart , Philipp Zabel , Sandy Huang , "heiko@sntech.de" , Maxime Ripard , "linux-kernel@vger.kernel.org" , dri-devel , Nickey Yang , linux-amlogic@lists.infradead.org, Huicong Xu List-Id: dri-devel@lists.freedesktop.org Hi Rob, Le 14/03/2019 19:55, Rob Herring a écrit : > On Mon, Mar 11, 2019 at 3:53 AM Neil Armstrong wrote: >> >> On 08/03/2019 15:54, Rob Herring wrote: >>> On Fri, Mar 8, 2019 at 2:05 AM Neil Armstrong wrote: >>>> >>>> Hi Rob, >>>> >>>> On 08/03/2019 00:13, Rob Herring wrote: >>>>> On Fri, Feb 1, 2019 at 6:08 AM Neil Armstrong wrote: >>>>>> >>>>>> Add support for SCDC Setup for TMDS Clock > 3.4GHz and enable TMDS >>>>>> Scrambling when supported or mandatory. >>>>>> >>>>>> This patch also adds an helper to setup the control bit to support >>>>>> the high TMDS Bit Period/TMDS Clock-Period Ratio as required with >>>>>> TMDS Clock > 3.4GHz for HDMI2.0 3840x2160@60/50 modes. >>>>>> >>>>>> These changes were based on work done by Huicong Xu >>>>>> and Nickey Yang to support HDMI2.0 modes >>>>>> on the Rockchip 4.4 BSP kernel at [1] >>>>>> >>>>>> [1] https://github.com/rockchip-linux/kernel/tree/release-4.4 >>>>>> >>>>>> Cc: Nickey Yang >>>>>> Cc: Huicong Xu >>>>>> Signed-off-by: Neil Armstrong >>>>>> Tested-by: Heiko Stuebner >>>>>> Reviewed-by: Andrzej Hajda >>>>>> --- >>>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 85 ++++++++++++++++++++++++++++++- >>>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 1 + >>>>>> include/drm/bridge/dw_hdmi.h | 1 + >>>>>> 3 files changed, 85 insertions(+), 2 deletions(-) >>>>> >>>>> This commit in drm-misc-next is breaking booting on the Rock960. I >>>>> have FB and fbcon enabled. The boot hangs after this message: >>>>> >>>>> [ 3.012334] [drm:rockchip_drm_fbdev_create] FB [1920x1080]-24 >>>>> kvaddr=(____ptrval____) offset=0 size=8294400 >>>> >>>> Could you give more details on the tree used ? did you bisect to find this commit ? >>> >>> As I said above, drm-misc-next (from drm-misc tree) is the branch. I >>> bisected between it and v5.0. Reverting it fixes booting. >> >> Thanks, could you give more details on the environment ? Did you test over the latest linux-next ? > > Here's a log of the drm parts: https://pastebin.com/tFJ9Gs6h > > linux-next also hangs. > >> Can you share the EDID of your monitor ? > > Maybe not mode related. I tried forcing to 1280x720 and it hangs too. > In any case, here's the parsed EDID: > > 256-byte EDID successfully retrieved from i2c bus 3 > Looks like i2c was successful. Have a good day. > Checksum Correct > > Section "Monitor" > Identifier "CYS-R101" > ModelName "CYS-R101" > VendorName "CYX" > # Monitor Manufactured week 28 of 2018 > # EDID version 1.3 > # Digital Display > DisplaySize 220 130 > Gamma 2.20 > Option "DPMS" "true" > Horizsync 30-102 > VertRefresh 48-75 > # Maximum pixel clock is 190MHz > #Not giving standard mode: 1920x1080, 60Hz > #Not giving standard mode: 1920x1080, 60Hz > #Not giving standard mode: 1920x1080, 60Hz > #Not giving standard mode: 1440x900, 60Hz > #Not giving standard mode: 1400x1050, 60Hz > #Not giving standard mode: 1280x1024, 60Hz > #Not giving standard mode: 1280x960, 60Hz > #Not giving standard mode: 1280x720, 60Hz > > #Extension block found. Parsing... > Modeline "Mode 5" 54.00 2560 2608 2640 2720 1440 1443 1448 1481 +hsync +vsync > Modeline "Mode 0" 267.81 2560 2608 2640 2720 1600 1603 1608 1641 +hsync +vsync > Modeline "Mode 1" 148.500 1920 2008 2052 2200 1080 1084 1089 1125 +hsync +vsync > Modeline "Mode 2" 74.250 1920 2008 2052 2200 1080 1082 1087 1125 > +hsync +vsync interlace > Modeline "Mode 3" 74.250 1280 1390 1420 1650 720 725 730 750 +hsync +vsync > Modeline "Mode 4" 148.500 1920 2448 2492 2640 1080 1084 1089 1125 +hsync +vsync > Option "PreferredMode" "Mode 5" > EndSection > >> Can you check this patch : > > Still hangs with it. Thanks for testing, the only impact would be if hdmi_info->scdc.supported and hdmi_info->scdc.scrambling.low_rate were true. Honestly, hdmi_info->scdc.scrambling.low_rate wasn't really tested. Could you dump the edid in binary format ? or parse it with https://github.com/rpavlik/edid-decode supporting modern HDMI EDIDs. Thanks, Neil > >> >> ----><---------------------------------------------------------------------------------------- >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> index a63e5f0dae56..f33c2ac158c1 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> @@ -1268,8 +1268,6 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi) >> >> dw_hdmi_phy_power_off(hdmi); >> >> - dw_hdmi_set_high_tmds_clock_ratio(hdmi); >> - >> /* Leave low power consumption mode by asserting SVSRET. */ >> if (phy->has_svsret) >> dw_hdmi_phy_enable_svsret(hdmi, 1); >> >>