From: Bram Yvahk <bram-yvahk@mail.wizbit.be>
To: netdev@vger.kernel.org
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
davem@davemloft.net
Subject: [ipsec/xfrmi] fragmentation of IPv4 packets
Date: Mon, 18 Mar 2019 00:59:59 +0100 [thread overview]
Message-ID: <5C8EDF7F.2010100@mail.wizbit.be> (raw)
After running into some issues with VTI code (see my VTI patches) I
decided to take a peek at the xfrmi code. I believe it has the same
problems as the VTI code for which I submitted patches.
I was planning on testing this with latest kernel but so far I've not
yet been able to do so... Only reason why I'm already submitting this
message is because there is a 'Linux IPsec workshop' next week.
Two issues that I believe exist:
- 'xfrmi_xmit2': for an IPv4 packet the DF bit is not checked --> it
will send a 'ICMP_FRAG_NEEDED' in response to a packet that is too
big but does not have the 'DF' bit set. I believe proper behavior
is to fragment the packet
See also: [PATCH ipsec/vti 1/2] vti: fragment IPv4 packets when DF bit
is not
- 'xfrmi6_err': this is not able to handle a ICMPv6 in response to a
fragmented IPv6 ESP packet. It uses iph->nexthdr which will be set
to 'NEXTHDR_FRAGMENT' which is unhand led in the code.
(It expects IPPROTO_ESP/_AH/_COMP)
See also: [PATCH ipsec/vti 2/2] vti6: process icmp msg when IPv6 is
fragmented
reply other threads:[~2019-03-17 23:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C8EDF7F.2010100@mail.wizbit.be \
--to=bram-yvahk@mail.wizbit.be \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.