From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
Date: Fri, 5 Apr 2019 15:32:13 +0800 [thread overview]
Message-ID: <5CA7047D.2080606@cn.fujitsu.com> (raw)
In-Reply-To: <20190405071324.GA30802@dell5510>
On 2019/04/05 15:13, Petr Vorel wrote:
> Hi Xiao, Cyril,
>
>> Thanks for your comment.
>> I will send v2 patch as you suggested. :-)
> v2 has LTP_CHECK_LIBC_FUNCS in m4/ltp-libc-funcs.m4.
> IMHO it'd be better to have simple AC_CHECK_FUNCS() in configure.ac, i.e. the
> same way we handle AC_CHECK_HEADERS(). It might not be good to mix configure.ac
> and m4/ltp-*.m4, but I guess general functions like this is easier to find in
> configure.ac than in some of m4/ltp-*.m4.
Hi Petr,
Sorry, I missed your last comment.
It seems easier to remove LTP_CHECK_LIBC_FUNCS directly.
I will send v3 patch soon.
Best Regards,
Xiao Yang
>
> Kind regards,
> Petr
>
>> Best Regards,
>> Xiao Yang
>> On 2019/04/04 19:58, Petr Vorel wrote:
>>> Hi,
>>>>> Note about formatting: maybe it'd be easier to edit the file if each function
>>>>> was on separate line.
>>>> Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
>>>> step would be moving these there as well.
>>> +1 (easier to find general things like this in configure.ac than in m4/ltp-*.m4.
>>>> Other than that this is a great cleanup, thanks for doing this.
>>> Kind regards,
>>> Petr
>
>
>
>
>
>
>
>
prev parent reply other threads:[~2019-04-05 7:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 9:36 [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Xiao Yang
2019-03-28 9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
2019-03-28 15:24 ` Petr Vorel
2019-03-29 3:19 ` Xiao Yang
2019-04-17 17:10 ` Petr Vorel
2019-03-28 14:56 ` [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Petr Vorel
2019-03-28 15:12 ` Petr Vorel
2019-04-04 10:31 ` Cyril Hrubis
2019-04-04 11:58 ` Petr Vorel
2019-04-05 3:15 ` Xiao Yang
2019-04-05 7:13 ` Petr Vorel
2019-04-05 7:32 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CA7047D.2080606@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.