From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 3/3] syscalls/sigpending02.c: Add libc sigpending() detection && reset sighandler_counter
Date: Mon, 8 Apr 2019 09:55:25 +0800 [thread overview]
Message-ID: <5CAAAA0D.9090805@cn.fujitsu.com> (raw)
In-Reply-To: <20190405090620.GA8149@dell5510>
Hi Petr, Cyril
Pushed with left-shift break. :-)
Thanks a lot.
Best Regards,
Xiao Yang
On 2019/04/05 17:06, Petr Vorel wrote:
> Hi Xiao,
>
> whole patchset LGTM.
> ...
>> +++ b/testcases/kernel/syscalls/sigpending/sigpending02.c
>> @@ -13,6 +13,7 @@
>> * Test 2: Call sigpending(sigset_t*=-1), it should return -1 with errno EFAULT.
>> */
>> +#include "config.h"
>> #include "tst_test.h"
>> #include "ltp_signal.h"
>> #include "lapi/syscalls.h"
>> @@ -36,7 +37,12 @@ static int tested_sigpending(sigset_t *sigset)
>> {
>> switch (tst_variant) {
>> case 0:
>> +#ifndef HAVE_SIGPENDING
>> + tst_brk(TCONF, "libc sigpending() is not implemented");
>> +#else
>> return sigpending(sigset);
>> +#endif
>> + break;
> very minor nit: shift left break (to be on the same level as case).
>
>> case 1:
>> return tst_syscall(__NR_sigpending, sigset);
>> case 2:
> Kind regards,
> Petr
>
>
>
prev parent reply other threads:[~2019-04-08 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 8:07 [LTP] [PATCH v3 1/3] configure.ac: Simplify the check for libc function implementations Xiao Yang
2019-04-05 8:07 ` [LTP] [PATCH v3 2/3] syscalls/stime: Add libc stime() detection Xiao Yang
2019-04-05 8:07 ` [LTP] [PATCH v3 3/3] syscalls/sigpending02.c: Add libc sigpending() detection && reset sighandler_counter Xiao Yang
2019-04-05 9:06 ` Petr Vorel
2019-04-08 1:55 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CAAAA0D.9090805@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.