Re: [PATCH] glib-2.0: fix ptest failures

["Yu, Mingli" <mingli.yu@windriver.com>]

On 2019年04月24日 20:07, Burton, Ross wrote:
> On Wed, 24 Apr 2019 at 02:51, Yu, Mingli <mingli.yu@windriver.com> wrote:
>> Per the comments at https://gitlab.gnome.org/GNOME/glib/issues/1357, we
>> need to run test_non_utf8_printf under builddir to guarantee the test
>> passed.
>
> Re-read the comments.  Setting that variable skips the test, as it
> isn't useful without the translations being installed. So, we need to
> install the translations:
>
> root@bob:~# /usr/libexec/installed-tests/glib/gdatetime -p
> /GDateTime/non_utf8_printf
> /GDateTime/non_utf8_printf: **
> GLib:ERROR:../glib-2.58.3/glib/tests/gdatetime.c:1477:test_non_utf8_printf:
> assertion failed (__p == ("10\346\234\210")): ("Oct" ==
> "10\346\234\210")
> Aborted (core dumped)
>
> root@bob:~# dnf install glib-2.0-locale-ja
> [ ... ]
> Installed:
>    libglib-2.0-locale-ja-1:2.58.3-r0.corei7_64

Many thanks for Ross's comments!

Yes, it's true. Install libglib-2.0-locale-ja-2.58.3-r0 did silence the 
test_non_utf8_printf failure of gdatetime.test.

But once unset G_TEST_BUILDDIR, we should check the translation modules 
one by one to silence other failures such as below to guarantee 
gdatetime.test passed.

GLib:ERROR:../glib-2.58.3/glib/tests/gdatetime.c:1683:test_month_names: 
assertion failed (p_casefold == (o_casefold)): ("sep" == "sept.")
Bail out! 
GLib:ERROR:../glib-2.58.3/glib/tests/gdatetime.c:1683:test_month_names: 
assertion failed (p_casefold == (o_casefold)): ("sep" == "sept.")
FAIL: glib/gdatetime.test (Child process killed by signal 6)

Anyway, I will check the translation issues one by one and resent the patch.

Thanks,

>
> root@bob:~# /usr/libexec/installed-tests/glib/gdatetime -p
> /GDateTime/non_utf8_printf
> /GDateTime/non_utf8_printf: OK
>
> Ross
>