diff for duplicates of <5CD844B0.5060206@bfs.de> diff --git a/a/1.txt b/N1/1.txt index bb2be50..40ea8b2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -44,7 +44,7 @@ Am 12.05.2019 09:45, schrieb David Howells: > - int which = 0, dsize, ret; > + int which = 0, dsize, ret = -ENOMEM; > -> if (strcmp(name, "acl") = 0) +> if (strcmp(name, "acl") == 0) > which = 0; > @@ -163,20 +162,26 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler, > else @@ -54,10 +54,10 @@ Am 12.05.2019 09:45, schrieb David Howells: > + if (!yacl) > + goto error; > + -> if (which = 0) +> if (which == 0) > - flags |= YFS_ACL_WANT_ACL; > + yacl->flags |= YFS_ACL_WANT_ACL; -> else if (which = 3) +> else if (which == 3) > - flags |= YFS_ACL_WANT_VOL_ACL; > + yacl->flags |= YFS_ACL_WANT_VOL_ACL; > @@ -82,7 +82,7 @@ Am 12.05.2019 09:45, schrieb David Howells: > ret = afs_end_vnode_operation(&fc); > } > -> - if (ret = 0) { +> - if (ret == 0) { > - switch (which) { > - case 0: > - data = yacl->acl->data; diff --git a/a/content_digest b/N1/content_digest index 4033d4d..9d1d461 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0155764714872.24080.15171754166782593095.stgit@warthog.procyon.org.uk\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [PATCH 2/2] afs: Fix afs_xattr_get_yfs() to not try freeing an error value\0" - "Date\0Sun, 12 May 2019 16:07:12 +0000\0" + "Date\0Sun, 12 May 2019 18:07:12 +0200\0" "To\0David Howells <dhowells@redhat.com>\0" "Cc\0colin.king@canonical.com" joe@perches.com @@ -58,7 +58,7 @@ "> -\tint which = 0, dsize, ret;\n" "> +\tint which = 0, dsize, ret = -ENOMEM;\n" "> \n" - "> \tif (strcmp(name, \"acl\") = 0)\n" + "> \tif (strcmp(name, \"acl\") == 0)\n" "> \t\twhich = 0;\n" "> @@ -163,20 +162,26 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,\n" "> \telse\n" @@ -68,10 +68,10 @@ "> +\tif (!yacl)\n" "> +\t\tgoto error;\n" "> +\n" - "> \tif (which = 0)\n" + "> \tif (which == 0)\n" "> -\t\tflags |= YFS_ACL_WANT_ACL;\n" "> +\t\tyacl->flags |= YFS_ACL_WANT_ACL;\n" - "> \telse if (which = 3)\n" + "> \telse if (which == 3)\n" "> -\t\tflags |= YFS_ACL_WANT_VOL_ACL;\n" "> +\t\tyacl->flags |= YFS_ACL_WANT_VOL_ACL;\n" "> \n" @@ -96,7 +96,7 @@ "> \t\tret = afs_end_vnode_operation(&fc);\n" "> \t}\n" "> \n" - "> -\tif (ret = 0) {\n" + "> -\tif (ret == 0) {\n" "> -\t\tswitch (which) {\n" "> -\t\tcase 0:\n" "> -\t\t\tdata = yacl->acl->data;\n" @@ -255,4 +255,4 @@ "> \n" > -1fe95d30db5bec25147a02155b11f20a3715841a7261fedf6fbd27fcee0179e9 +11b06e009f6cdf9615bc03ee9481ba2d3b314d7b1e1bf38bf79369bfedba3138
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.