From: xuyang <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ltp-cap.m4: add libcap version detection && fix compiler error
Date: Tue, 14 May 2019 13:24:52 +0800 [thread overview]
Message-ID: <5CDA5124.3070708@cn.fujitsu.com> (raw)
In-Reply-To: <20190513131451.GA22761@dell5510>
on 2019/05/13 21:14, Petr Vorel wrote:
> Hi Yang,
>
>
>> Current ltp-cap.m4 defines cap_libs when libcap has
>> cap_compare function. This function was introduced by
>> libcap-2. It is only used for the two places, and another
>> places work fines with libcap-1. So add libcap version
>> detection.
> Can't we just fix these possible compiler errors for old distros and require
> libcap v2? TCONF for very old distros looks OK for me.
> libcap-2.00 was released 12 years ago (2007), these distros does not have it:
> SLES 10 SP3 [1], RHEL-4.8 [2], Debian 4.0 [3]. Do we really want to care about
> these old distros (it looks like only RHEL is supported)?
> We also dropped libnuma v1 support (in 2c98cbbaf), v2 was released at similar
> date (2008).
Hi Peter
I sent a mail to you last Friday mentioned this problem. At the beginning, I
think it makes no sense because libcap-1 is too old. But I notices that ltp-quota.m4
has quota_v1 and quota_v2. I changes my mind.
Since we have drop libnuma v1, I agree with you that we also drop libcap v1(too old).
Also, I think we should drop quota_v1 because it is too old (since Linux 2.4.22, Q_GETINFO has
been supported in kernel).
Kind Regards,
Yang Xu
> Kind regards,
> Petr
>
> [1] https://distrowatch.com/table.php?distribution=sle&pkglist=true&version=10-sp3#pkglist
> [2] https://distrowatch.com/table.php?distribution=redhat&pkglist=true&version=rhel-4.8#pkglist
> [3] https://distrowatch.com/table.php?distribution=debian&pkglist=true&version=4.0#pkglist
>
>
next prev parent reply other threads:[~2019-05-14 5:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 7:26 [LTP] [PATCH] ltp-cap.m4: add libcap version detection && fix compiler error Yang Xu
2019-05-13 13:14 ` Petr Vorel
2019-05-14 5:24 ` xuyang [this message]
2019-05-14 12:01 ` Petr Vorel
2019-05-15 9:01 ` xuyang
2019-05-15 14:37 ` Petr Vorel
2019-05-16 6:44 ` xuyang
2019-05-16 6:52 ` [LTP] [PATCH v2] security: add missing PR_CAPBSET_READ/PR_CAPBSET_DROP check Yang Xu
2019-06-20 11:49 ` Petr Vorel
2019-06-21 2:01 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CDA5124.3070708@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.