From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/preadv2/preadv203: set mount_device flag
Date: Wed, 5 Jun 2019 13:19:27 +0800 [thread overview]
Message-ID: <5CF750DF.9040006@cn.fujitsu.com> (raw)
In-Reply-To: <20190605044215.19448-1-jencce.kernel@gmail.com>
On 2019/06/05 12:42, Murphy Zhou wrote:
> Now the tests are running in MOUNTPOINT without it mounted.
> Fails on ext2:
Hi Murphy,
Did you get EOPNOTSUPP when running preadv203 on ext2?
It seems OK to running preadv203 on ext2, as below:
--------------------------------------------------------
tst_test.c:1172: INFO: Testing on ext2
tst_mkfs.c:90: INFO: Formatting /dev/loop0 with ext2 opts='' extra opts=''
mke2fs 1.44.3 (10-July-2018)
tst_test.c:1111: INFO: Timeout per run is 0h 05m 00s
preadv203.c:145: INFO: Number of full_reads 751044, short reads 10, zero
len reads 0, EAGAIN(s) 67021
preadv203.c:180: INFO: Number of writes 1087560
preadv203.c:194: INFO: Cache dropped 149 times
preadv203.c:223: PASS: Got some EAGAIN
-------------------------------------------------------
BTW: I got EOPNOTSUPP when running preadv203 on tmpfs. :-)
Best Regards,
Xiao Yang
> preadv203.c does not set mount_device, which makes BROK:
> preadv203.c:122: BROK: preadv2() failed: EOPNOTSUPP
>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
> ---
> testcases/kernel/syscalls/preadv2/preadv203.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/syscalls/preadv2/preadv203.c b/testcases/kernel/syscalls/preadv2/preadv203.c
> index 810d1e8db..e4f68a51b 100644
> --- a/testcases/kernel/syscalls/preadv2/preadv203.c
> +++ b/testcases/kernel/syscalls/preadv2/preadv203.c
> @@ -261,6 +261,7 @@ static struct tst_test test = {
> .cleanup = cleanup,
> .test_all = verify_preadv2,
> .mntpoint = MNTPOINT,
> + .mount_device = 1,
> .all_filesystems = 1,
> .needs_tmpdir = 1,
> .needs_root = 1,
next prev parent reply other threads:[~2019-06-05 5:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 7:40 [LTP] [PATCH] lib/tst_test.c: set mount_device amd format_device of all_filesystems is set Murphy Zhou
2019-06-04 8:09 ` Xiao Yang
2019-06-04 8:23 ` Murphy Zhou
2019-06-05 4:42 ` [LTP] [PATCH v2] syscalls/preadv2/preadv203: set mount_device flag Murphy Zhou
2019-06-05 5:19 ` Xiao Yang [this message]
2019-06-05 5:27 ` Murphy Zhou
2019-06-05 5:33 ` [LTP] [PATCH v3] " Murphy Zhou
2019-06-05 5:55 ` Xiao Yang
2019-06-05 14:06 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CF750DF.9040006@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.