All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] scenario_groups/default: run the kernel_misc test after the cve test
Date: Mon, 1 Jul 2019 14:27:45 +0800	[thread overview]
Message-ID: <5D19A7E1.10607@cn.fujitsu.com> (raw)
In-Reply-To: <20190628103900.10113-1-po-hsu.lin@canonical.com>

Hi,

Your patch just workarounds the issue for now, because it still happens 
if a new test designed to taint
kernel is added to the group before cve group in future.

Could we save the value of tainted before running block_dev and then 
restore it after running block_dev?

Best Regards,
Xiao Yang
On 2019/06/28 18:39, Po-Hsu Lin wrote:
> The block_dev test in kernel_misc will taint kernel with a warning flag,
> this is an expected behaviour.
>
> However, if you run the cve-2017-17053 after it, as the test is looking
> for a warning / died flag for a tainted kernel, it will cause false
> alarm with:
>    tst_taint.c:88: BROK: Kernel is already tainted: 14849
>
> The kernel_misc test was executed before the cve test in the default
> test plan. Move the kernel_misc test to the end of the list to
> workaround this issue.
>
> Signed-off-by: Po-Hsu Lin<po-hsu.lin@canonical.com>
> ---
>   scenario_groups/default | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scenario_groups/default b/scenario_groups/default
> index 1f3e5b27f..e5b34782c 100644
> --- a/scenario_groups/default
> +++ b/scenario_groups/default
> @@ -22,7 +22,6 @@ power_management_tests
>   hugetlb
>   commands
>   hyperthreading
> -kernel_misc
>   fs_ext4
>   can
>   cpuhotplug
> @@ -30,3 +29,4 @@ net.ipv6_lib
>   input
>   cve
>   crypto
> +kernel_misc




  reply	other threads:[~2019-07-01  6:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 10:39 [LTP] [PATCH] scenario_groups/default: run the kernel_misc test after the cve test Po-Hsu Lin
2019-07-01  6:27 ` Xiao Yang [this message]
2019-07-01  6:58   ` Po-Hsu Lin
2019-07-01  7:12     ` Xiao Yang
2019-07-02 13:00       ` Cyril Hrubis
2019-07-02 13:05   ` Cyril Hrubis
2019-07-02 16:40     ` Po-Hsu Lin
2019-07-02 17:19       ` Cyril Hrubis
2019-07-02 13:04 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D19A7E1.10607@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.