From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 4B173E00D30; Thu, 25 Jul 2019 18:57:49 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, * medium trust * [147.11.1.11 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 65ED0E00C46 for ; Thu, 25 Jul 2019 18:57:43 -0700 (PDT) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id x6Q1vg5Y026088 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 25 Jul 2019 18:57:42 -0700 (PDT) Received: from [128.224.162.170] (128.224.162.170) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.468.0; Thu, 25 Jul 2019 18:57:41 -0700 To: Bruce Ashfield , "Hatle, Mark" , Hongxu Jia References: <1564026221-359201-1-git-send-email-mingli.yu@windriver.com> From: "Yu, Mingli" Message-ID: <5D3A5EBF.9080200@windriver.com> Date: Fri, 26 Jul 2019 10:00:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [128.224.162.170] Cc: meta-virtualization@yoctoproject.org Subject: Re: [PATCH] meta-virtualization: add layer depends on selinux X-BeenThere: meta-virtualization@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Discussion of layer enabling hypervisor, virtualization tool stack, and cloud support" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jul 2019 01:57:49 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 2019年07月26日 02:28, Bruce Ashfield wrote: > On Wed, Jul 24, 2019 at 11:43 PM wrote: >> >> From: Mingli Yu >> >> Since cri-o of meta-virtualization depends on >> libselinux which comes from selinux, add missing >> layer depends back. > > This is already covered in the README. Since cri-o is optional, I > didn't want it to be a hard depends. Not matter cri-o is optional or not, but first the cri-o recipe indeed exists in meta-virtualization layer until now as ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and second there is below logic in ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and clearly it depends on libselinux. DEPENDS = " \ glib-2.0 \ btrfs-tools \ gpgme \ ostree \ libdevmapper \ libseccomp \ libselinux \ " So we should add the layer depends selinux(libselinux in selinux layer) for meta-virtualization layer, otherwise there comes below error when do yocto compliance check: ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it) ERROR: Required build target 'meta-world-pkgdata' has no buildable providers. Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux' ] Thanks, > > Required for cri-o: > URI: git://github.com/advancedtelematic/meta-updater > URI: git://git.yoctoproject.org/meta-selinux > URI: git://git.yoctoproject.org/meta-security > branch: master > revision: HEAD > prio: default > > > I haven't seen a way to do a conditional depends .. has anyone else ? > > Bruce > >> >> Signed-off-by: Mingli Yu >> --- >> conf/layer.conf | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/conf/layer.conf b/conf/layer.conf >> index be1f222..23efcb8 100644 >> --- a/conf/layer.conf >> +++ b/conf/layer.conf >> @@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \ >> networking-layer \ >> filesystems-layer \ >> meta-python \ >> + selinux \ >> " >> >> # webserver: naigos requires apache2 >> -- >> 2.7.4 >> > >