From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Subject: Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes Date: Thu, 01 Aug 2019 12:20:08 +0200 Message-ID: <5D42BCD8.2050708@bfs.de> References: <20190801083941.4230-1-colin.king@canonical.com> Reply-To: wharms@bfs.de Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190801083941.4230-1-colin.king@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kernel-janitors@vger.kernel.org Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Colin King , Evan Quan , Rex Zhu , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5p?= =?UTF-8?B?Zw==?= List-Id: amd-gfx.lists.freedesktop.org CgpBbSAwMS4wOC4yMDE5IDEwOjM5LCBzY2hyaWViIENvbGluIEtpbmc6Cj4gRnJvbTogQ29saW4g SWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KPiAKPiBUaGVyZSBhcmUgYSBmZXcg c3BlbGxpbmcgbWlzdGFrZXMgInVua25vdyIgLT4gInVua25vd24iIGFuZAo+ICJlbmFiZWxkIiAt PiAiZW5hYmxlZCIuIEZpeCB0aGVzZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2lu ZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1k L3Bvd2VycGxheS9hbWRncHVfc211LmMgfCA2ICsrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL3Bvd2VycGxheS9hbWRncHVfc211LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bv d2VycGxheS9hbWRncHVfc211LmMKPiBpbmRleCAxM2IyYzhhNjAyMzIuLmQwMjlhOTllNjAwZSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9hbWRncHVfc211LmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9hbWRncHVfc211LmMKPiBAQCAt MzksNyArMzksNyBAQCBzdGF0aWMgY29uc3QgY2hhciogX19zbXVfbWVzc2FnZV9uYW1lc1tdID0g ewo+ICBjb25zdCBjaGFyICpzbXVfZ2V0X21lc3NhZ2VfbmFtZShzdHJ1Y3Qgc211X2NvbnRleHQg KnNtdSwgZW51bSBzbXVfbWVzc2FnZV90eXBlIHR5cGUpCj4gIHsKPiAgCWlmICh0eXBlIDwgMCB8 fCB0eXBlID4gU01VX01TR19NQVhfQ09VTlQpCj4gLQkJcmV0dXJuICJ1bmtub3cgc211IG1lc3Nh Z2UiOwo+ICsJCXJldHVybiAidW5rbm93biBzbXUgbWVzc2FnZSI7Cj4gIAlyZXR1cm4gX19zbXVf bWVzc2FnZV9uYW1lc1t0eXBlXTsKPiAgfQo+ICAKPiBAQCAtNTIsNyArNTIsNyBAQCBzdGF0aWMg Y29uc3QgY2hhciogX19zbXVfZmVhdHVyZV9uYW1lc1tdID0gewo+ICBjb25zdCBjaGFyICpzbXVf Z2V0X2ZlYXR1cmVfbmFtZShzdHJ1Y3Qgc211X2NvbnRleHQgKnNtdSwgZW51bSBzbXVfZmVhdHVy ZV9tYXNrIGZlYXR1cmUpCj4gIHsKPiAgCWlmIChmZWF0dXJlIDwgMCB8fCBmZWF0dXJlID4gU01V X0ZFQVRVUkVfQ09VTlQpCj4gLQkJcmV0dXJuICJ1bmtub3cgc211IGZlYXR1cmUiOwo+ICsJCXJl dHVybiAidW5rbm93biBzbXUgZmVhdHVyZSI7Cj4gIAlyZXR1cm4gX19zbXVfZmVhdHVyZV9uYW1l c1tmZWF0dXJlXTsKPiAgfQo+ICAKPiBAQCAtNzksNyArNzksNyBAQCBzaXplX3Qgc211X3N5c19n ZXRfcHBfZmVhdHVyZV9tYXNrKHN0cnVjdCBzbXVfY29udGV4dCAqc211LCBjaGFyICpidWYpCj4g IAkJCSAgICAgICBjb3VudCsrLAo+ICAJCQkgICAgICAgc211X2dldF9mZWF0dXJlX25hbWUoc211 LCBpKSwKPiAgCQkJICAgICAgIGZlYXR1cmVfaW5kZXgsCj4gLQkJCSAgICAgICAhIXNtdV9mZWF0 dXJlX2lzX2VuYWJsZWQoc211LCBpKSA/ICJlbmFiZWxkIiA6ICJkaXNhYmxlZCIpOwo+ICsJCQkg ICAgICAgISFzbXVfZmVhdHVyZV9pc19lbmFibGVkKHNtdSwgaSkgPyAiZW5hYmxlZCIgOiAiZGlz YWJsZWQiKTsKCmkgYW0gd29uZGVyaW5nLAppcyB0aGF0ICEhIHJlYWxseSBuZWVkZWQgaW4gZnJv bnQgb2Ygc211X2ZlYXR1cmVfaXNfZW5hYmxlZCA/CgpyZSwKIHdoCgo+ICAJfQo+ICAKPiAgZmFp bGVkOgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Thu, 01 Aug 2019 10:20:08 +0000 Subject: Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes Message-Id: <5D42BCD8.2050708@bfs.de> List-Id: References: <20190801083941.4230-1-colin.king@canonical.com> In-Reply-To: <20190801083941.4230-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Colin King , Evan Quan , Rex Zhu , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5p?= =?UTF-8?B?Zw==?= Am 01.08.2019 10:39, schrieb Colin King: > From: Colin Ian King > > There are a few spelling mistakes "unknow" -> "unknown" and > "enabeld" -> "enabled". Fix these. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index 13b2c8a60232..d029a99e600e 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = { > const char *smu_get_message_name(struct smu_context *smu, enum smu_message_type type) > { > if (type < 0 || type > SMU_MSG_MAX_COUNT) > - return "unknow smu message"; > + return "unknown smu message"; > return __smu_message_names[type]; > } > > @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = { > const char *smu_get_feature_name(struct smu_context *smu, enum smu_feature_mask feature) > { > if (feature < 0 || feature > SMU_FEATURE_COUNT) > - return "unknow smu feature"; > + return "unknown smu feature"; > return __smu_feature_names[feature]; > } > > @@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, char *buf) > count++, > smu_get_feature_name(smu, i), > feature_index, > - !!smu_feature_is_enabled(smu, i) ? "enabeld" : "disabled"); > + !!smu_feature_is_enabled(smu, i) ? "enabled" : "disabled"); i am wondering, is that !! really needed in front of smu_feature_is_enabled ? re, wh > } > > failed: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3FFC19759 for ; Thu, 1 Aug 2019 10:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9782A214DA for ; Thu, 1 Aug 2019 10:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bfs.de header.i=@bfs.de header.b="oBFOXaei" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730645AbfHAKUT (ORCPT ); Thu, 1 Aug 2019 06:20:19 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:52385 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728060AbfHAKUT (ORCPT ); Thu, 1 Aug 2019 06:20:19 -0400 Received: from mail-fr.bfs.de (mail-fr.bfs.de [10.177.18.200]) by mx01-fr.bfs.de (Postfix) with ESMTPS id 9D2E020361; Thu, 1 Aug 2019 12:20:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bfs.de; s=dkim201901; t=1564654811; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y2Sv8l3MwtDovEkgothzWo49YW1bV4SU10NaWrHnhr4=; b=oBFOXaeihhqLNN72BtKixNI7HSZheL/xsvrWl6NjVcuCqffp8bwz6cyl/gDwHo35vngRqw qRVpEHmFbqjY8qcMerui6gQ37jVB4dIjjDfjBSwCBotxBgxPM3iz/pjGDQx4J6NF6t6ut9 sTMi6c49ByDwBXUTqDUcSE4QgZlz1GS9pmuFJCSgHGMrB1dDmjyQvZQLyZi3upxsgiKDUk ivxZtDKnDXwcSND2JeYfM1akSC4kD4jJN3ARaoDr+Fthn5wdum0Vf7rqaTy3+9P/wwmStt Hxzj2Gvl3YfgWzNG6NM/a/6n0BQA/Af4KiK/QA50Yql9Up5tjh3MylOyDKgFRA== Received: from [134.92.181.33] (unknown [134.92.181.33]) by mail-fr.bfs.de (Postfix) with ESMTPS id E7E53BEEBD; Thu, 1 Aug 2019 12:20:09 +0200 (CEST) Message-ID: <5D42BCD8.2050708@bfs.de> Date: Thu, 01 Aug 2019 12:20:08 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: kernel-janitors@vger.kernel.org CC: Colin King , Rex Zhu , Evan Quan , Alex Deucher , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5p?= =?UTF-8?B?Zw==?= , David Zhou , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes References: <20190801083941.4230-1-colin.king@canonical.com> In-Reply-To: <20190801083941.4230-1-colin.king@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: mx01-fr.bfs.de X-Spamd-Result: default: False [-3.10 / 7.00]; HAS_REPLYTO(0.00)[wharms@bfs.de]; TO_DN_SOME(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 01.08.2019 10:39, schrieb Colin King: > From: Colin Ian King > > There are a few spelling mistakes "unknow" -> "unknown" and > "enabeld" -> "enabled". Fix these. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index 13b2c8a60232..d029a99e600e 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = { > const char *smu_get_message_name(struct smu_context *smu, enum smu_message_type type) > { > if (type < 0 || type > SMU_MSG_MAX_COUNT) > - return "unknow smu message"; > + return "unknown smu message"; > return __smu_message_names[type]; > } > > @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = { > const char *smu_get_feature_name(struct smu_context *smu, enum smu_feature_mask feature) > { > if (feature < 0 || feature > SMU_FEATURE_COUNT) > - return "unknow smu feature"; > + return "unknown smu feature"; > return __smu_feature_names[feature]; > } > > @@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, char *buf) > count++, > smu_get_feature_name(smu, i), > feature_index, > - !!smu_feature_is_enabled(smu, i) ? "enabeld" : "disabled"); > + !!smu_feature_is_enabled(smu, i) ? "enabled" : "disabled"); i am wondering, is that !! really needed in front of smu_feature_is_enabled ? re, wh > } > > failed: