From: Zhou Wang <wangzhou1@hisilicon.com>
To: kbuild test robot <lkp@intel.com>
Cc: <kbuild-all@01.org>, <linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Shiju Jose <shiju.jose@huawei.com>,
"Kenneth Lee" <liguozhu@hisilicon.com>,
Hao Fang <fanghao11@huawei.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [cryptodev:master 124/144] drivers/crypto/hisilicon/qm.c:338:2: note: in expansion of macro 'dev_dbg'
Date: Mon, 12 Aug 2019 15:16:56 +0800 [thread overview]
Message-ID: <5D511268.80607@hisilicon.com> (raw)
In-Reply-To: <201908092010.VKcbSwFV%lkp@intel.com>
On 2019/8/9 20:17, kbuild test robot wrote:
> tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: ec9c7d19336ee98ecba8de80128aa405c45feebb
> commit: 62c455ca853e3e352e465d66a6cc39f1f88caa60 [124/144] crypto: hisilicon - add HiSilicon ZIP accelerator support
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 7.4.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 62c455ca853e3e352e465d66a6cc39f1f88caa60
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=sh
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from include/linux/printk.h:332:0,
> from include/linux/kernel.h:15,
> from include/asm-generic/bug.h:18,
> from arch/sh/include/asm/bug.h:112,
> from include/linux/bug.h:5,
> from arch/sh/include/asm/uncached.h:5,
> from arch/sh/include/asm/page.h:49,
> from drivers/crypto/hisilicon/qm.c:3:
> drivers/crypto/hisilicon/qm.c: In function 'qm_mb':
>>> drivers/crypto/hisilicon/qm.c:338:26: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
> dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%llx\n", queue,
Should be %pad for dma, I will fix this.
> ^
> include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
> func(&id, ##__VA_ARGS__); \
> ^~~~~~~~~~~
> include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
> _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> ^~~~~~~~~~~~~~~~~~
> include/linux/device.h:1503:2: note: in expansion of macro 'dynamic_dev_dbg'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~
> include/linux/device.h:1503:23: note: in expansion of macro 'dev_fmt'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~
>>> drivers/crypto/hisilicon/qm.c:338:2: note: in expansion of macro 'dev_dbg'
> dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%llx\n", queue,
> ^~~~~~~
> drivers/crypto/hisilicon/qm.c: In function 'qm_irq_register':
>>> drivers/crypto/hisilicon/qm.c:583:20: error: implicit declaration of function 'pci_irq_vector'; did you mean 'rcu_irq_enter'? [-Werror=implicit-function-declaration]
> ret = request_irq(pci_irq_vector(pdev, QM_EQ_EVENT_IRQ_VECTOR),
> ^~~~~~~~~~~~~~
> rcu_irq_enter
> In file included from include/linux/printk.h:332:0,
> from include/linux/kernel.h:15,
> from include/asm-generic/bug.h:18,
> from arch/sh/include/asm/bug.h:112,
> from include/linux/bug.h:5,
> from arch/sh/include/asm/uncached.h:5,
> from arch/sh/include/asm/page.h:49,
> from drivers/crypto/hisilicon/qm.c:3:
> drivers/crypto/hisilicon/qm.c: In function 'hisi_qm_create_qp':
>>> drivers/crypto/hisilicon/qm.c:879:16: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type 'size_t {aka unsigned int}' [-Wformat=]
> dev_dbg(dev, "allocate qp dma buf(va=%pK, dma=%pad, size=%lx)\n",
Should be size=%zx, will fix this.
> ^
> include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
> func(&id, ##__VA_ARGS__); \
> ^~~~~~~~~~~
> include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
> _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> ^~~~~~~~~~~~~~~~~~
> include/linux/device.h:1503:2: note: in expansion of macro 'dynamic_dev_dbg'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~
> include/linux/device.h:1503:23: note: in expansion of macro 'dev_fmt'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~
> drivers/crypto/hisilicon/qm.c:879:3: note: in expansion of macro 'dev_dbg'
> dev_dbg(dev, "allocate qp dma buf(va=%pK, dma=%pad, size=%lx)\n",
> ^~~~~~~
> drivers/crypto/hisilicon/qm.c: In function 'hisi_qm_init':
>>> drivers/crypto/hisilicon/qm.c:1156:8: error: implicit declaration of function 'pci_enable_device_mem'; did you mean 'pci_enable_device'? [-Werror=implicit-function-declaration]
> ret = pci_enable_device_mem(pdev);
> ^~~~~~~~~~~~~~~~~~~~~
> pci_enable_device
>>> drivers/crypto/hisilicon/qm.c:1162:8: error: implicit declaration of function 'pci_request_mem_regions'; did you mean 'pci_request_regions'? [-Werror=implicit-function-declaration]
> ret = pci_request_mem_regions(pdev, qm->dev_name);
> ^~~~~~~~~~~~~~~~~~~~~~~
> pci_request_regions
>>> drivers/crypto/hisilicon/qm.c:1185:8: error: implicit declaration of function 'pci_alloc_irq_vectors'; did you mean 'pci_alloc_consistent'? [-Werror=implicit-function-declaration]
> ret = pci_alloc_irq_vectors(pdev, num_vec, num_vec, PCI_IRQ_MSI);
> ^~~~~~~~~~~~~~~~~~~~~
> pci_alloc_consistent
>>> drivers/crypto/hisilicon/qm.c:1185:54: error: 'PCI_IRQ_MSI' undeclared (first use in this function); did you mean 'IRQ_MSK'?
> ret = pci_alloc_irq_vectors(pdev, num_vec, num_vec, PCI_IRQ_MSI);
> ^~~~~~~~~~~
> IRQ_MSK
> drivers/crypto/hisilicon/qm.c:1185:54: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/crypto/hisilicon/qm.c:1201:2: error: implicit declaration of function 'pci_free_irq_vectors'; did you mean 'pci_free_consistent'? [-Werror=implicit-function-declaration]
> pci_free_irq_vectors(pdev);
> ^~~~~~~~~~~~~~~~~~~~
> pci_free_consistent
>>> drivers/crypto/hisilicon/qm.c:1205:2: error: implicit declaration of function 'pci_release_mem_regions'; did you mean 'pci_release_regions'? [-Werror=implicit-function-declaration]
> pci_release_mem_regions(pdev);
> ^~~~~~~~~~~~~~~~~~~~~~~
> pci_release_regions
> In file included from include/linux/printk.h:332:0,
> from include/linux/kernel.h:15,
> from include/asm-generic/bug.h:18,
> from arch/sh/include/asm/bug.h:112,
> from include/linux/bug.h:5,
> from arch/sh/include/asm/uncached.h:5,
> from arch/sh/include/asm/page.h:49,
> from drivers/crypto/hisilicon/qm.c:3:
> drivers/crypto/hisilicon/qm.c: In function 'hisi_qm_start':
> drivers/crypto/hisilicon/qm.c:1425:16: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type 'size_t {aka unsigned int}' [-Wformat=]
> dev_dbg(dev, "allocate qm dma buf(va=%pK, dma=%pad, size=%lx)\n",
> ^
> include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
> func(&id, ##__VA_ARGS__); \
> ^~~~~~~~~~~
> include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
> _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> ^~~~~~~~~~~~~~~~~~
> include/linux/device.h:1503:2: note: in expansion of macro 'dynamic_dev_dbg'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~
> include/linux/device.h:1503:23: note: in expansion of macro 'dev_fmt'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~
> drivers/crypto/hisilicon/qm.c:1425:3: note: in expansion of macro 'dev_dbg'
> dev_dbg(dev, "allocate qm dma buf(va=%pK, dma=%pad, size=%lx)\n",
should be size=%zx.
> ^~~~~~~
> cc1: some warnings being treated as errors
>
> vim +/dev_dbg +338 drivers/crypto/hisilicon/qm.c
>
> 263c9959c9376e Zhou Wang 2019-08-02 331
> 263c9959c9376e Zhou Wang 2019-08-02 332 static int qm_mb(struct hisi_qm *qm, u8 cmd, dma_addr_t dma_addr, u16 queue,
> 263c9959c9376e Zhou Wang 2019-08-02 333 bool op)
> 263c9959c9376e Zhou Wang 2019-08-02 334 {
> 263c9959c9376e Zhou Wang 2019-08-02 335 struct qm_mailbox mailbox;
> 263c9959c9376e Zhou Wang 2019-08-02 336 int ret = 0;
> 263c9959c9376e Zhou Wang 2019-08-02 337
> 263c9959c9376e Zhou Wang 2019-08-02 @338 dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%llx\n", queue,
> 263c9959c9376e Zhou Wang 2019-08-02 339 cmd, dma_addr);
> 263c9959c9376e Zhou Wang 2019-08-02 340
> 263c9959c9376e Zhou Wang 2019-08-02 341 mailbox.w0 = cmd |
> 263c9959c9376e Zhou Wang 2019-08-02 342 (op ? 0x1 << QM_MB_OP_SHIFT : 0) |
> 263c9959c9376e Zhou Wang 2019-08-02 343 (0x1 << QM_MB_BUSY_SHIFT);
> 263c9959c9376e Zhou Wang 2019-08-02 344 mailbox.queue_num = queue;
> 263c9959c9376e Zhou Wang 2019-08-02 345 mailbox.base_l = lower_32_bits(dma_addr);
> 263c9959c9376e Zhou Wang 2019-08-02 346 mailbox.base_h = upper_32_bits(dma_addr);
> 263c9959c9376e Zhou Wang 2019-08-02 347 mailbox.rsvd = 0;
> 263c9959c9376e Zhou Wang 2019-08-02 348
> 263c9959c9376e Zhou Wang 2019-08-02 349 mutex_lock(&qm->mailbox_lock);
> 263c9959c9376e Zhou Wang 2019-08-02 350
> 263c9959c9376e Zhou Wang 2019-08-02 351 if (unlikely(qm_wait_mb_ready(qm))) {
> 263c9959c9376e Zhou Wang 2019-08-02 352 ret = -EBUSY;
> 263c9959c9376e Zhou Wang 2019-08-02 353 dev_err(&qm->pdev->dev, "QM mailbox is busy to start!\n");
> 263c9959c9376e Zhou Wang 2019-08-02 354 goto busy_unlock;
> 263c9959c9376e Zhou Wang 2019-08-02 355 }
> 263c9959c9376e Zhou Wang 2019-08-02 356
> 263c9959c9376e Zhou Wang 2019-08-02 357 qm_mb_write(qm, &mailbox);
> 263c9959c9376e Zhou Wang 2019-08-02 358
> 263c9959c9376e Zhou Wang 2019-08-02 359 if (unlikely(qm_wait_mb_ready(qm))) {
> 263c9959c9376e Zhou Wang 2019-08-02 360 ret = -EBUSY;
> 263c9959c9376e Zhou Wang 2019-08-02 361 dev_err(&qm->pdev->dev, "QM mailbox operation timeout!\n");
> 263c9959c9376e Zhou Wang 2019-08-02 362 goto busy_unlock;
> 263c9959c9376e Zhou Wang 2019-08-02 363 }
> 263c9959c9376e Zhou Wang 2019-08-02 364
> 263c9959c9376e Zhou Wang 2019-08-02 365 busy_unlock:
> 263c9959c9376e Zhou Wang 2019-08-02 366 mutex_unlock(&qm->mailbox_lock);
> 263c9959c9376e Zhou Wang 2019-08-02 367
> 263c9959c9376e Zhou Wang 2019-08-02 368 return ret;
> 263c9959c9376e Zhou Wang 2019-08-02 369 }
> 263c9959c9376e Zhou Wang 2019-08-02 370
>
> :::::: The code at line 338 was first introduced by commit
> :::::: 263c9959c9376ec0217d6adc61222a53469eed3c crypto: hisilicon - add queue management driver for HiSilicon QM module
>
> :::::: TO: Zhou Wang <wangzhou1@hisilicon.com>
> :::::: CC: Herbert Xu <herbert@gondor.apana.org.au>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
prev parent reply other threads:[~2019-08-12 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 12:17 [cryptodev:master 124/144] drivers/crypto/hisilicon/qm.c:338:2: note: in expansion of macro 'dev_dbg' kbuild test robot
2019-08-12 7:16 ` Zhou Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D511268.80607@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.garry@huawei.com \
--cc=kbuild-all@01.org \
--cc=liguozhu@hisilicon.com \
--cc=linux-crypto@vger.kernel.org \
--cc=lkp@intel.com \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.