From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D07DAC3A5A0 for ; Mon, 19 Aug 2019 12:59:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACA6F205C9 for ; Mon, 19 Aug 2019 12:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbfHSM77 (ORCPT ); Mon, 19 Aug 2019 08:59:59 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5156 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727128AbfHSM77 (ORCPT ); Mon, 19 Aug 2019 08:59:59 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id ACA9CA8B24C2C0ADD55A; Mon, 19 Aug 2019 20:59:55 +0800 (CST) Received: from [127.0.0.1] (10.57.101.250) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 19 Aug 2019 20:59:49 +0800 Subject: Re: [PATCH v2] gpio: pl061: Fix the issue failed to register the ACPI interrtupion To: Andy Shevchenko References: <1565946336-20080-1-git-send-email-xuwei5@hisilicon.com> CC: "open list:GPIO SUBSYSTEM" , "Linux Kernel Mailing List" , linux-arm Mailing List , Linus Walleij , "Rafael J. Wysocki" , "Len Brown" , Mika Westerberg , Linuxarm , , Jonathan Cameron , John Garry , , , , , , , huangdaode From: Wei Xu Message-ID: <5D5A9D43.4040508@hisilicon.com> Date: Mon, 19 Aug 2019 20:59:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.101.250] X-CFilter-Loop: Reflected Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Andy, Thanks! On 2019/8/16 21:40, Andy Shevchenko wrote: > On Fri, Aug 16, 2019 at 12:07 PM Wei Xu wrote: >> Invoke acpi_gpiochip_request_interrupts after the acpi data has been >> attached to the pl061 acpi node to register interruption. >> >> Otherwise it will be failed to register interruption for the ACPI case. >> Because in the gpiochip_add_data_with_key, acpi_gpiochip_add is invoked >> after gpiochip_add_irqchip but at that time the acpi data has not been >> attached yet. >> 2. cat /proc/interrupts in the guest console: >> >> estuary:/$ cat /proc/interrupts >> CPU0 >> 2: 3228 GICv3 27 Level arch_timer >> 4: 15 GICv3 33 Level uart-pl011 >> 42: 0 GICv3 23 Level arm-pmu >> IPI0: 0 Rescheduling interrupts >> IPI1: 0 Function call interrupts >> IPI2: 0 CPU stop interrupts >> IPI3: 0 CPU stop (for crash dump) interrupts >> IPI4: 0 Timer broadcast interrupts >> IPI5: 0 IRQ work interrupts >> IPI6: 0 CPU wake-up interrupts >> Err: 0 >> >> But on QEMU v3.0.0 and Linux kernel v5.2.0-rc7, pl061 interruption is >> there as below: >> >> estuary:/$ cat /proc/interrupts >> CPU0 >> 2: 2648 GICv3 27 Level arch_timer >> 4: 12 GICv3 33 Level uart-pl011 >> 42: 0 GICv3 23 Level arm-pmu >> 43: 0 ARMH0061:00 3 Edge ACPI:Event >> IPI0: 0 Rescheduling interrupts >> IPI1: 0 Function call interrupts >> IPI2: 0 CPU stop interrupts >> IPI3: 0 CPU stop (for crash dump) interrupts >> IPI4: 0 Timer broadcast interrupts >> IPI5: 0 IRQ work interrupts >> IPI6: 0 CPU wake-up interrupts >> Err: 0 > In above show only affected line. OK. Will update it in v3. >> And the whole dmesg log on Linux kernel v5.2.0-rc7 is as below: > NO! > Please, remove this huge noise! Sorry for the noise! I will drop it in v3. Best Regards, Wei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B33DC3A5A0 for ; Mon, 19 Aug 2019 13:00:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AA1E2087B for ; Mon, 19 Aug 2019 13:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p49iSIZ8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AA1E2087B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vE16ZhxnAG31C+oAzr4uhHWMagroZ0Ajl571wxWzfho=; b=p49iSIZ85qdv1/83V8TXxdB/Y X+BgblUGp7MVXB3ZKadavumEJDugf9NCektDQyMUPVwBv7uUgt2liLiXEH7qFC9DMm1uBwXCJhzNW 5R3O5wxSTUcpOeX5A/TCf+f+86DYt6vU+Gy0vRsIbgK1ALJs2R2U8rvngGMyb+4c/6A6ib8yXS2CL 26LimeQ4BXJgYvqx9cvWd6/MFJw4D9pEtBIoA4HvgwYdmiz1Ajy26zu8jTqerS+1bCYdaIcEZrWr7 wh+h+er5kbJODMbwUkWio3vCZZJfqtKW5gHFttLjkv1Cem/NxAXcOHCLzktXRDEznlnxQWVhTku9N ttt8jh8Tw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzhGd-0000Tv-Qq; Mon, 19 Aug 2019 13:00:11 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzhGa-0007io-Lz for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 13:00:10 +0000 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id ACA9CA8B24C2C0ADD55A; Mon, 19 Aug 2019 20:59:55 +0800 (CST) Received: from [127.0.0.1] (10.57.101.250) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 19 Aug 2019 20:59:49 +0800 Subject: Re: [PATCH v2] gpio: pl061: Fix the issue failed to register the ACPI interrtupion To: Andy Shevchenko References: <1565946336-20080-1-git-send-email-xuwei5@hisilicon.com> From: Wei Xu Message-ID: <5D5A9D43.4040508@hisilicon.com> Date: Mon, 19 Aug 2019 20:59:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.57.101.250] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_060008_891704_AEA5802C X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: salil.mehta@huawei.com, jinying@hisilicon.com, tangkunshan@huawei.com, liguozhu@hisilicon.com, Linus Walleij , John Garry , "Rafael J. Wysocki" , Linux Kernel Mailing List , shameerali.kolothum.thodi@huawei.com, Linuxarm , "open list:GPIO SUBSYSTEM" , huangdaode , Jonathan Cameron , shiju.jose@huawei.com, Mika Westerberg , zhangyi.ac@huawei.com, linux-arm Mailing List , Len Brown Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, Thanks! On 2019/8/16 21:40, Andy Shevchenko wrote: > On Fri, Aug 16, 2019 at 12:07 PM Wei Xu wrote: >> Invoke acpi_gpiochip_request_interrupts after the acpi data has been >> attached to the pl061 acpi node to register interruption. >> >> Otherwise it will be failed to register interruption for the ACPI case. >> Because in the gpiochip_add_data_with_key, acpi_gpiochip_add is invoked >> after gpiochip_add_irqchip but at that time the acpi data has not been >> attached yet. >> 2. cat /proc/interrupts in the guest console: >> >> estuary:/$ cat /proc/interrupts >> CPU0 >> 2: 3228 GICv3 27 Level arch_timer >> 4: 15 GICv3 33 Level uart-pl011 >> 42: 0 GICv3 23 Level arm-pmu >> IPI0: 0 Rescheduling interrupts >> IPI1: 0 Function call interrupts >> IPI2: 0 CPU stop interrupts >> IPI3: 0 CPU stop (for crash dump) interrupts >> IPI4: 0 Timer broadcast interrupts >> IPI5: 0 IRQ work interrupts >> IPI6: 0 CPU wake-up interrupts >> Err: 0 >> >> But on QEMU v3.0.0 and Linux kernel v5.2.0-rc7, pl061 interruption is >> there as below: >> >> estuary:/$ cat /proc/interrupts >> CPU0 >> 2: 2648 GICv3 27 Level arch_timer >> 4: 12 GICv3 33 Level uart-pl011 >> 42: 0 GICv3 23 Level arm-pmu >> 43: 0 ARMH0061:00 3 Edge ACPI:Event >> IPI0: 0 Rescheduling interrupts >> IPI1: 0 Function call interrupts >> IPI2: 0 CPU stop interrupts >> IPI3: 0 CPU stop (for crash dump) interrupts >> IPI4: 0 Timer broadcast interrupts >> IPI5: 0 IRQ work interrupts >> IPI6: 0 CPU wake-up interrupts >> Err: 0 > In above show only affected line. OK. Will update it in v3. >> And the whole dmesg log on Linux kernel v5.2.0-rc7 is as below: > NO! > Please, remove this huge noise! Sorry for the noise! I will drop it in v3. Best Regards, Wei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel