From: Wei Xu <xuwei5@hisilicon.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Salil Mehta <salil.mehta@huawei.com>, <jinying@hisilicon.com>,
Tangkunshan <tangkunshan@huawei.com>,
"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>,
"John Garry" <john.garry@huawei.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Shameerali Kolothum Thodi"
<shameerali.kolothum.thodi@huawei.com>,
Linuxarm <linuxarm@huawei.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
huangdaode <huangdaode@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
Zhangyi ac <zhangyi.ac@huawei.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion
Date: Tue, 20 Aug 2019 17:27:49 +0800 [thread overview]
Message-ID: <5D5BBD15.4030507@hisilicon.com> (raw)
In-Reply-To: <CACRpkdZFwANp-+fSmPPENLoh2Za2-fyf+aZ0VK79AnyRJs1H3A@mail.gmail.com>
Hi Linus,
On 2019/8/20 16:01, Linus Walleij wrote:
> On Mon, Aug 19, 2019 at 3:29 PM Wei Xu <xuwei5@hisilicon.com> wrote:
>
>> Invoke acpi_gpiochip_request_interrupts after the acpi data has been
>> attached to the pl061 acpi node to register interruption.
>>
>> Otherwise it will be failed to register interruption for the ACPI case.
>> Because in the gpiochip_add_data_with_key, acpi_gpiochip_add is invoked
>> after gpiochip_add_irqchip but at that time the acpi data has not been
>> attached yet.
> We need to fix this problem in gpiochip_add_data_with_key() instead.
Thanks!
Best Regards,
Wei
> Yours,
> Linus Walleij
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Xu <xuwei5@hisilicon.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Salil Mehta <salil.mehta@huawei.com>,
jinying@hisilicon.com, Tangkunshan <tangkunshan@huawei.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
John Garry <john.garry@huawei.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Linuxarm <linuxarm@huawei.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
huangdaode <huangdaode@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Len Brown <lenb@kernel.org>,
"Liguozhu \(Kenneth\)" <liguozhu@hisilicon.com>,
Zhangyi ac <zhangyi.ac@huawei.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Shiju Jose <shiju.jose@huawei.com>
Subject: Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion
Date: Tue, 20 Aug 2019 17:27:49 +0800 [thread overview]
Message-ID: <5D5BBD15.4030507@hisilicon.com> (raw)
In-Reply-To: <CACRpkdZFwANp-+fSmPPENLoh2Za2-fyf+aZ0VK79AnyRJs1H3A@mail.gmail.com>
Hi Linus,
On 2019/8/20 16:01, Linus Walleij wrote:
> On Mon, Aug 19, 2019 at 3:29 PM Wei Xu <xuwei5@hisilicon.com> wrote:
>
>> Invoke acpi_gpiochip_request_interrupts after the acpi data has been
>> attached to the pl061 acpi node to register interruption.
>>
>> Otherwise it will be failed to register interruption for the ACPI case.
>> Because in the gpiochip_add_data_with_key, acpi_gpiochip_add is invoked
>> after gpiochip_add_irqchip but at that time the acpi data has not been
>> attached yet.
> We need to fix this problem in gpiochip_add_data_with_key() instead.
Thanks!
Best Regards,
Wei
> Yours,
> Linus Walleij
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-20 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:27 [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion Wei Xu
2019-08-19 13:27 ` Wei Xu
2019-08-19 15:07 ` Andy Shevchenko
2019-08-19 15:07 ` Andy Shevchenko
2019-08-20 7:12 ` Linus Walleij
2019-08-20 7:12 ` Linus Walleij
2019-08-20 8:29 ` Andy Shevchenko
2019-08-20 8:29 ` Andy Shevchenko
2019-08-20 8:51 ` Andy Shevchenko
2019-08-20 8:51 ` Andy Shevchenko
2019-08-20 10:26 ` Linus Walleij
2019-08-20 10:26 ` Linus Walleij
2019-08-20 8:01 ` Linus Walleij
2019-08-20 8:01 ` Linus Walleij
2019-08-20 9:27 ` Wei Xu [this message]
2019-08-20 9:27 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D5BBD15.4030507@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=andy.shevchenko@gmail.com \
--cc=huangdaode@hisilicon.com \
--cc=jinying@hisilicon.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=liguozhu@hisilicon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shiju.jose@huawei.com \
--cc=tangkunshan@huawei.com \
--cc=zhangyi.ac@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.