From: zhong jiang <zhongjiang@huawei.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: <kvalo@codeaurora.org>, <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read
Date: Tue, 3 Sep 2019 16:01:54 +0800 [thread overview]
Message-ID: <5D6E1DF2.1000109@huawei.com> (raw)
In-Reply-To: <1567497430-22539-1-git-send-email-zhongjiang@huawei.com>
Please ignore the patch. Because the hostap_proc.c is marked as 'obsolete'.
Thanks,
zhong jiang
On 2019/9/3 15:57, zhong jiang wrote:
> Obviously, variable 'copied' is initialized to zero. But it is not used.
> hence just remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/net/wireless/intersil/hostap/hostap_proc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intersil/hostap/hostap_proc.c b/drivers/net/wireless/intersil/hostap/hostap_proc.c
> index 703d74c..6151d8d 100644
> --- a/drivers/net/wireless/intersil/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/intersil/hostap/hostap_proc.c
> @@ -234,7 +234,7 @@ static int prism2_io_debug_proc_read(char *page, char **start, off_t off,
> {
> local_info_t *local = (local_info_t *) data;
> int head = local->io_debug_head;
> - int start_bytes, left, copy, copied;
> + int start_bytes, left, copy;
>
> if (off + count > PRISM2_IO_DEBUG_SIZE * 4) {
> *eof = 1;
> @@ -243,7 +243,6 @@ static int prism2_io_debug_proc_read(char *page, char **start, off_t off,
> count = PRISM2_IO_DEBUG_SIZE * 4 - off;
> }
>
> - copied = 0;
> start_bytes = (PRISM2_IO_DEBUG_SIZE - head) * 4;
> left = count;
>
next prev parent reply other threads:[~2019-09-03 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 7:57 [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc_read zhong jiang
2019-09-03 8:01 ` zhong jiang [this message]
2019-09-05 13:45 ` Kalle Valo
2019-09-05 14:10 ` zhong jiang
2019-09-05 14:19 ` Kalle Valo
2019-09-06 14:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D6E1DF2.1000109@huawei.com \
--to=zhongjiang@huawei.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.