All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hamza Mahfooz <someguy@effective-light.com>
To: linux-kernel@vger.kernel.org
Cc: "Filipe Laíns" <lains@riseup.net>,
	"Bastien Nocera" <hadess@hadess.net>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: add support for the Logitech G Pro X mouse
Date: Mon, 24 Jul 2023 12:55:53 -0400	[thread overview]
Message-ID: <5D8BYR.57BKDP2Y14951@effective-light.com> (raw)
In-Reply-To: <20230724163032.15226-1-someguy@effective-light.com>


On Mon, Jul 24 2023 at 12:30:32 PM -04:00:00, Hamza Mahfooz 
<someguy@effective-light.com> wrote:
> The Logitech G Pro X mouse uses the HID++ protocol and supports 
> battery
> reporting. So, add it to the list of supported devices.
> 
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>

Actually on further inspection there is already a series that address
this issue (i.e.
https://lore.kernel.org/r/20230716182320.85483-1-mavchatz@protonmail.com/),
so please ignore this patch.

> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c 
> b/drivers/hid/hid-logitech-hidpp.c
> index 129b01be488d..34fc4f7b254a 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4620,6 +4620,8 @@ static const struct hid_device_id 
> hidpp_devices[] = {
>  		.driver_data = HIDPP_QUIRK_CLASS_G920 | 
> HIDPP_QUIRK_FORCE_OUTPUT_REPORTS },
>  	{ /* Logitech G Pro Gaming Mouse over USB */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
> +	{ /* Logitech G Pro X Superlight Gaming Mouse over USB */
> +	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC094) },
> 
>  	{ /* G935 Gaming Headset */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0x0a87),
> --
> 2.41.0
> 



      reply	other threads:[~2023-07-24 16:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 16:30 [PATCH] HID: logitech-hidpp: add support for the Logitech G Pro X mouse Hamza Mahfooz
2023-07-24 16:55 ` Hamza Mahfooz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D8BYR.57BKDP2Y14951@effective-light.com \
    --to=someguy@effective-light.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hadess@hadess.net \
    --cc=jikos@kernel.org \
    --cc=lains@riseup.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.