From: Mike Christie <mchristi@redhat.com>
To: Josef Bacik <josef@toxicpanda.com>,
axboe@kernel.dk, nbd@other.debian.org,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/2] fix double completion of timed out commands
Date: Mon, 21 Oct 2019 16:43:10 -0500 [thread overview]
Message-ID: <5DAE266E.9020004@redhat.com> (raw)
In-Reply-To: <20191021195628.19849-1-josef@toxicpanda.com>
On 10/21/2019 02:56 PM, Josef Bacik wrote:
> We noticed a problem where NBD sometimes double completes the same request when
> things go wrong and we time out the request. If the other side goes out to
> lunch but happens to reply just as we're timing out the requests we can end up
> with a double completion on the request.
>
> We already keep track of the command status, we just need to make sure we
> protect all cases where we set cmd->status with the cmd->lock, which is patch
> #1. Patch #2 is the fix for the problem, which catches the case where we race
> with the timeout handler and the reply handler. Thanks,
>
Patches look ok and tested ok for me.
Reviewed-by: Mike Christie <mchristi@redhat.com>
next prev parent reply other threads:[~2019-10-21 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 19:56 [PATCH 0/2] fix double completion of timed out commands Josef Bacik
2019-10-21 19:56 ` [PATCH 1/2] nbd: protect cmd->status with cmd->lock Josef Bacik
2019-10-21 19:56 ` [PATCH 2/2] nbd: handle racing with error'ed out commands Josef Bacik
2019-10-21 21:43 ` Mike Christie [this message]
2019-10-25 20:20 ` [PATCH 0/2] fix double completion of timed " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DAE266E.9020004@redhat.com \
--to=mchristi@redhat.com \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd@other.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.