All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <huyue2@yulong.com>, <gregkh@linuxfoundation.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/cma_debug: Use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
Date: Wed, 30 Oct 2019 10:42:29 +0800	[thread overview]
Message-ID: <5DB8F895.5050508@huawei.com> (raw)
In-Reply-To: <20191029143636.6ef9390992ffd1879ac9ad3b@linux-foundation.org>

On 2019/10/30 5:36, Andrew Morton wrote:
> On Tue, 29 Oct 2019 19:31:27 +0800 zhong jiang <zhongjiang@huawei.com> wrote:
>
>> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs
>> file operation rather than DEFINE_SIMPLE_ATTRIBUTE.
> hm, they do appear to be identical.
It seems to  DEFINE_DEBUGFS_ATTRIBUTE is special part of DEFINE_SIMPLE_ATTRUBUTE.  Defined
file operation is different.  but use DEFINE_DEBUGFS_ATTRIBUTE  to define normal fops also feasible.
> Perhaps DEFINE_DEBUGFS_ATTRIBUTE shouldn't exist, or should be #defined
> onto DEFINE_SIMPLE_ATTRIBUTE?
>
>
> .
Debugfs fops has an long existing in kernel.  And file read and write has different implementation.
I tend to keep in the way it was.

Thanks,
zhong jiang
>




      reply	other threads:[~2019-10-30  2:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 11:31 [PATCH] mm/cma_debug: Use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops zhong jiang
2019-10-29 21:36 ` Andrew Morton
2019-10-30  2:42   ` zhong jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5DB8F895.5050508@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=huyue2@yulong.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.