Re: [Patch v4 3/6] sched/fair: Enable CFS periodic tick to update thermal pressure

[Thara Gopinath <thara.gopinath@linaro.org>]

On 10/31/2019 12:11 PM, Dietmar Eggemann wrote:
> On 22.10.19 22:34, Thara Gopinath wrote:
>> Introduce support in CFS periodic tick to trigger the process of
>> computing average thermal pressure for a cpu.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>>  kernel/sched/fair.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 682a754..4f9c2cb 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -21,6 +21,7 @@
>>   *  Copyright (C) 2007 Red Hat, Inc., Peter Zijlstra
>>   */
>>  #include "sched.h"
>> +#include "thermal.h"
>>  
>>  #include <trace/events/sched.h>
>>  
>> @@ -7574,6 +7575,8 @@ static void update_blocked_averages(int cpu)
>>  		done = false;
>>  
>>  	update_blocked_load_status(rq, !done);
>> +
>> +	trigger_thermal_pressure_average(rq);
>>  	rq_unlock_irqrestore(rq, &rf);
>>  }
> 
> Since you update the thermal pressure signal in CFS's
> update_blocked_averages() as well, I guess the patch title has to change.
Will do. Thanks.
> 
>>  
>> @@ -9933,6 +9936,8 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
>>  
>>  	update_misfit_status(curr, rq);
>>  	update_overutilized_status(task_rq(curr));
>> +
>> +	trigger_thermal_pressure_average(rq);
>>  }
>>  
>>  /*
>>


-- 
Warm Regards
Thara