Re: [Xen-devel] [PATCH] arm/acpi: Add __acpi_unmap_table function for ARM

From: Wei Xu <xuwei5@hisilicon.com>
To: Alexandru Stefan ISAILA <aisaila@bitdefender.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Linuxarm <linuxarm@huawei.com>,
	Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
	"Zengtao \(B\)" <prime.zeng@hisilicon.com>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH] arm/acpi: Add __acpi_unmap_table function for ARM
Date: Wed, 22 Jan 2020 09:51:55 +0800	[thread overview]
Message-ID: <5E27AABB.6010609@hisilicon.com> (raw)
In-Reply-To: <9f8c3201-e40b-18bf-12e5-ed9f3f0a563a@bitdefender.com>

Hi Alexandru,

On 2020/1/21 18:01, Alexandru Stefan ISAILA wrote:
> 
> 
> On 21.01.2020 11:49, Wei Xu wrote:
>> Add __acpi_unmap_table function for ARM and invoke it at acpi_os_unmap_memory
>> to make sure the related fixmap has been cleared before using it for a
>> different mapping.
>>
>> Signed-off-by: Wei Xu<xuwei5@hisilicon.com>
>> ---
>>   xen/arch/arm/acpi/lib.c | 25 +++++++++++++++++++++++++
>>   xen/drivers/acpi/osl.c  |  2 ++
>>   xen/include/xen/acpi.h  |  1 +
>>   3 files changed, 28 insertions(+)
>>
>> diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c
>> index 4fc6e17..69e87ec 100644
>> --- a/xen/arch/arm/acpi/lib.c
>> +++ b/xen/arch/arm/acpi/lib.c
>> @@ -49,6 +49,31 @@ char *__acpi_map_table(paddr_t phys, unsigned long size)
>>       return ((char *) base + offset);
>>   }
>>   
>> +void __acpi_unmap_table(void __iomem * virt, unsigned long size)
> 
> You have a stray space here after "*"

Sorry, I will remove it.

> 
>> +{
>> +    unsigned long base, end;
>> +    int idx;
>> +
>> +    base = FIXMAP_ADDR(FIXMAP_ACPI_BEGIN);
>> +    end = FIXMAP_ADDR(FIXMAP_ACPI_END);
> 
> Maybe the initialization can be moved to the declaration?

OK.
I will move it.

Thanks!

Best Regards,
Wei

> 
> 
> Alex
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel