From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <5E28F304.70602@cn.fujitsu.com> Date: Thu, 23 Jan 2020 09:12:36 +0800 From: Xiao Yang MIME-Version: 1.0 References: <20200122024008.28126-1-yangx.jy@cn.fujitsu.com> <20200122185224.GS3263@work-vm> In-Reply-To: <20200122185224.GS3263@work-vm> Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Remove unused enum fuse_buf_copy_flags List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: virtio-fs@redhat.com On 2020/1/23 2:52, Dr. David Alan Gilbert wrote: > I'm confused as to which version this patch is against; all the worlds I > can see don't take 'req' into fuse_buf_copy. Hi Dave, I just used the development branch: https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev I saw that fuse_buf_copy() still has 'req' parameter on this branch. Is it obsolete? https://gitlab.com/virtio-fs/qemu/blob/virtio-fs-dev/tools/virtiofsd/buffer.c#L270 Best Regards, Xiao Yang