All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] aio02: Use mounted filesystem instead of temp directory
Date: Wed, 12 Feb 2020 13:30:26 +0800	[thread overview]
Message-ID: <5E438D72.4020203@cn.fujitsu.com> (raw)
In-Reply-To: <1581484093-13127-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

On 2020/2/12 13:08, Yang Xu wrote:
> tmpfs doesn't support O_DIRECT flag, open file with this flag on
> tmpfs will report EINVAL error. I thin we should test this case on
> ext2 filesystem instead of temp directory.
Hi Xu,

Thanks for your quick fix. :-)

I don't want to use the fixed file system to run aio02.
I perfer to just drop O_DIRECT flag for tmpfs, as below:
1) Drop O_DIRECT flag for tmpfs.
2) Keep O_DIRECT flag for other filesystem.
In this case, user still can run aio02 with different filesystem by 
mounting specified filesystem on $TMPDIR.

Best Regards,
Xiao Yang
> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> ---
>   testcases/kernel/io/aio/aio02.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/io/aio/aio02.c b/testcases/kernel/io/aio/aio02.c
> index e283afba9..205d1b088 100644
> --- a/testcases/kernel/io/aio/aio02.c
> +++ b/testcases/kernel/io/aio/aio02.c
> @@ -17,7 +17,8 @@
>
>   #define AIO_MAXIO 32
>   #define AIO_BLKSIZE (64*1024)
> -
> +#define MNTPOINT   "mnt_point"
> +#define FILE_TEST MNTPOINT"/file"
>   static int wait_count = 0;
>
>   #define DESC_FLAGS_OPR(x, y) .desc = (x == IO_CMD_PWRITE ? "WRITE: " #y: "READ : " #y), \
> @@ -206,7 +207,7 @@ static void test_io(unsigned int n)
>   	int status;
>   	struct testcase *tc = testcases + n;
>
> -	status = io_tio("file", tc->flags, tc->operation);
> +	status = io_tio(FILE_TEST, tc->flags, tc->operation);
>   	if (status)
>   		tst_res(TFAIL, "%s, status = %d", tc->desc, status);
>   	else
> @@ -214,7 +215,9 @@ static void test_io(unsigned int n)
>   }
>
>   static struct tst_test test = {
> -	.needs_tmpdir = 1,
> +	.mount_device = 1,
> +	.mntpoint = MNTPOINT,
> +	.needs_root = 1,
>   	.test = test_io,
>   	.tcnt = ARRAY_SIZE(testcases),
>   };




  reply	other threads:[~2020-02-12  5:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12  5:08 [LTP] [PATCH] aio02: Use mounted filesystem instead of temp directory Yang Xu
2020-02-12  5:30 ` Xiao Yang [this message]
2020-02-12  5:53   ` Yang Xu
2020-02-12  7:31   ` [LTP] [PATCH v2] aio02: Drop O_DIRECT flag for tmpfs Yang Xu
2020-02-12  9:42     ` Xiao Yang
2020-02-12  9:47       ` Xiao Yang
2020-02-12  9:53         ` Yang Xu
2020-02-12 10:07         ` [LTP] [PATCH v3] " Yang Xu
2020-02-12 13:37           ` Jan Stancek
2020-02-13  3:03             ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E438D72.4020203@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.