All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/quotactl04.c: Specify inode size for prjquota feature
Date: Wed, 15 Apr 2020 16:42:15 +0800	[thread overview]
Message-ID: <5E96C8E7.1090205@cn.fujitsu.com> (raw)
In-Reply-To: <20200415080854.65971-2-yangx.jy@cn.fujitsu.com>

On 2020/4/15 16:08, Xiao Yang wrote:
> Background:
> 1) LTP uses default 256M filesystem to run test.
> 2) Mke2fs sets inode size to 128 bytes for small filesystem(e.g. 256M) usually.
> 3) Prjquota feature requires bigger inode size which is at least 256 bytes.
> 
> new mke2fs can adjust inode size to 256M automatically by commit 66aae96 in
Hi,

Sorry, correct 256M to 256 bytes here.

Thanks,
Xiao Yang
> e2fsprogs, but old mke2fs cannot do it and reports the following error:
> -----------------------------------------------------------
> mke2fs 1.43.4 (31-Jan-2017)
> mkfs.ext4: 128 byte inodes are too small for project quota; specify larger size
> -----------------------------------------------------------
> 
> Make quotactl04 with old mke2fs works by specifying inode size to 256 bytes.
> 
> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
> ---
>   testcases/kernel/syscalls/quotactl/quotactl04.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl04.c b/testcases/kernel/syscalls/quotactl/quotactl04.c
> index b0db8fe5d..73980d7e9 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl04.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl04.c
> @@ -102,7 +102,7 @@ static struct tcase {
> 
>   static void setup(void)
>   {
> -	const char *const fs_opts[] = {"-O quota,project", NULL};
> +	const char *const fs_opts[] = {"-I 256", "-O quota,project", NULL};
> 
>   	test_id = geteuid();
>   	SAFE_MKFS(tst_device->dev, tst_device->fs_type, fs_opts, NULL);




  reply	other threads:[~2020-04-15  8:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  8:08 [LTP] [PATCH 1/2] syscalls/{quotactl04, statx05}.c: Replace extra_opts[] with fs_opts[] Xiao Yang
2020-04-15  8:08 ` [LTP] [PATCH 2/2] syscalls/quotactl04.c: Specify inode size for prjquota feature Xiao Yang
2020-04-15  8:42   ` Xiao Yang [this message]
2020-04-17  5:00   ` Yang Xu
2020-04-17  4:43 ` [LTP] [PATCH 1/2] syscalls/{quotactl04, statx05}.c: Replace extra_opts[] with fs_opts[] Yang Xu
2020-04-17  6:44   ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E96C8E7.1090205@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.