From: Wei Xu <xuwei5@hisilicon.com>
To: Loic Poulain <loic.poulain@linaro.org>, <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: hikey960: pinctrl: Fix spi2/spi3 pinconf
Date: Fri, 15 May 2020 15:05:46 +0800 [thread overview]
Message-ID: <5EBE3F4A.7090006@hisilicon.com> (raw)
In-Reply-To: <1585044472-16706-1-git-send-email-loic.poulain@linaro.org>
Hi Loic,
On 2020/3/24 18:07, Loic Poulain wrote:
> Only the pinmux was selected, not the pinconf, leading to spi issues.
> Increase drive strength so that max speed (25Mhz) can be achieved.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Thanks!
Applied to the hisilicon arm64 dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 ++--
> arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 253cc34..c39b7898 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -974,7 +974,7 @@
> clocks = <&crg_ctrl HI3660_CLK_GATE_SPI2>;
> clock-names = "apb_pclk";
> pinctrl-names = "default";
> - pinctrl-0 = <&spi2_pmx_func>;
> + pinctrl-0 = <&spi2_pmx_func &spi2_cfg_func>;
> num-cs = <1>;
> cs-gpios = <&gpio27 2 0>;
> status = "disabled";
> @@ -989,7 +989,7 @@
> clocks = <&crg_ctrl HI3660_CLK_GATE_SPI3>;
> clock-names = "apb_pclk";
> pinctrl-names = "default";
> - pinctrl-0 = <&spi3_pmx_func>;
> + pinctrl-0 = <&spi3_pmx_func &spi3_cfg_func>;
> num-cs = <1>;
> cs-gpios = <&gpio18 5 0>;
> status = "disabled";
> diff --git a/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi b/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
> index d11efc8..920a311 100644
> --- a/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi
> @@ -717,7 +717,7 @@
> spi3_cfg_func: spi3_cfg_func {
> pinctrl-single,pins = <
> 0x008 0x0 /* SPI3_CLK */
> - 0x0 /* SPI3_DI */
> + 0x00c 0x0 /* SPI3_DI */
> 0x010 0x0 /* SPI3_DO */
> 0x014 0x0 /* SPI3_CS0_N */
> >;
> @@ -734,7 +734,7 @@
> PULL_UP
> >;
> pinctrl-single,drive-strength = <
> - DRIVE7_02MA DRIVE6_MASK
> + DRIVE7_06MA DRIVE6_MASK
> >;
> };
> };
> @@ -1031,7 +1031,7 @@
> PULL_UP
> >;
> pinctrl-single,drive-strength = <
> - DRIVE7_02MA DRIVE6_MASK
> + DRIVE7_06MA DRIVE6_MASK
> >;
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-05-15 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 10:07 [PATCH] arm64: dts: hikey960: pinctrl: Fix spi2/spi3 pinconf Loic Poulain
2020-05-15 7:05 ` Wei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EBE3F4A.7090006@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=loic.poulain@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.