From: Wei Wang <wei.w.wang@intel.com>
To: Richard Henderson <richard.henderson@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: kevin.tian@intel.com, Juan Quintela <quintela@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Peter Xu <peterx@redhat.com>,
gloryxiao@tencent.com, yi.y.sun@intel.com
Subject: Re: [PATCH v3] migration/xbzrle: add encoding rate
Date: Fri, 05 Jun 2020 10:04:15 +0800 [thread overview]
Message-ID: <5ED9A81F.6070008@intel.com> (raw)
In-Reply-To: <26a232a7-8ec6-da2c-348f-41da899cdc9a@linaro.org>
On 06/05/2020 12:57 AM, Richard Henderson wrote:
> On 6/4/20 3:27 AM, Wei Wang wrote:
>> On 06/04/2020 05:38 PM, Dr. David Alan Gilbert wrote:
>>> Hmm OK; I'll admit to not liking NaN/Inf in output.
>>>
>>> Dave
>>>
>> OK. To deal with the reported issue, how about using FLT_MAX (as opposed to
>> UINT64_MAX or inf):
>> xbzrle_counters.encoding_rate = FLT_MAX;
> So you'd rather see 340282346638528859811704183484516925440.00 printed?
>
> It's arbitrary and not correct in any mathematical sense.
>
> If you *really* insist on not printing Inf (which may have some diagnostic
> value), then 0 is just as arbitrary, and at least smaller in the output.
0 works fine (though it logically means the lowest encoding rate).
I slightly prefer the biggest number or inf, which naturally means it's
very encoding friendly.
Let's see if Dave has any thought about the choices :)
Best,
Wei
next prev parent reply other threads:[~2020-06-05 1:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 0:59 [PATCH v3] migration/xbzrle: add encoding rate Wei Wang
2020-04-30 9:00 ` Dr. David Alan Gilbert
2020-05-07 15:53 ` Dr. David Alan Gilbert
2020-06-03 19:28 ` Richard Henderson
2020-06-04 2:58 ` Wei Wang
2020-06-04 3:22 ` Richard Henderson
2020-06-04 6:46 ` Wei Wang
2020-06-04 9:38 ` Dr. David Alan Gilbert
2020-06-04 10:27 ` Wei Wang
2020-06-04 16:57 ` Richard Henderson
2020-06-05 2:04 ` Wei Wang [this message]
2020-06-05 9:25 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ED9A81F.6070008@intel.com \
--to=wei.w.wang@intel.com \
--cc=dgilbert@redhat.com \
--cc=gloryxiao@tencent.com \
--cc=kevin.tian@intel.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=yi.y.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.