All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michele Denber <denber@mindspring.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Peter Tribble <peter.tribble@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] configure / util: Auto-detect the availability of openpty()
Date: Thu, 02 Jul 2020 17:33:05 -0400	[thread overview]
Message-ID: <5EFE5291.6030300@mindspring.com> (raw)
In-Reply-To: <1e699fdc-639e-ef8a-313f-7e665cad868c@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

On 07/02/20 13:34, Thomas Huth wrote:
>
> That's just the context, cut at three lines after the last change. 
> Simply try to apply the patch with "patch -p1 -i ..." or "git am" in a 
> separate git branch if you're using git. It should hopefully apply 
> cleanly.

Looks like it partly worked:

root@hemlock:~/qemu-5.0.0# gpatch -p1 -i < configpatch.diff
gpatch: option requires an argument -- 'i'
gpatch: Try 'gpatch --help' for more information.
root@hemlock:~/qemu-5.0.0# gpatch -p1 < configpatch.diff
patching file configure
Hunk #1 succeeded at 5049 (offset -85 lines).
Hunk #2 succeeded at 7117 (offset -267 lines).
patching file util/qemu-openpty.c
Hunk #1 FAILED at 52.
Hunk #2 succeeded at 95 with fuzz 2 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file util/qemu-openpty.c.rej
root@hemlock:~/qemu-5.0.0# cat util/qemu-openpty.c.rej
--- util/qemu-openpty.c
+++ util/qemu-openpty.c
@@ -52,7 +52,8 @@
  #endif

  #ifdef __sun__
-/* Once Solaris has openpty(), this is going to be removed. */
+
+#if !defined(HAVE_OPENPTY)
  static int openpty(int *amaster, int *aslave, char *name,
                     struct termios *termp, struct winsize *winp)
  {
root@hemlock:~/qemu-5.0.0#


             - Michele


[-- Attachment #2: Type: text/html, Size: 2334 bytes --]

  reply	other threads:[~2020-07-02 21:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 14:39 [PATCH] configure / util: Auto-detect the availability of openpty() Thomas Huth
2020-07-02 14:46 ` Daniel P. Berrangé
2020-07-02 16:07   ` Michele Denber
2020-07-02 17:38   ` Thomas Huth
2020-07-02 16:13 ` Michele Denber
2020-07-02 17:34   ` Thomas Huth
2020-07-02 21:33     ` Michele Denber [this message]
2020-07-03  5:11       ` Thomas Huth
2020-07-03 16:25         ` Michele Denber
2020-07-03 16:34         ` Michele Denber
2020-07-03 16:50           ` Peter Maydell
2020-07-03 18:49             ` gmake in Solaris 11.4: _IOR missing Michele Denber
2020-07-03 21:35               ` gmake in Solaris 11.4: TFR missing Michele Denber
2020-07-03 21:55                 ` Philippe Mathieu-Daudé
2020-07-04  9:11                   ` Peter Maydell
2020-07-04 11:30                     ` Philippe Mathieu-Daudé
2020-07-04 13:52                       ` Peter Maydell
2020-07-04 15:27                   ` Michele Denber
2020-07-04 12:02                 ` Thomas Huth
2020-07-04 15:36                   ` Michele Denber
2020-07-04 15:57                     ` Philippe Mathieu-Daudé
2020-07-04 19:15                       ` Michele Denber
2020-07-04 21:58                         ` Peter Maydell
2020-07-04 19:48                       ` Michele Denber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5EFE5291.6030300@mindspring.com \
    --to=denber@mindspring.com \
    --cc=peter.tribble@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.