From: AlexChen <alex.chen@huawei.com>
To: <pbonzini@redhat.com>
Cc: zhengchuan@huawei.com, qemu-devel@nongnu.org,
zhang.zhanghailiang@huawei.com
Subject: oslib-posix:Fix handle fd leak in qemu_write_pidfile()
Date: Wed, 26 Aug 2020 18:14:48 +0800 [thread overview]
Message-ID: <5F463618.10000@huawei.com> (raw)
From: alexchen <alex.chen@huawei.com>
The fd will leak when (a.st_ino == b.st_ino) is true, fix it.
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
util/oslib-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index ad8001a4ad..74cf5e9c73 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -176,6 +176,7 @@ bool qemu_write_pidfile(const char *path, Error **errp)
goto fail_unlink;
}
+ close(fd);
return true;
fail_unlink:
--
2.19.1
next reply other threads:[~2020-08-26 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 10:14 AlexChen [this message]
2020-08-26 10:18 ` oslib-posix:Fix handle fd leak in qemu_write_pidfile() Daniel P. Berrangé
2020-08-27 2:40 ` AlexChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F463618.10000@huawei.com \
--to=alex.chen@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.