From: Jing Xiangfeng <jingxiangfeng@huawei.com>
To: Stephen Boyd <sboyd@kernel.org>, <agross@kernel.org>,
<bjorn.andersson@linaro.org>, <mturquette@baylibre.com>,
<tdas@codeaurora.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe()
Date: Thu, 10 Sep 2020 17:28:51 +0800 [thread overview]
Message-ID: <5F59F1D3.50905@huawei.com> (raw)
In-Reply-To: <159972862952.2295844.10882678924928944990@swboyd.mtv.corp.google.com>
On 2020/9/10 17:03, Stephen Boyd wrote:
> Quoting Jing Xiangfeng (2020-08-27 07:16:29)
>> lpass_core_sc7180_probe() misses to call pm_clk_destroy() and
>> pm_runtime_disable() in error paths. Correct goto target to fix it.
>> This issue is found by code inspection.
>>
>> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
>> ---
>
> HMm.. presumably
>
> Fixes: edab812d802d ("clk: qcom: lpass: Add support for LPASS clock controller for SC7180")
>
> should be added?
Ok, I will send a v2 with it.
Thanks
> .
>
next prev parent reply other threads:[~2020-09-10 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 14:16 [PATCH] clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe() Jing Xiangfeng
2020-09-10 9:03 ` Stephen Boyd
2020-09-10 9:28 ` Jing Xiangfeng [this message]
2020-09-10 20:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F59F1D3.50905@huawei.com \
--to=jingxiangfeng@huawei.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.