From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <fstests@vger.kernel.org>, <darrick.wong@oracle.com>,
<david@fromorbit.com>, <ira.weiny@intel.com>,
<linux-xfs@vger.kernel.org>, <guan@eryu.me>
Subject: Re: [PATCH v2 1/2] common/rc: Check 'tPnE' flags on a directory instead of a regilar file
Date: Thu, 17 Sep 2020 12:05:23 +0800 [thread overview]
Message-ID: <5F62E083.2040806@cn.fujitsu.com> (raw)
In-Reply-To: <20200914072611.GB29046@infradead.org>
On 2020/9/14 15:26, Christoph Hellwig wrote:
> On Mon, Sep 14, 2020 at 01:13:59PM +0800, Xiao Yang wrote:
>> 'tPnE' flags are only valid for a directory so check them on a directory.
>>
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
> The change looks good, but I wonder if we should split the chattr
> tests into
>
> _require_chattr_file_flag
>
> and
>
> _require_chattr_dir_flag
>
> to make the whole thing a little less convoluted..
Hi Christoph,
Sorry for the late reply.
It seems hard to factor out _require_chattr_file_flag() and
_require_chattr_dir_flag()
because we need to get attribute after running chattr command and then check
attribute after parsing all stderr of chattr command.
Could you provide me some detailed guide? Thanks a lot :-)
Best Regards,
Xiao Yang
>
>
> .
>
prev parent reply other threads:[~2020-09-17 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 5:13 [PATCH v2 1/2] common/rc: Check 'tPnE' flags on a directory instead of a regilar file Xiao Yang
2020-09-14 5:14 ` [PATCH v2 2/2] common/rc: Add extra check for xfs_io -c "chattr" on XFS Xiao Yang
2020-09-14 7:26 ` [PATCH v2 1/2] common/rc: Check 'tPnE' flags on a directory instead of a regilar file Christoph Hellwig
2020-09-17 4:05 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F62E083.2040806@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.