From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jing Xiangfeng Date: Fri, 18 Sep 2020 00:50:25 +0000 Subject: Re: [PATCH] fbcon: Remove the superfluous break Message-Id: <5F640451.7020704@huawei.com> List-Id: References: <20200917131515.147029-1-jingxiangfeng@huawei.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nick Desaulniers Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , daniel.vetter@ffwll.ch, "Gustavo A. R. Silva" , LKML , dri-devel , george.kennedy@oracle.com, Greg KH , Joe Perches , Nathan Chancellor , jirislaby@kernel.org, peda@axentia.se On 2020/9/18 1:36, Nick Desaulniers wrote: > On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng wrote: >> >> Remove the superfuous break, as there is a 'return' before it. > > superfluous (missed "l") Thanks for correcting! > >> >> Signed-off-by: Jing Xiangfeng > > Reviewed-by: Nick Desaulniers > > Thanks for the patch; I audited the rest of the switch statements in > this translation unit; LGTM. > >> --- >> drivers/video/fbdev/core/fbcon.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c >> index 0b49b0f44edf..623359aadd1e 100644 >> --- a/drivers/video/fbdev/core/fbcon.c >> +++ b/drivers/video/fbdev/core/fbcon.c >> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> -- >> 2.17.1 >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FE7C43463 for ; Fri, 18 Sep 2020 07:21:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35E6B20C56 for ; Fri, 18 Sep 2020 07:21:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35E6B20C56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4251B6ECB3; Fri, 18 Sep 2020 07:21:30 +0000 (UTC) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2787A6E0B8 for ; Fri, 18 Sep 2020 00:50:32 +0000 (UTC) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A79DC255FB1C7A8DD48E; Fri, 18 Sep 2020 08:50:28 +0800 (CST) Received: from [10.174.178.248] (10.174.178.248) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 18 Sep 2020 08:50:26 +0800 Subject: Re: [PATCH] fbcon: Remove the superfluous break To: Nick Desaulniers References: <20200917131515.147029-1-jingxiangfeng@huawei.com> From: Jing Xiangfeng Message-ID: <5F640451.7020704@huawei.com> Date: Fri, 18 Sep 2020 08:50:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.178.248] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Fri, 18 Sep 2020 07:21:19 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , daniel.vetter@ffwll.ch, "Gustavo A. R. Silva" , LKML , dri-devel , george.kennedy@oracle.com, Greg KH , Joe Perches , Nathan Chancellor , jirislaby@kernel.org, peda@axentia.se Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020/9/18 1:36, Nick Desaulniers wrote: > On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng wrote: >> >> Remove the superfuous break, as there is a 'return' before it. > > superfluous (missed "l") Thanks for correcting! > >> >> Signed-off-by: Jing Xiangfeng > > Reviewed-by: Nick Desaulniers > > Thanks for the patch; I audited the rest of the switch statements in > this translation unit; LGTM. > >> --- >> drivers/video/fbdev/core/fbcon.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c >> index 0b49b0f44edf..623359aadd1e 100644 >> --- a/drivers/video/fbdev/core/fbcon.c >> +++ b/drivers/video/fbdev/core/fbcon.c >> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> -- >> 2.17.1 >> > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145DEC43463 for ; Fri, 18 Sep 2020 00:50:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C273020678 for ; Fri, 18 Sep 2020 00:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726156AbgIRAuc (ORCPT ); Thu, 17 Sep 2020 20:50:32 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:13274 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726102AbgIRAuc (ORCPT ); Thu, 17 Sep 2020 20:50:32 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A79DC255FB1C7A8DD48E; Fri, 18 Sep 2020 08:50:28 +0800 (CST) Received: from [10.174.178.248] (10.174.178.248) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 18 Sep 2020 08:50:26 +0800 Subject: Re: [PATCH] fbcon: Remove the superfluous break To: Nick Desaulniers References: <20200917131515.147029-1-jingxiangfeng@huawei.com> CC: Bartlomiej Zolnierkiewicz , Greg KH , , , Nathan Chancellor , , , dri-devel , , LKML , "Gustavo A. R. Silva" , Joe Perches From: Jing Xiangfeng Message-ID: <5F640451.7020704@huawei.com> Date: Fri, 18 Sep 2020 08:50:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.248] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/18 1:36, Nick Desaulniers wrote: > On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng wrote: >> >> Remove the superfuous break, as there is a 'return' before it. > > superfluous (missed "l") Thanks for correcting! > >> >> Signed-off-by: Jing Xiangfeng > > Reviewed-by: Nick Desaulniers > > Thanks for the patch; I audited the rest of the switch statements in > this translation unit; LGTM. > >> --- >> drivers/video/fbdev/core/fbcon.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c >> index 0b49b0f44edf..623359aadd1e 100644 >> --- a/drivers/video/fbdev/core/fbcon.c >> +++ b/drivers/video/fbdev/core/fbcon.c >> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> -- >> 2.17.1 >> > >