All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported
Date: Tue, 29 Sep 2020 15:41:34 +0800	[thread overview]
Message-ID: <5F72E52E.40609@cn.fujitsu.com> (raw)
In-Reply-To: <20200929073501.4598-1-pvorel@suse.cz>

Hi Petr
Why not using kconfig in tst_test struct.

Best Regards
Yang Xu
> to fix test on kernel built without CONFIG_AIO=y.
>
> Cleanup: use return instead of else, join string.
>
> Signed-off-by: Petr Vorel<pvorel@suse.cz>
> ---
> Hi,
>
> simple patch, but can wait after release.
> I can move cleanup into separate commit.
>
> Kind regards,
> Petr
>
>   testcases/kernel/syscalls/io_destroy/io_destroy01.c | 13 +++++++++----
>   1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/io_destroy/io_destroy01.c b/testcases/kernel/syscalls/io_destroy/io_destroy01.c
> index 560d7b3fb..5c5c59335 100644
> --- a/testcases/kernel/syscalls/io_destroy/io_destroy01.c
> +++ b/testcases/kernel/syscalls/io_destroy/io_destroy01.c
> @@ -32,14 +32,19 @@ static void verify_io_destroy(void)
>   		return;
>   	}
>
> +	if (TST_RET == -ENOSYS) {
> +		tst_res(TCONF, "io_destroy() not supported");
> +		return;
> +	}
> +
>   	if (TST_RET == -EINVAL) {
>   		tst_res(TPASS,
>   			"io_destroy() failed as expected, returned -EINVAL");
> -	} else {
> -		tst_res(TFAIL, "io_destroy() failed unexpectedly, "
> -			"returned -%s expected -EINVAL",
> -			tst_strerrno(-TST_RET));
> +		return;
>   	}
> +
> +	tst_res(TFAIL, "io_destroy() failed unexpectedly, returned -%s expected -EINVAL",
> +		tst_strerrno(-TST_RET));
>   }
>
>   static struct tst_test test = {




  reply	other threads:[~2020-09-29  7:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29  7:35 [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported Petr Vorel
2020-09-29  7:41 ` Yang Xu [this message]
2020-09-29  8:41   ` Petr Vorel
2020-09-29  9:57     ` Yang Xu
2020-09-29 11:47       ` Richard Palethorpe
2020-09-30  9:10         ` Petr Vorel
2020-09-29 13:02   ` Cyril Hrubis
2020-09-29  8:38 ` Cyril Hrubis
2020-09-29  8:48   ` Petr Vorel
2020-09-29  8:51     ` Cyril Hrubis
2020-09-29  9:41       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5F72E52E.40609@cn.fujitsu.com \
    --to=xuyang2018.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.