All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 00/19] Unify error handling in LTP library
Date: Tue, 27 Oct 2020 21:32:41 +0800	[thread overview]
Message-ID: <5F982179.1070804@cn.fujitsu.com> (raw)
In-Reply-To: <20201026164756.30556-1-mdoucha@suse.cz>

Hi Martin

I have seen the patchset and send some comments on 2,3,5,11 patch,
for the patchset,  you can add Acked-by.
Acked-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>


Best Regard
Yang Xu
> LTP helper functions, mainly safe syscalls, often report two different source
> code locations in error messages and sometimes handle syscall return values
> incorrectly. This patchset unifies source code location formatting to only
> show the calling line in the test program and fixes invalid return value
> handling. Safe syscalls now make pedantic distinction between common errors
> and invalid return values where applicable.
>
> Some safe syscalls returned no value so they were not usable in test cleanup.
> This is also fixed along with potential control flow issues when tst_brk()
> does not immediately terminate the program.
>
> Martin Doucha (19):
>    Unify error handling in lib/tst_safe_macros.c
>    Unify error handling in lib/tst_safe_sysv_ipc.c
>    Unify error handling in lib/tst_safe_timerfd.c
>    Unify error handling in lib/safe_file_ops.c
>    Unify error handling in lib/safe_macros.c
>    Unify error handling in lib/safe_net.c
>    Unify error handling in lib/safe_stdio.c
>    Unify error handling in lib/tst_mkfs.c
>    Unify error handling in lib/tst_checkpoint.c
>    Unify error handling in lib/tst_net.c
>    Unify error handling in lib/tst_fs_setup.c
>    Unify error handling in include/tst_safe_clocks.h
>    Move executable code out of tst_safe_macros.h
>    Unify error handling in moved functions
>    Unify error handling in include/tst_safe_macros.h
>    Unify error handling in include/tst_safe_posix_ipc.h
>    Unify error handling in include/tst_safe_prw.h
>    Unify error handling in lib/tst_resource.c
>    Unify error handling in include/lapi/safe_rt_signal.h
>
>   include/lapi/safe_rt_signal.h |  25 +-
>   include/safe_file_ops_fn.h    |   8 +-
>   include/tst_safe_clocks.h     |  48 ++-
>   include/tst_safe_macros.h     | 130 ++++----
>   include/tst_safe_posix_ipc.h  |   6 +-
>   include/tst_safe_prw.h        |  16 +-
>   lib/safe_file_ops.c           | 207 +++++++-----
>   lib/safe_macros.c             | 602 ++++++++++++++++++++++------------
>   lib/safe_net.c                | 262 +++++++++------
>   lib/safe_stdio.c              |  34 +-
>   lib/tst_checkpoint.c          |  23 +-
>   lib/tst_fs_setup.c            |   8 +-
>   lib/tst_mkfs.c                |  36 +-
>   lib/tst_net.c                 |   9 +-
>   lib/tst_resource.c            |   9 +-
>   lib/tst_safe_macros.c         | 201 ++++++++++--
>   lib/tst_safe_sysv_ipc.c       |  79 +++--
>   lib/tst_safe_timerfd.c        |  32 +-
>   18 files changed, 1100 insertions(+), 635 deletions(-)
>




      parent reply	other threads:[~2020-10-27 13:32 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 16:47 [LTP] [PATCH 00/19] Unify error handling in LTP library Martin Doucha
2020-10-26 16:47 ` [LTP] [PATCH 01/19] Unify error handling in lib/tst_safe_macros.c Martin Doucha
2020-10-27  8:22   ` Yang Xu
2020-10-29 15:35   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 02/19] Unify error handling in lib/tst_safe_sysv_ipc.c Martin Doucha
2020-10-27  9:10   ` Yang Xu
2020-10-26 16:47 ` [LTP] [PATCH 03/19] Unify error handling in lib/tst_safe_timerfd.c Martin Doucha
2020-10-27  9:21   ` Yang Xu
2020-11-06 17:35     ` Petr Vorel
2020-11-07  0:22       ` Yang Xu
2020-11-07 16:42         ` Petr Vorel
2020-10-26 16:47 ` [LTP] [PATCH 04/19] Unify error handling in lib/safe_file_ops.c Martin Doucha
2020-10-29 15:59   ` Cyril Hrubis
2020-10-29 16:02     ` Cyril Hrubis
2020-10-29 16:05       ` Martin Doucha
2020-10-29 16:17         ` Cyril Hrubis
2020-10-29 16:23           ` Martin Doucha
2020-10-30 10:31             ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 05/19] Unify error handling in lib/safe_macros.c Martin Doucha
2020-10-27 10:10   ` Yang Xu
2020-10-27 10:51     ` Martin Doucha
2020-11-11 12:58   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 06/19] Unify error handling in lib/safe_net.c Martin Doucha
2020-11-11 12:53   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 07/19] Unify error handling in lib/safe_stdio.c Martin Doucha
2020-11-10 16:11   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 08/19] Unify error handling in lib/tst_mkfs.c Martin Doucha
2020-11-10 15:43   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 09/19] Unify error handling in lib/tst_checkpoint.c Martin Doucha
2020-11-10 15:17   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 10/19] Unify error handling in lib/tst_net.c Martin Doucha
2020-11-10 13:20   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 11/19] Unify error handling in lib/tst_fs_setup.c Martin Doucha
2020-10-27 13:12   ` Yang Xu
2020-10-26 16:47 ` [LTP] [PATCH 12/19] Unify error handling in include/tst_safe_clocks.h Martin Doucha
2020-11-10 13:13   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 13/19] Move executable code out of tst_safe_macros.h Martin Doucha
2020-10-26 16:47 ` [LTP] [PATCH 14/19] Unify error handling in moved functions Martin Doucha
2020-11-10 12:18   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 15/19] Unify error handling in include/tst_safe_macros.h Martin Doucha
2020-11-10 11:37   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 16/19] Unify error handling in include/tst_safe_posix_ipc.h Martin Doucha
2020-11-06 15:43   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 17/19] Unify error handling in include/tst_safe_prw.h Martin Doucha
2020-11-06 15:39   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 18/19] Unify error handling in lib/tst_resource.c Martin Doucha
2020-11-06 13:05   ` Cyril Hrubis
2020-10-26 16:47 ` [LTP] [PATCH 19/19] Unify error handling in include/lapi/safe_rt_signal.h Martin Doucha
2020-11-06 12:57   ` Cyril Hrubis
2020-10-27 13:32 ` Yang Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5F982179.1070804@cn.fujitsu.com \
    --to=xuyang2018.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.