From: Zhou Wang <wangzhou1@hisilicon.com>
To: Kai Ye <yekai13@huawei.com>,
<linux-accelerators@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<zhangfei.gao@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 1/2] uacce: delete some redundant code.
Date: Mon, 2 Nov 2020 15:37:09 +0800 [thread overview]
Message-ID: <5F9FB725.5000002@hisilicon.com> (raw)
In-Reply-To: <1600855762-10031-2-git-send-email-yekai13@huawei.com>
On 2020/9/23 18:09, Kai Ye wrote:
> Delete some redundant code.
>
> Signed-off-by: Kai Ye <yekai13@huawei.com>
> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
> drivers/misc/uacce/uacce.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index 107028e..9b83bc5 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma)
>
> switch (type) {
> case UACCE_QFRT_MMIO:
> - if (!uacce->ops->mmap) {
> - ret = -EINVAL;
> - goto out_with_lock;
> - }
> -
> - ret = uacce->ops->mmap(q, vma, qfr);
> - if (ret)
> - goto out_with_lock;
> -
> - break;
> -
> case UACCE_QFRT_DUS:
> if (!uacce->ops->mmap) {
> ret = -EINVAL;
>
Hi Hartman,
Could you take this patch?
Best,
Zhou
next prev parent reply other threads:[~2020-11-02 7:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:09 [PATCH v3 0/2] uacce: fix some coding styles Kai Ye
2020-09-23 10:09 ` [PATCH v3 1/2] uacce: delete some redundant code Kai Ye
2020-11-02 7:37 ` Zhou Wang [this message]
2020-09-23 10:09 ` [PATCH v3 2/2] uacce: modify the module author information Kai Ye
2020-11-02 7:38 ` Zhou Wang
2020-10-19 7:02 ` [PATCH v3 0/2] uacce: fix some coding styles yekai(A)
2020-11-02 6:41 ` Zhou Wang
2020-11-02 7:09 ` Greg Kroah-Hartman
2020-11-02 7:38 ` Zhou Wang
2020-11-02 8:33 ` Greg Kroah-Hartman
2020-11-02 8:39 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F9FB725.5000002@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=yekai13@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.