All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lapi/name_to_handle_at.h: Fix compiler error on centos6
Date: Thu, 26 Nov 2020 13:16:06 +0800	[thread overview]
Message-ID: <5FBF3A16.6090101@cn.fujitsu.com> (raw)
In-Reply-To: <CAEemH2eQNTy9V+NSn+kwV8zZ0BTr+PEHuD_RPhx3Ns1v=+iPNw@mail.gmail.com>

On 2020/11/26 12:33, Li Wang wrote:
> Hi Xiao,
>
> The patch itself looks good, but I remember we were planning to 
> drop support for the old distro e.g CentOS6.
>
> The previous discussion here:
> http://lists.linux.it/pipermail/ltp/2020-March/016164.html
Hi Li,

Thanks for sharing the infomation.
When do you plan to remove old distro? next release?

BTW:
It may also resolve the compiler error on uclibc as Fabrice Fontaine 
reported before:
https://github.com/linux-test-project/ltp/commit/cb11e718ce04261cb6ff4c09442b949da33b8797

Best Regards,
Xiao Yang
>
> On Thu, Nov 26, 2020 at 9:49 AM Xiao Yang <yangx.jy@cn.fujitsu.com 
> <mailto:yangx.jy@cn.fujitsu.com>> wrote:
>
>     From travis-ci, compiling name_to_handle_at/open_by_handle_at tests
>     failed on centos6 due to undefined AT_EMPTY_PATH and MAX_HANDLE_SZ.
>
>     Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com
>     <mailto:yangx.jy@cn.fujitsu.com>>
>     ---
>      include/lapi/fcntl.h             | 4 ++++
>      include/lapi/name_to_handle_at.h | 1 +
>      2 files changed, 5 insertions(+)
>
>     diff --git a/include/lapi/fcntl.h b/include/lapi/fcntl.h
>     index 576a18daf..d6665915f 100644
>     --- a/include/lapi/fcntl.h
>     +++ b/include/lapi/fcntl.h
>     @@ -136,4 +136,8 @@
>      # define SPLICE_F_NONBLOCK 2
>      #endif
>
>     +#ifndef MAX_HANDLE_SZ
>     +# define MAX_HANDLE_SZ 128
>     +#endif
>     +
>      #endif /* __LAPI_FCNTL_H__ */
>     diff --git a/include/lapi/name_to_handle_at.h
>     b/include/lapi/name_to_handle_at.h
>     index c0759c463..3484133d1 100644
>     --- a/include/lapi/name_to_handle_at.h
>     +++ b/include/lapi/name_to_handle_at.h
>     @@ -10,6 +10,7 @@
>      #include <sys/syscall.h>
>      #include "config.h"
>      #include "lapi/syscalls.h"
>     +#include "lapi/fcntl.h"
>      #include "tst_buffers.h"
>      #include "tst_test.h"
>
>     -- 
>     2.25.1
>
>
>
>
>     -- 
>     Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
>
> -- 
> Regards,
> Li Wang



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20201126/8416976b/attachment-0001.htm>

  reply	other threads:[~2020-11-26  5:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26  1:28 [LTP] [PATCH] lapi/name_to_handle_at.h: Fix compiler error on centos6 Xiao Yang
2020-11-26  4:33 ` Li Wang
2020-11-26  5:16   ` Xiao Yang [this message]
2020-11-26  6:47     ` Li Wang
2020-11-26  9:19       ` Cyril Hrubis
2020-11-26  9:23         ` Petr Vorel
2020-11-26 10:33           ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5FBF3A16.6090101@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.