From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro
Date: Tue, 9 Jul 2024 13:00:13 -0700 [thread overview]
Message-ID: <5a080f52-5486-4bb4-ab52-59cc0ab2589e@quicinc.com> (raw)
In-Reply-To: <Zl0UJZWx9fyZLzrm@fedora>
On 6/2/2024 5:53 PM, Ming Lei wrote:
> On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/block/ublk_drv.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
>> index 4e159948c912..59916895ee2e 100644
>> --- a/drivers/block/ublk_drv.c
>> +++ b/drivers/block/ublk_drv.c
>> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
>> MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>>
>> MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
>> +MODULE_DESCRIPTION("Userspace block device");
>> MODULE_LICENSE("GPL");
>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.
next prev parent reply other threads:[~2024-07-09 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 0:23 [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-03 0:53 ` Ming Lei
2024-07-09 20:00 ` Jeff Johnson [this message]
2024-07-10 6:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a080f52-5486-4bb4-ab52-59cc0ab2589e@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.