From: Mark Salyzyn <salyzyn@android.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net,
len.brown@intel.com, pavel@ucw.cz, linux-pm@vger.kernel.org,
a.zummo@towertech.it, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg)
Date: Tue, 18 Jul 2017 13:08:35 -0700 [thread overview]
Message-ID: <5a1a1eab-5d5b-b91c-2990-abbd2d17480e@android.com> (raw)
In-Reply-To: <b6bce88c-a13c-8504-18ac-242f637f4d13@android.com>
On 07/18/2017 01:00 PM, Mark Salyzyn wrote:
> On 07/18/2017 10:52 AM, Alexandre Belloni wrote:
>> Hi,
>>
>> On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote:
>>> . . .
>> Apart from using rtc_time_to_tm (and you should probably use
>> rtc_time64_to_tm), none of this is actually related to the RTC
>> subsystem. I feel like you should find another place to put that, maybe
>> timekeeping_debug.c?
> Makes a lot of sense!
>
> -- Mark
Ooops, timekeeping_debug.c is currently only to support a debugfs node.
Perhaps a _new_ file in that hierarchy like kernel/time/rtc_show_time.c.
-- Mark
prev parent reply other threads:[~2017-07-18 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 17:25 [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg) Mark Salyzyn
2017-07-18 17:41 ` Joe Perches
2017-07-18 17:46 ` Andy Shevchenko
2017-07-18 17:49 ` Andy Shevchenko
2017-07-18 17:52 ` Alexandre Belloni
2017-07-18 20:00 ` Mark Salyzyn
2017-07-18 20:08 ` Mark Salyzyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a1a1eab-5d5b-b91c-2990-abbd2d17480e@android.com \
--to=salyzyn@android.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.