From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net-next 4/4] net: dsa: mv88e6xxx: remove unused support for PPS event capture
Date: Wed, 10 Sep 2025 00:38:39 +0100 [thread overview]
Message-ID: <5a21bf14-4984-4fc3-bced-4d82e73eb9ac@linux.dev> (raw)
In-Reply-To: <E1uw0Xp-00000004IOI-1i7v@rmk-PC.armlinux.org.uk>
On 09/09/2025 16:46, Russell King (Oracle) wrote:
> mv88e6352_config_eventcap() is documented as handling both EXTTS and
> PPS capture modes, but nothing ever calls it for PPS capture. Remove
> the unused PPS capture mode support.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/dsa/mv88e6xxx/ptp.c | 21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
>
> @@ -188,20 +185,8 @@ static int mv88e6352_config_eventcap(struct mv88e6xxx_chip *chip, int event,
> if (err)
> return err;
>
> - if (event == PTP_CLOCK_PPS) {
> - cap_config = MV88E6XXX_TAI_EVENT_STATUS_CAP_TRIG;
nit: with this change MV88E6XXX_TAI_EVENT_STATUS_CAP_TRIG becomes unused
macro.
prev parent reply other threads:[~2025-09-09 23:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 15:45 [PATCH net-next 0/4] net: dsa: mv88e6xxx: remove redundant ptp/timestamping code Russell King (Oracle)
2025-09-09 15:45 ` [PATCH net-next 1/4] net: dsa: mv88e6xxx: remove mv88e6250_ptp_ops Russell King (Oracle)
2025-09-09 23:31 ` Vadim Fedorenko
2025-09-09 15:45 ` [PATCH net-next 2/4] net: dsa: mv88e6xxx: remove chip->trig_config Russell King (Oracle)
2025-09-09 23:32 ` Vadim Fedorenko
2025-09-09 15:46 ` [PATCH net-next 3/4] net: dsa: mv88e6xxx: remove chip->evcap_config Russell King (Oracle)
2025-09-09 23:33 ` Vadim Fedorenko
2025-09-10 10:55 ` kernel test robot
2025-09-10 10:55 ` kernel test robot
2025-09-09 15:46 ` [PATCH net-next 4/4] net: dsa: mv88e6xxx: remove unused support for PPS event capture Russell King (Oracle)
2025-09-09 23:38 ` Vadim Fedorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a21bf14-4984-4fc3-bced-4d82e73eb9ac@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.