All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
	davidgow@google.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh@kernel.org,
	saravanak@google.com
Cc: ruanjinjie@huawei.com
Subject: Re: [PATCH v2] of: Fix unbalanced of node refcount and memory leaks
Date: Wed, 09 Oct 2024 15:12:05 -0700	[thread overview]
Message-ID: <5a328b39f3f61371badc8d08de3dcab8.sboyd@kernel.org> (raw)
In-Reply-To: <20241009014950.1979424-1-ruanjinjie@huawei.com>

Quoting Jinjie Ruan (2024-10-08 18:49:50)
> diff --git a/drivers/of/overlay_test.c b/drivers/of/overlay_test.c
> index 19a292cdeee3..e95b1152612c 100644
> --- a/drivers/of/overlay_test.c
> +++ b/drivers/of/overlay_test.c
> @@ -73,12 +73,12 @@ static void of_overlay_apply_kunit_cleanup(struct kunit *test)
>  
>         np = of_find_node_by_name(NULL, kunit_node_name);
>         KUNIT_ASSERT_NOT_ERR_OR_NULL(test, np);
> -       of_node_put_kunit(test, np);

Thanks for the patch. This should be

	of_node_put_kunit(&fake, np);

so that the node is put before the overlay is removed.

With that done you can add my

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

      reply	other threads:[~2024-10-09 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09  1:49 [PATCH v2] of: Fix unbalanced of node refcount and memory leaks Jinjie Ruan
2024-10-09 22:12 ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a328b39f3f61371badc8d08de3dcab8.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=davidgow@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.