RE: [OE-core] [PATCH] add missing normalize-resolvconf file since it has been moved to a separate file since version 1.90

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Luca Ceresoli via
> lists.openembedded.org
> Sent: den 20 juni 2022 11:50
> To: Qorin Qorinna <qorin.qorinna@nl.abb.com>
> Cc: Qorin Wu <qorin.wu@gmail.com>; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] add missing normalize-resolvconf file since it has been moved to a separate file since version 1.90

It is expected that the subject line is prefixed with the recipe name.
It is also a very long subject line. Better would be to move half of 
it to the commit message body, e.g.:

resolvconf: Install missing normalize-resolvconf file

It was moved to a separate file in version 1.90.

> Hi Qorin,
> 
> On Mon, 20 Jun 2022 09:24:22 +0000
> Qorin Qorinna <qorin.qorinna@nl.abb.com> wrote:
> 
> > Hi Luca,
> >
> > it's because the normalize-resolvconf requires sed.
> >
> > These are the error messages that I got when I built the package w/o sed
> > ERROR: resolvconf-1.91-r0 do_package_qa: QA Issue: /lib/resolvconf/normalize-resolvconf contained in package resolvconf requires /bin/sed, but no providers found in RDEPENDS:resolvconf? [file-rdeps]
> > ERROR: resolvconf-1.91-r0 do_package_qa: Fatal QA errors were found, failing task.
> 
> I see. In this case it would be nice to add either a line to the commit
> message or a comment in the .bb file, just to avoid others to wonder
> why sed is needed.

The problem here is that sed is provided by busybox and in almost all 
cases you do not want an explicit dependency on sed as that instead will 
install the sed program from the sed recipe. 

In this case I would recommend to add something like this:

# The normalize-resolvconf sed script uses /bin/sed on the shebang line.
# Ignore the file-rdeps test to avoid having to add a runtime dependency on sed.
INSANE_SKIP:${PN} += "file-rdeps"

> I added a line to the commit message on my branch that I'm going to
> test. It would be great if you could do so for future patches. Thanks!
> 
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

//Peter