From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4D11CC6B0E for ; Tue, 13 Oct 2026 17:15:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 92C0360797; Tue, 13 Oct 2026 17:15:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Y-ngmsSV3GRO; Tue, 13 Oct 2026 17:15:49 +0000 (UTC) ARC-Filter: OpenARC Filter v1.3.2 smtp3.osuosl.org 9052D607BD Authentication-Results: smtp3.osuosl.org; arc=fail smtp.remote-ip=140.211.166.142 ARC-Seal: i=3; d=osuosl.org; s=arc; a=rsa-sha256; cv=fail; t=1791911749; b=mVxNnsyUYEbauvyPPGowqyaGkqt2lj5OBl7UYAZT1OELU26y9ujMhJOgyIje64U9Sxu5 QxWB9cH0OV31aOTPfVKsr4Nc8OFblT8AHvE1gEHZfAe4aQ8qBlTiLFHwjPW5CeFrxE/8u qkfBw/DLzMW5PSLFXDW3gQ0FS6aHs1rYOrB664AyBAPXmrZvvtfsRIAK/nydtMh4lX5/6 U3xkvLUQ9i8R0+gUTzNMDefoqxE9UTjhmH4J+CGkhxvLQ/FhfkCpip2oo4rnM9ZE08rJN CEa8MTv/nfaZQNdE8MX1LhjziUERfnDvD83UmBRJltb26NfJfPFBj2hnuUXadUoUbYQ== ARC-Message-Signature: i=3; d=osuosl.org; s=arc; a=rsa-sha256; c=relaxed/relaxed; t=1791911749; h=X-Comment:DKIM-Signature:X-Original-To:Delivered-To:Received: Received:X-Virus-Scanned:X-Spam-Flag:X-Spam-Score:X-Spam-Level: X-Spam-Status:Received:ARC-Filter:Received-SPF:Received: DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID:X-IronPort-AV: X-IronPort-AV:Received:X-CSE-ConnectionGUID:X-CSE-MsgGUID:X-ExtLoop1: X-IronPort-AV:Received:Received:Received:Received:Received:Received: Message-ID:Date:User-Agent:Subject:From:To:CC:References: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-ClientProxiedBy:MIME-Version:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-Exchange-RoutingPolicyChecked: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: X-BeenThere:X-Mailman-Version:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:Errors-To; bh=45LN74a0muWejpQjxgbIHB/dSl6vduM56+q7hfDNAxY=; b=SIpkoRfU9Jf1JGh1/HwaptU3LwWLeh2Xx39RBymN+Y8nBmobG4PjMa4nvPLDeg6A/hEi xoBhI/qFgbb9VsSXI4wZMkE2MJRqfl0hVQQcnxbKHIuCwbR8figoBIoLqatTcfi68x3dh Lbv88zeMAxCOBQZUzaX5PC4Xeh8deAJcWpr8mBdd0/MdJltYyNKjURW1IlpabshwfcLxx MIQRG0fufBHmd2ZUbuLVYxrZeUMOjqh/x+S6uePuxLnZG8wO3mSCNbC1MamhiX179xGSe HsOB8je6JHYbC8vteXTwJ0mBzPQJ5BFA9KyLkx5OjY0Wvm/qH1+e9xVXJVuTl0cRFBA== ARC-Authentication-Results: i=3; smtp3.osuosl.org; dmarc=pass header.from=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=CRfuOFUC; arc=fail smtp.remote-ip=140.211.166.142 X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1791911749; bh=45LN74a0muWejpQjxgbIHB/dSl6vduM56+q7hfDNAxY=; h=Date:Subject:From:To:CC:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rNeXuBa4RBSu5QlldLYBTC8GuZH/TKJBzw4i/sjCb+1l5W/vsv9PupOOIRNZBpVNZ l3Ff4fMw+6eWN9TotlzEDOkVLRIkONcdF2ao3PpfesBbUCeIFjqXHBZkT+7kBdKlzc UqkpYVhYv95ncTS9LFMINGZWEYJSxrODTFuzbiBgC2ZStE5g9Oe7A/6/5htsLVWIiw E1qKCcgB7cUMPDWH6IVwTIXKLWce7zL9JhKfz+m2XCidddifXx8SE4rpXKHN9dHQxA iuGEJclvzVBBRhOXERVUc2G3KbHxLsbMpQy6VQB6y2mNbB8Ben2anaxVOdG+rZvgFN ksJpvW02DwGNQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 9052D607BD; Tue, 13 Oct 2026 17:15:49 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id D88E5788 for ; Tue, 13 Oct 2026 17:15:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CA698607BD for ; Tue, 13 Oct 2026 17:15:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id pXdjIXOU3D8l for ; Tue, 13 Oct 2026 17:15:46 +0000 (UTC) ARC-Filter: OpenARC Filter v1.3.2 smtp3.osuosl.org B596660797 Authentication-Results: smtp3.osuosl.org; arc=fail smtp.remote-ip=198.175.65.9 ARC-Seal: i=2; d=osuosl.org; s=arc; a=rsa-sha256; cv=fail; t=1791911746; b=DVuh2t3pfuwYT/zi45ycS7FK6t3a649a4PTtvL+qL2kBV9ELc3cqMfMUCzq+c8yxYSkZ HuQhS/Ecfv8VCwKuMbs2oCdHcaFCcyTYxAMVMkhlSb1aFjZiuWPkUELby7c84kv9L/FFW y2OqC+uPuFn9KXAFpzqrrH5CZvMet5muZO9jMs0ECgj2BLxlRrUecPewIpWDonWmHDNPj EfP9WhFsW/LXYnMn6OFTak69x8IKG98hivNB4KZWMniNvbCrhIgBFgvcdasdm9R0q3+ms ZqwqSr0CCW3cPYVmlAX03tNkWxFqsIUWfTOJBwdb0aaAD7JbH9EDnB5qpwq8/obh64Q== ARC-Message-Signature: i=2; d=osuosl.org; s=arc; a=rsa-sha256; c=relaxed/relaxed; t=1791911746; h=Received-SPF:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Received:Received: Received:Received:Received:Message-ID:Date:User-Agent:Subject:From:To: CC:References:Content-Language:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-ClientProxiedBy:MIME-Version: X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic: X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck: X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam: X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-Exchange-RoutingPolicyChecked: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; bh=45LN74a0muWejpQjxgbIHB/dSl6vduM56+q7hfDNAxY=; b=cBGmKcHv/T/0DgTYzLLRb3811ooen/x9KTW+ChkTju1Zsmm+BF9J2SiXL5vH/uNcKCa9 lQYbPE0haBxd2RovpOic6Hf/U/8NwaON4518CeVUzwi54L7t3jpSbgod3pzss0gxup5wn Q2iZQ784pqdYKaWbmPMLho8FQXZPLoiLcHC8ExsFwHH5SWsEHgIGaF5eY0svEGE9r3Sgc 3Rmx0gUArxrgPdZoRNkFIohfLwevmMz+pxPHiqD7oqSxzbt4z/1y+pZC4314AniGVIvdG Y67oVLeQPBdj1Rt7jeFDAPwYCLBOwovVNb55M72C8TygosdD+K48KPg5q+ODHDRRzjw== ARC-Authentication-Results: i=2; smtp3.osuosl.org; dmarc=pass header.from=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=CRfuOFUC; arc=fail smtp.remote-ip=198.175.65.9 Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.9; helo=mgamail.intel.com; envelope-from=emil.s.tantilov@intel.com; receiver= Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=CRfuOFUC Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by smtp3.osuosl.org (Postfix) with ESMTPS id B596660797 for ; Tue, 13 Oct 2026 17:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791911746; x=1823447746; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=PiduIglqcQpby8qPFSd9J1v+kDvuwd6TMj/e7c9PeWY=; b=CRfuOFUCt0HnBWT/VyFq1SqcCSFQG6AtJNY/adQUQX7IaUsGND323fL4 XhFL5VKczK4ohzwa/Hz0OWf0J1pU0qcsMewJmmwafzUHrkS9yDzcUBFly CejJl/Eg+c95eKEJdALmGFxpaU/k8nqDgUNL0WGRavmmqo4SgtuFpiQyf iWz4FtgTFIDmCNZQfwIJozZbnnNvct/dT07+dO71cCI1bE8HI9KHHZw2B RN5djsTwQDeTRfO+dbSd/lOK8H6RrX4X5UdHuNzMF5O2r47UXugsKsuTo TPCdffyJmsUwfBoOxS1aoZ1vn0l1aRncEw15FZ0ZbXNAmbJBAg+++cIB5 A==; X-CSE-ConnectionGUID: Oa64oYdxSTCzSCLTIihazg== X-CSE-MsgGUID: EawhFudJRmalMHjJy3EuGQ== X-IronPort-AV: E=McAfee;i="6800,10657,11934"; a="532603" X-IronPort-AV: E=Sophos;i="6.27,156,1787036400"; d="scan'208";a="532603" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2026 10:15:45 -0700 X-CSE-ConnectionGUID: nZp0Fa+nSsWm4pTddm0hBQ== X-CSE-MsgGUID: rh9QP3KkTf2zE5nHi8h2cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,156,1787036400"; d="scan'208";a="1136385" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2026 10:15:44 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 13 Oct 2026 10:15:43 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49 via Frontend Transport; Tue, 13 Oct 2026 10:15:43 -0700 Received: from BN8PR05CU002.outbound.protection.outlook.com (52.101.57.25) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 13 Oct 2026 10:15:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rnOno901JZBMPITI86XnKR7nfuHTZ7J/5iuMEAve9jAnlDbpUYgt0rM6o7YCUdxwzTalXqqJvkYkU1VYMYCl0+mlV0IsgdrPFZbzgRQjLh4w53rysJOFRxNlthR9mLTRLWikEYIwbQHES6nfB0oI5W68xNBmNYfl183uov8K1hj6/7qFMhTUZjq1TAu+EjAQxOLFfAPnE/ysc8/ZZMoQaZS41obYO50o6AAvM5bzfI8RDaz6JHBxfhgkElWHI5h1/naOox+Yz5R8Nl1MFYUOBZMASj9/8Eh6rtzcn5K5+xhLsPX9+Gu1Pip2bcbGIsT7PKrlD4AlVSryaqYGf4BdKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=45LN74a0muWejpQjxgbIHB/dSl6vduM56+q7hfDNAxY=; b=hsUgBKG7OBESLw3PNX8ZRQfre3TRXFvEVAFCe7ZOpatsxKg/pklDQBIe45GZ6rk6EPvwbj5O6vCnrh2+pn4xdQLY4GOTmUlz09J4Cw8Hfm9a9KATizhY6C0Mo6AmzZOt8xgvE1XAMGsTu+4jhoxxpwych44rvbHQNqaKdrY+K3qBipR/McKyk9bD8AGgsrXCGOPPsSQpTr6EgY9rQRjzFqtozxt0zGWwqN934kSwewCpiyrP28VrmC2MCEF1g/jnBSZc5fuNLZXIcdMrHfpaeIRrEt2klOlm71PcT0TUi2lpMLzj5JPHCqlF6mzk6874ZRpEvecWdnrMVlznAEpyCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA3PR11MB186312.namprd11.prod.outlook.com (2603:10b6:806:595::5) by BL4PR11MB8870.namprd11.prod.outlook.com (2603:10b6:208:5a8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Tue, 13 Oct 2026 17:15:39 +0000 Received: from SA3PR11MB186312.namprd11.prod.outlook.com ([fe80::fbe8:9ba6:fcd0:f0b]) by SA3PR11MB186312.namprd11.prod.outlook.com ([fe80::fbe8:9ba6:fcd0:f0b%6]) with mapi id 15.21.0522.011; Tue, 13 Oct 2026 17:15:39 +0000 Message-ID: <5a6710a3-5cc5-4bcd-890a-eb9c268575e4@intel.com> Date: Tue, 13 Oct 2026 10:15:37 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-net 2/2] idpf: release PTP before freeing vports on the init task error path From: "Tantilov, Emil S" To: CC: , Tony Nguyen References: <20261009212537.3996-1-emil.s.tantilov@intel.com> <20261009212537.3996-3-emil.s.tantilov@intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4P221CA0020.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::25) To SA3PR11MB186312.namprd11.prod.outlook.com (2603:10b6:806:595::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR11MB186312:EE_|BL4PR11MB8870:EE_ X-MS-Office365-Filtering-Correlation-Id: 12471ddd-404a-4dac-7c8a-08df294d9ab8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|366016|1800799024|6133799003|10063799003|22082099003|18002099003|10067099003|3023799007|5023799004|4143699003|261009223027099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: LvhY0Fo/bX9+5e4b9hIf3ssYt2OwG3Qd+26H2rv5GTn8OLJ+enw8gkU5pVbBi0hzorgLEkV+IlYkJ4f623iTR6PiMkPqvvXtQvF8Sd8zYfYM6/m0NaJBfFpwHaIwIU9Mij23XZ9LSrXq0ZTPRq1Usq9jnqX+NYB0ozJ20uGuxgt6UV76cIOJR6uT0D9Iu0u2fI06jdDPeWXAhhhp2/w7HjiOBQ/A5PrJ5AqwD4d/y0ezlyhFauvyL+H0167gDVhYJ+w15aoRTGOt3ZsqX7/F0MPeZy+hyJZ8hVk3gB519kkgI5YDRJwLwP53fleXZwmKc9x2AzfjmFfTysequw6UzCRNNu+WO5Pe/ZFnhy3vRF+IOHnqPWrj5ZjokGnMq/rKbZD8uOQpKVVzXmA94e2OzxwgAkxQ5LtSX2sdYXjGvA7tmOHRf8ATydEPc9z7m6UpvNGc8RAd88bbH3UBx5YxGTfK0y1o50h4OgK0PObfHsVT6M1txOH5/i1SXt6Qdie8B24tnzL0w79wpVsM2aw2BTahcdII5ymBbgAxAnoOe7Fnur1HFs79JKvqhjBCS/jVvWHp4xzytjtl0KqnpdkNXs8Eh8XFkBhoQkLS5q416Y/Dn5spyzSFXRcQTn7MMhUK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA3PR11MB186312.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(6133799003)(10063799003)(22082099003)(18002099003)(10067099003)(3023799007)(5023799004)(4143699003)(261009223027099003)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekQzWUZPSXBKWFdjaERxb1M1VGQ5d3Rmanh3a1BrZmxIcDZWUURKdnlBRHlO?= =?utf-8?B?Y2Y4OHd5QUdkNXNMRDByakVkbHZMUWswbFhvc0JDUThSNFQwbVNVbzFGZUVB?= =?utf-8?B?dVUvbEpzcVBXVnpHUGdnTEJjZzBIUFhmdzBUZlVwcEx4RWJIYmlpVW9tTU9R?= =?utf-8?B?T2lWRTZNR1pwT3Zob2gwM2RkazBkbmY4K3JvZkowanhKRzhJdGVId2dHUzdT?= =?utf-8?B?VW4yUFgxQ2szWGx1bGcxczRtWVpodytkUmFtOHJtTHVaNlp6UElldFExdGdh?= =?utf-8?B?Q0pUZjlRd3VaYkxLTVNQWXlwd3owV2lSakh3ZzBoeGZRaXdJaU1zYllWUjNt?= =?utf-8?B?M0ZmWFIvS3MyanN6WFl3U1hySlJtSjVsODFyUGU5ZXRkcjNibFM3VlJRM0JO?= =?utf-8?B?S2NuUFU3cytyU0VFcnZuUjJSaFJrRDlKb2tDR1BEY05FK2dXcG44dEJMQmhs?= =?utf-8?B?MjJ2cU5mLzZQNy9BQzE0ZU9mYzk2ZlUrRUEzVW9IS05OdHJWYWF0QTR1Uml0?= =?utf-8?B?WlQ5MUduSGl3amN6cExlTzM2NmF5TmcxdWtvdWNEZDB6cFNQeWlvRWlyc05z?= =?utf-8?B?aGFhaGlTS3psbW8wZnpGVVB5YnZ3eVA3T3AvdE9IMzBEREtsS2xGZ2QwR2cr?= =?utf-8?B?TmlDK011T0RDNi92UmVLVnI2enBmVHZQTzl6OW85WXVISHp2bG1KUEQwKzhS?= =?utf-8?B?WmZYbmFPbi9rdm1PcjRtSEROMG9HMCtOc3BtOEdLekxKMWFmZGd6djhzdlJz?= =?utf-8?B?SnpYKy9QRS9xOUluOTF4QStYRlpRRkZOaVdiRTB3Z0hTV3UvZGpxRzBqMlgw?= =?utf-8?B?SXpZY2N5MCttZGd5NkVwZGZPWmsvckV2c0pUUDNuTERHdEJXRGpHeDZ6TXFX?= =?utf-8?B?WkNFTUQwRlJXbE8rMTVWT0g5bHRkeVNwOHI4TUZ1R1hPZy9paVZpdXAxN1dX?= =?utf-8?B?RndJemZVbzRmVmx0Y3Z0MlR3Smg3bmZsMzRLSVNSSUQ1aUdMSTBVR1l5U0Ev?= =?utf-8?B?cUVLRGxlL2diSXdtSjhWeTdlZUVYYmU5MCs4WWxkbGxHa0xTYWp1bENuSmY5?= =?utf-8?B?ZXFKMm5NemxiNG9jLzBIaW9LZ3lDVUN0T2s5Z2k4T1JtOWZaWnd1bzV3K3dn?= =?utf-8?B?YTVmV2VUd2pWeklUMVBoVnlzNXViaE9vTmFaRGdCK1YzVi9IcnVDYnUwczNJ?= =?utf-8?B?UDFqTERzOU1QUHdXT2RsOEl1M1hLbGJWMkJsSmx4R3dVcGl0S2ZiZUxTTWZx?= =?utf-8?B?MlZTVGE0eElHY2NjWVZ3bDNBUkhSY3dwbUxQL3I0MkxneHM4K0JwRS8vTEl0?= =?utf-8?B?cXgxU0QrRmRldVNVOXhmd0xVN1QwbVJKY2EyMFZhLytQM0VVYUtiVEpwb2hj?= =?utf-8?B?Z2xlOUhsY0tNWnVYRlJxS3NtYVMrNTJTMDBLZWxRVmxKSk1JM1UxclJvZXdG?= =?utf-8?B?ZjRBT05NUm1ZSFF1VXAzK1dxeTZ2emo5MXhkY1kzeFBEYkRKNWlMS2ZyZS9Z?= =?utf-8?B?TUFuRFhhQlBkMDlYdG0vYi91UVBLR1pKOU5LZElRYzY1RFZxZVczeG1hK3JE?= =?utf-8?B?eFpRWTB3a0I4Tk40Nm5OMzVqU0h5S2xrSXR2Vk1HQlIyZHF4VzBqWFhMVjZ5?= =?utf-8?B?V0wrM2F3YVlwWVpmU1BCZm5JSnpFRmdKdmFMdEIyeGpmZjR0Q3o2WkQ0eVZk?= =?utf-8?B?ZEdOYS83K2RHU20vdm53UjJubCtrSmYxeWtyN09JcEd1bDNKczhtbXRMZDUw?= =?utf-8?B?dTAvcUxpU3hMQWhBWTNOSUpPTndkTURTcUgzSDJqNWg5YkNHVGQyYzVieU5M?= =?utf-8?B?VDladXIzZjgrU3MwRVEyMDgwRzFpYTlpR1ZSTmptL3l5cGo1c01Cc1BJb0xx?= =?utf-8?B?cjdORkw0UStNcUlMV1h1bnFOMU11NEJuRFdTY3h2a1ZuZVhuSktybVByU1k4?= =?utf-8?B?OEFoTThjTERJV1lKcFhtR05PaHFxL3pvaTI4a3BFQzRMdEV3SVhUNGg2TkdL?= =?utf-8?B?WVdRRnVsY1ZYTnNQR21NdzJQMlhURGNVM3ExQjBvend1Y3g0ajQyNjFjQ3lt?= =?utf-8?B?ZThSYmxManRUTS9HZDNwVnIyM3FGbjRUellTbGswSW4xZXlrT2NkZmNULzVQ?= =?utf-8?B?MXd4aUJQVCs1Yk0vNWpnWE01eWtjcmw3NGVqQU0yeHlvZUNTM3hUVS94eG9m?= =?utf-8?B?SzRCNWp3SFB6cUtDWUU3d29GeGgxZnloSkRlK0V0eXhhRUFGWks1RExwTW13?= =?utf-8?B?bVhjQVJsRUJRNER1MWw3c3hwTVhKaUdlb2lPbVBwV1FaN3M5R29xaHZybjV1?= =?utf-8?B?OFhKbkhKS3A1enpGeXMzd09NaXRvczBNWVMxaU11SCs4QXVid3Urc0oyTjRZ?= =?utf-8?Q?BHJmkV/47E84DL3c=3D?= X-Exchange-RoutingPolicyChecked: svjg/x/UMNOgsUZuaXh+/DSjgtsFWd4nPidKFRwWDHZduziuwHpgZdpvrjuMAltWefG4ZqBspu1aJ2E+VkXpmwByzsxjXL7zl6kHwnLZOxFpkWQVT0HsFr+QgWSReVr7CqLaNCEsothedFOz3/jY1nh/lhc4nwgeizMd4e2Oi3Yd+2kzQOBcwvWDMaubAICf1RWXk/xTyFUu9e0l34px8uLze5dDfW7nHQ3KrTloDX8AC5MfTD64mGHzoMjQqoY6YQ99MhJLp3uwie+TbzgSMEWCGeFsCoYqTCsbboQ8OcUWp1WsLx4jNX3SE1/43yhGR5ojW6B8/YttYy5Rk4xLXg== X-MS-Exchange-CrossTenant-Network-Message-Id: 12471ddd-404a-4dac-7c8a-08df294d9ab8 X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB186312.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 17:15:39.6477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lAafpisxEoGyDiZSim3WkeKdTQjiD4RHuEx15xArGxjleyqN/++720hIuodlEVRL2VB+I1a8JKnuiTWAqVXqMo4cltWj7x+ws33ktk4KTvs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL4PR11MB8870 X-OriginatorOrg: intel.com X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org On 10/13/2026 9:41 AM, Tantilov, Emil S wrote: > > > On 10/9/2026 2:56 PM, sashiko-bot@kernel.org wrote: >> Thank you for your contribution! Sashiko AI review found 1 potential >> issue(s) to consider: >> - [High] idpf: double free of adapter->ptp due to concurrent >> idpf_ptp_release() >> -- >> >> commit 140d271eb2e765967ee1a351714e7ad1ecc7d8f6 >> Author: Emil Tantilov >> >> idpf: release PTP before freeing vports on the init task error path >> >> Release PTP, which cancels the aux worker, before the unwind frees the >> vports, matching the idpf_vc_core_deinit() order. Previously it was >> possible for idpf_ptp_update_cached_phctime() which runs via the PTP >> auxiliary worker to read a non-NULL but already freed slot, pass its NULL >> check, and dereference the freed vport. >> >>> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/ >>> net/ethernet/intel/idpf/idpf_lib.c >>> index a1c739cdd5406..9c541dd6ed4d4 100644 >>> --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c >>> +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c >>> @@ -1747,6 +1747,8 @@ void idpf_init_task(struct work_struct *work) >>>       return; >>>   unwind_vports: >>> +    idpf_ptp_release(adapter); >>> + >> >> [Severity: High] >> Does this create a race condition that can result in a double free of >> adapter->ptp? >> >> If idpf_remove() or a hard reset is triggered, it invokes >> idpf_vc_core_deinit(). >> >> idpf_vc_core_deinit() calls idpf_ptp_release() before it calls >> idpf_deinit_task(), which is what cancels this init_task: >> >> drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:idpf_vc_core_deinit() { >>      ... >>      idpf_ptp_release(adapter); >>      idpf_deinit_task(adapter); >>      ... >> } >> >> Concurrently, if this asynchronous idpf_init_task() fails during >> initialization, its error path (unwind_vports) also calls >> idpf_ptp_release() >> without locking or serialization against concurrent teardown. >> >> idpf_ptp_release() performs an unlocked check-and-free: >> >> drivers/net/ethernet/intel/idpf/idpf_ptp.c:idpf_ptp_release() { >>      struct idpf_ptp *ptp = adapter->ptp; >> >>      if (!ptp) >>          return; >>      ... >>      kfree(ptp); >>      adapter->ptp = NULL; >> } >> >> If both threads execute this concurrently, could both read the non- >> NULL pointer, >> leading to concurrent executions of ptp_clock_unregister() and a >> double free >> via kfree(ptp)? Actually, idpf_init_task() cannot run concurrently with idpf_vc_core_deinit(). The init task is only queued from idpf_vc_core_init(), and from itself to create the next vport. idpf_vc_core_init() is only called from idpf_init_hard_reset(), which runs from the event task, on driver load as well as on a reset. Once idpf_vc_core_init() succeeds, idpf_init_hard_reset() waits for the init task to finish: while (test_bit(IDPF_HR_RESET_IN_PROG, adapter->flags)) msleep(100); The init task clears IDPF_HR_RESET_IN_PROG only in its last run, at the end of the success path, or as the last statement of the unwind, after its idpf_ptp_release(). The bit stays set while it re-queues itself. idpf_remove() and idpf_shutdown() cancel the event task before calling idpf_vc_core_deinit(), and a hard reset calls it from the event task itself, whose previous run has already waited for the init task. So idpf_vc_core_deinit() finds either adapter->ptp intact, or already released and cleared by the unwind, in which case idpf_ptp_release() returns early. This patch does not change that: the unwind already released PTP before clearing IDPF_HR_RESET_IN_PROG, it now does so before freeing the vports as well. Two concurrent releases are possible on shutdown, but between two idpf_vc_core_deinit() calls: idpf_shutdown() does not set IDPF_REMOVE_IN_PROG, so a Tx timeout or an RDMA reset request can re-queue the event task after it was cancelled and start a hard reset alongside the shutdown. That is being addressed by different patch, pending on -net: https://lore.kernel.org/intel-wired-lan/ca88d67c-1595-4bd7-9560-080de7104e6d@intel.com/T/#u which sets the bit in idpf_shutdown() as in idpf_remove(). >> >>>       if (default_vport) { >>>           for (index = 0; index < adapter->max_vports; index++) { >>>               if (adapter->vports[index]) >> [ ... ] >> > > I will address it in v2. Correction, I think this series can stay as is with the one hit above being dealt with in a patch in the "destroy vport on shutdown" series: https://lore.kernel.org/intel-wired-lan/20261013121224.84482-1-luckilystar08@gmail.com/T/#t Sorry for the confusion, Emil