From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF5CDC433EF for ; Thu, 12 May 2022 05:54:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-Awd5cjQSNsSMl7-Eh8b6sA-1; Thu, 12 May 2022 01:54:40 -0400 X-MC-Unique: Awd5cjQSNsSMl7-Eh8b6sA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB9EE90E980; Thu, 12 May 2022 05:54:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id A251C415F56; Thu, 12 May 2022 05:54:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C985F193220C; Thu, 12 May 2022 05:54:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 23DBC1947041 for ; Wed, 11 May 2022 17:18:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EF2487774; Wed, 11 May 2022 17:18:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B67A453CF for ; Wed, 11 May 2022 17:18:32 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A075F86B8AC for ; Wed, 11 May 2022 17:18:32 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-675-Mi6Krt_IOp6dmFY-BOILTw-1; Wed, 11 May 2022 13:18:28 -0400 X-MC-Unique: Mi6Krt_IOp6dmFY-BOILTw-1 X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="269431798" X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="269431798" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 10:17:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="636495042" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 11 May 2022 10:17:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 10:17:22 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 10:17:21 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2308.027; Wed, 11 May 2022 10:17:21 -0700 From: "Luck, Tony" To: Borislav Petkov , "Williams, Dan J" Thread-Topic: [PATCH v9 3/7] mce: fix set_mce_nospec to always unmap the whole page Thread-Index: AQHYVqBhtO9kfcaX30Okv6G3eRqhwq0Znj6AgABQagCAABkaEA== Date: Wed, 11 May 2022 17:17:21 +0000 Message-ID: <5aa1c9aacc5a4086a904440641062669@intel.com> References: <20220422224508.440670-1-jane.chu@oracle.com> <20220422224508.440670-4-jane.chu@oracle.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 x-originating-ip: [10.1.200.100] MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mailman-Approved-At: Thu, 12 May 2022 05:54:34 +0000 Subject: Re: [dm-devel] [PATCH v9 3/7] mce: fix set_mce_nospec to always unmap the whole page X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jane Chu , Linux NVDIMM , "Jiang, Dave" , Mike Snitzer , Peter Zijlstra , "Darrick J. Wong" , Jue Wang , X86 ML , david , Linux Kernel Mailing List , Matthew Wilcox , Christoph Hellwig , "Hansen, Dave" , device-mapper development , Vivek Goyal , Andy Lutomirski , "Verma, Vishal L" , linux-fsdevel , "Weiny, Ira" , Alasdair Kergon Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > I - just like you - am waiting for Tony to say whether he still needs > this whole_page() thing. I already suggested removing it so I'm fine > with this patch. IIRC this new patch effectively reverts back to the original behavior that I implemented back at the dawn of time. I.e. just always mark the whole page "not present" and don't try to mess with UC mappings to allow partial (but non-speculative) access to the not-poisoned parts of the page. If that is the case ... then Acked-by: Tony Luck If I've misunderstood ... then please explain what it is doing. Thanks -Tony -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E8882F25 for ; Wed, 11 May 2022 17:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652289451; x=1683825451; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WHDdURNms3aWfdEJX5KkrqUkQcS2EWtnqEvYYDuGX0w=; b=afrKiHwVsBOcgAkrOMqFvsKPEbG3/5gqOK19u91+p5D9Az6tr2R1LgCa lh9r+Im/BcTBTsqj+uVuAWiXLQyL7f87VGIymvBGK+u0wSn32DKyDTs24 mhnSPUSUd4ReOQYFXUHrTx9TKEKrV6KbOSjPH+YOacHWsio6vDkQdy8Rr gF8/uYWk0922vNUpXHbuL9bl2dLZiIx/vWYBGMHqB8ZrCjrykc/5ZiU/T r7ststOzTfj1oe96hg1x4jXYPXEsjW8aeV14anzeNzd7K4lN+ag0FPvt1 G4keJ9deoMMCd99lTJ6n+WTjlgEc4+Ym5nvz8tjjl3h9X3I+BEhL/n6Cw A==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="268597193" X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="268597193" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 10:17:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="636495042" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 11 May 2022 10:17:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 10:17:22 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 10:17:21 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2308.027; Wed, 11 May 2022 10:17:21 -0700 From: "Luck, Tony" To: Borislav Petkov , "Williams, Dan J" CC: Jane Chu , Christoph Hellwig , "Hansen, Dave" , Peter Zijlstra , Andy Lutomirski , david , "Darrick J. Wong" , linux-fsdevel , Linux NVDIMM , Linux Kernel Mailing List , X86 ML , "Verma, Vishal L" , "Jiang, Dave" , Alasdair Kergon , Mike Snitzer , device-mapper development , "Weiny, Ira" , Matthew Wilcox , Vivek Goyal , Jue Wang Subject: RE: [PATCH v9 3/7] mce: fix set_mce_nospec to always unmap the whole page Thread-Topic: [PATCH v9 3/7] mce: fix set_mce_nospec to always unmap the whole page Thread-Index: AQHYVqBhtO9kfcaX30Okv6G3eRqhwq0Znj6AgABQagCAABkaEA== Date: Wed, 11 May 2022 17:17:21 +0000 Message-ID: <5aa1c9aacc5a4086a904440641062669@intel.com> References: <20220422224508.440670-1-jane.chu@oracle.com> <20220422224508.440670-4-jane.chu@oracle.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 PiBJIC0ganVzdCBsaWtlIHlvdSAtIGFtIHdhaXRpbmcgZm9yIFRvbnkgdG8gc2F5IHdoZXRoZXIg aGUgc3RpbGwgbmVlZHMNCj4gdGhpcyB3aG9sZV9wYWdlKCkgdGhpbmcuIEkgYWxyZWFkeSBzdWdn ZXN0ZWQgcmVtb3ZpbmcgaXQgc28gSSdtIGZpbmUNCj4gd2l0aCB0aGlzIHBhdGNoLg0KDQpJSVJD IHRoaXMgbmV3IHBhdGNoIGVmZmVjdGl2ZWx5IHJldmVydHMgYmFjayB0byB0aGUgb3JpZ2luYWwg YmVoYXZpb3IgdGhhdA0KSSBpbXBsZW1lbnRlZCBiYWNrIGF0IHRoZSBkYXduIG9mIHRpbWUuIEku ZS4ganVzdCBhbHdheXMgbWFyayB0aGUgd2hvbGUNCnBhZ2UgIm5vdCBwcmVzZW50IiBhbmQgZG9u J3QgdHJ5IHRvIG1lc3Mgd2l0aCBVQyBtYXBwaW5ncyB0byBhbGxvdw0KcGFydGlhbCAoYnV0IG5v bi1zcGVjdWxhdGl2ZSkgYWNjZXNzIHRvIHRoZSBub3QtcG9pc29uZWQgcGFydHMgb2YgdGhlDQpw YWdlLg0KDQpJZiB0aGF0IGlzIHRoZSBjYXNlIC4uLiB0aGVuIEFja2VkLWJ5OiBUb255IEx1Y2sg PHRvbnkubHVja0BpbnRlbC5jb20+DQoNCklmIEkndmUgbWlzdW5kZXJzdG9vZCAuLi4gdGhlbiBw bGVhc2UgZXhwbGFpbiB3aGF0IGl0IGlzIGRvaW5nLg0KDQpUaGFua3MNCg0KLVRvbnkNCg==