All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuki Kokubun <orga.chem.job@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] filter-branch: fix errors caused by refs that point at non-committish
Date: Sun, 25 Mar 2018 16:39:45 +0000	[thread overview]
Message-ID: <5ab7d35a.9060650a.fe7a7.04ef@mx.google.com> (raw)
In-Reply-To: <xmqqr2o8f7hd.fsf@gitster-ct.c.googlers.com>

References: <xmqqr2o8f7hd.fsf@gitster-ct.c.googlers.com>
	<xmqqvadmilx5.fsf@gitster-ct.c.googlers.com>
	<5ab46520.0352650a.cc02b.a177@mx.google.com>
	<20180323050913.5188-1-orga.chem.job@gmail.com> 
Content-Type: text/plain

> Grammo (third-person singular 'prints' misspelt without 's'; the
> "when" clause has a complex subject but no verb).
> 
> Perhaps this will salvage what you meant:
> 
> 	"git filter-branch -- --all" prints error messages when
> 	processing refs that point at objects that are not
> 	committish.

Thanks. I'm gonna fix it.

> Please sign-off your patch (cf. Documentation/SubmittingPatches).

OK I'm gonna add it.

I greatly appreciate for your kind review.
I couldn't write this patch without your help.
Thanks.

  reply	other threads:[~2018-03-25 16:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 10:35 [PATCH] filter-branch: consider refs/replace can refer to an object other than commit Yuki Kokubun
2018-03-21 15:31 ` [PATCH] filter-branch: consider refs can refer to an object other than commit or tag Yuki Kokubun
2018-03-21 17:21   ` Junio C Hamano
2018-03-21 20:00     ` Yuki Kokubun
2018-03-21 20:00       ` Junio C Hamano
2018-03-22 14:26         ` Yuki Kokubun
2018-03-22 17:01           ` Junio C Hamano
2018-03-23  2:15             ` Yuki Kokubun
2018-03-23  5:09               ` [PATCH v2] filter-branch: fix errors caused by refs that cannot be used with ^0 Yuki Kokubun
2018-03-23 20:20                 ` Junio C Hamano
2018-03-24 19:29                   ` [PATCH] filter-branch: consider refs can refer to an object other than commit or tag Yuki Kokubun
2018-03-24 19:41                   ` [PATCH v3] filter-branch: fix errors caused by refs that point at non-committish Yuki Kokubun
2018-03-25 16:25                     ` Junio C Hamano
2018-03-25 16:39                       ` Yuki Kokubun [this message]
2018-03-25 20:24                         ` Junio C Hamano
2018-03-25 16:54                       ` [PATCH v4] " Yuki Kokubun
2018-03-25 16:45                         ` Yuki Kokubun
2018-04-08 23:10                           ` Junio C Hamano
2018-03-25 17:01                         ` [PATCH v5] " Yuki Kokubun
2018-03-25 17:13                         ` [PATCH v4] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ab7d35a.9060650a.fe7a7.04ef@mx.google.com \
    --to=orga.chem.job@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.