From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Tao Ren <taoren@fb.com>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
C?ric Le Goater <clg@kaod.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [RFC PATCH dev-5.1 4/6] i2c: aspeed: fix master pending state handling
Date: Thu, 20 Jun 2019 13:34:21 -0700 [thread overview]
Message-ID: <5afd2271-e5f4-1358-a1b3-da00a9fc8fb1@linux.intel.com> (raw)
In-Reply-To: <4ef34869-3425-1258-2ab6-eecfee063aef@fb.com>
On 6/20/2019 1:30 PM, Tao Ren wrote:
> On 6/20/19 12:49 PM, Jae Hyun Yoo wrote:
>> In case of a master pending state, it should not trigger the master
>> command because this H/W is sharing the same data buffer for slave
>> and master operation, so this commit fixes the issue with making
>> the master command triggering happens when the state goes to active
>> state.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Thank you Jae for the patch. I believe I hit the bug while debugging BMC-BIC multi-master communication on my Minipack ast2500 BMC platform. Let me apply the patch and run some testing, will try to share my results by this Friday (Pacific Time).
Thank you Tao for your help for testing it. It would be really helpful
to complete this patch implementation. Will wait the test results.
Regards,
Jae
>
>
> Cheers,
>
> Tao
>
next prev parent reply other threads:[~2019-06-20 20:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 19:49 [RFC PATCH dev-5.1 0/6] Aspeed I2C buffer/DMA mode support Jae Hyun Yoo
2019-06-20 19:49 ` [RFC PATCH dev-5.1 1/6] dt-bindings: i2c: aspeed: add buffer and DMA mode transfer support Jae Hyun Yoo
2019-06-20 19:49 ` [RFC PATCH dev-5.1 2/6] ARM: dts: aspeed: add I2C buffer mode support Jae Hyun Yoo
2019-06-20 19:49 ` [RFC PATCH dev-5.1 3/6] irqchip/aspeed-i2c-ic: add I2C SRAM enabling control Jae Hyun Yoo
2019-06-21 0:33 ` Ryan Chen
2019-06-21 18:41 ` Jae Hyun Yoo
2019-06-25 17:23 ` Jae Hyun Yoo
2019-06-26 5:10 ` Ryan Chen
2019-06-26 21:18 ` Jae Hyun Yoo
2019-06-20 19:49 ` [RFC PATCH dev-5.1 4/6] i2c: aspeed: fix master pending state handling Jae Hyun Yoo
2019-06-20 20:30 ` Tao Ren
2019-06-20 20:34 ` Jae Hyun Yoo [this message]
2019-06-21 22:11 ` Tao Ren
2019-06-21 22:33 ` Jae Hyun Yoo
2019-06-20 19:49 ` [RFC PATCH dev-5.1 5/6] i2c: aspeed: add buffer mode transfer support Jae Hyun Yoo
2019-06-21 22:29 ` Tao Ren
2019-06-21 22:34 ` Jae Hyun Yoo
2019-06-24 23:54 ` Tao Ren
2019-06-25 17:18 ` Jae Hyun Yoo
2019-06-20 19:49 ` [RFC PATCH dev-5.1 6/6] i2c: aspeed: add DMA " Jae Hyun Yoo
2019-06-21 15:46 ` [RFC PATCH dev-5.1 0/6] Aspeed I2C buffer/DMA mode support Cédric Le Goater
2019-06-21 16:57 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5afd2271-e5f4-1358-a1b3-da00a9fc8fb1@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.