From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times
Date: Fri, 14 Dec 2018 13:58:06 +0000 [thread overview]
Message-ID: <5afda7f5-d9db-93bd-c562-e358e99b3083@intel.com> (raw)
In-Reply-To: <9f00684f-33ec-174f-c90a-4192803b5fc8@intel.com>
On 14/12/2018 13:30, Lionel Landwerlin wrote:
> On 14/12/2018 11:58, Matthew Auld wrote:
>> On Tue, 11 Dec 2018 at 18:06, Lionel Landwerlin
>> <lionel.g.landwerlin@intel.com> wrote:
>>> Not quite sure how that fell through the cracks for so long...
>>>
>>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
>> It looks like we initialize it earlier :)
>
>
> I can't see where :|
>
> Unless it's in the test_blocking() which is a different test.
Sorry, missed some other refactoring deleting that previous one.
Dropping this patch.
Thanks,
-
Lionel
>
>
>>
>>> ---
>>> tests/perf.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/perf.c b/tests/perf.c
>>> index 220c52ef..54e7f4f4 100644
>>> --- a/tests/perf.c
>>> +++ b/tests/perf.c
>>> @@ -2230,6 +2230,7 @@ test_polling(void)
>>> * the error delta.
>>> */
>>> start = get_time();
>>> + times(&start_times);
>>> do_ioctl(stream_fd, I915_PERF_IOCTL_ENABLE, 0);
>>> for (/* nop */; ((end = get_time()) - start) <
>>> test_duration_ns; /* nop */) {
>>> struct pollfd pollfd = { .fd = stream_fd, .events =
>>> POLLIN };
>>> --
>>> 2.20.0.rc2
>>>
>>> _______________________________________________
>>> igt-dev mailing list
>>> igt-dev@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-14 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 18:06 [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations Lionel Landwerlin
2018-12-11 18:06 ` [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times Lionel Landwerlin
2018-12-14 11:58 ` Matthew Auld
2018-12-14 13:30 ` Lionel Landwerlin
2018-12-14 13:58 ` Lionel Landwerlin [this message]
2018-12-11 18:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations Patchwork
2018-12-11 20:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-14 11:19 ` [igt-dev] [PATCH i-g-t 1/2] " Lionel Landwerlin
2018-12-14 11:48 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5afda7f5-d9db-93bd-c562-e358e99b3083@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=matthew.william.auld@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.