From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] nfs_lib: Unify testing on netns
Date: Tue, 10 Mar 2020 16:01:17 +0300 [thread overview]
Message-ID: <5b00a232-d175-9cb1-ba20-ccd5d6e93cdc@oracle.com> (raw)
In-Reply-To: <20200305192716.10313-1-pvorel@suse.cz>
Hi Petr,
On 05.03.2020 22:27, Petr Vorel wrote:
> There is no need to run tests on opposite client/server when using
> $TST_USE_NETNS based setup. It's enough just to set lhost IP address.
> This simplifies code a bit.
It changes the testcase, this way nfs traffic will go through
lo interface, the test won't use ltp_ns_veth* and netns.
We could add the knob for this scenario with LTP_NFS_USE_NETNS={1|0}?
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs_lib.sh | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index 66f2fb038..2d5535dc5 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -50,14 +50,6 @@ nfs_setup_server()
> {
> local export_cmd="exportfs -i -o fsid=$$,no_root_squash,rw *:$remote_dir"
>
> - if [ -n "$LTP_NETNS" ]; then
> - if [ ! -d $remote_dir ]; then
> - mkdir -p $remote_dir
> - ROD $export_cmd
> - fi
> - return
> - fi
> -
> if ! tst_rhost_run -c "test -d $remote_dir"; then
> tst_rhost_run -s -c "mkdir -p $remote_dir; $export_cmd"
> fi
> @@ -79,11 +71,6 @@ nfs_mount()
> local mnt_cmd="mount -t nfs $opts $mount_dir $local_dir"
>
> tst_res TINFO "Mounting NFS: $mnt_cmd"
> - if [ -n "$LTP_NETNS" ]; then
> - tst_rhost_run -s -c "$mnt_cmd"
> - return
> - fi
> -
> ROD $mnt_cmd
> }
>
>
next prev parent reply other threads:[~2020-03-10 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 19:27 [LTP] [PATCH 1/2] nfs_lib: Unify testing on netns Petr Vorel
2020-03-05 19:27 ` [LTP] [PATCH 2/2] nfs: Detect disabled UDP Petr Vorel
2020-03-10 13:34 ` Alexey Kodanev
2020-03-10 16:44 ` Petr Vorel
2020-03-10 13:01 ` Alexey Kodanev [this message]
2020-03-10 15:46 ` [LTP] [PATCH 1/2] nfs_lib: Unify testing on netns Petr Vorel
2020-03-11 14:35 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b00a232-d175-9cb1-ba20-ccd5d6e93cdc@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.